Re: [PATCH v4 05/49] v4l: Add pad-level DV timings subdev operations

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Mauro,

On Tuesday 13 May 2014 13:51:20 Mauro Carvalho Chehab wrote:
> Em Thu, 17 Apr 2014 16:12:36 +0200 Laurent Pinchart escreveu:
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> > Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
> > ---
> > 
> >  include/media/v4l2-subdev.h    |  4 ++++
> >  include/uapi/linux/videodev2.h | 10 ++++++++--
> >  2 files changed, 12 insertions(+), 2 deletions(-)

[snip]

> > diff --git a/include/uapi/linux/videodev2.h
> > b/include/uapi/linux/videodev2.h index ea468ee..8e5077e 100644
> > --- a/include/uapi/linux/videodev2.h
> > +++ b/include/uapi/linux/videodev2.h

[snip]

> > @@ -1150,11 +1153,14 @@ struct v4l2_bt_timings_cap {
> >
> >  /** struct v4l2_dv_timings_cap - DV timings capabilities
> >   * @type:	the type of the timings (same as in struct v4l2_dv_timings)
> > + * @pad:	the pad number for which to query capabilities (used with
> > + *		v4l-subdev nodes only)
> >   * @bt:		the BT656/1120 timings capabilities
> >   */
> >  
> >  struct v4l2_dv_timings_cap {
> >  	__u32 type;
> > -	__u32 reserved[3];
> > +	__u32 pad;
> 
> Please document its usage at the media DocBook.

Please have a look at "[PATCH v4 25/49] v4l: Add support for DV timings ioctls 
on subdev nodes" :-)

> > +	__u32 reserved[2];
> >  	union {
> >  		struct v4l2_bt_timings_cap bt;
> >  		__u32 raw_data[32];

-- 
Regards,

Laurent Pinchart