From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAC7F412C0C; Tue, 4 Aug 2026 19:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785872673; cv=none; b=i5QeAE7D+NRytmRN7Hbtp2tA/zQOKinBL9WLxHPD4HJ9OLxMZUab0bk2MD4MP7dENgcOFi5A6iqSCjSwypAYHlI5cdKL/FC7p55/uGXnX5eiDtkv4TL8qQqI1C5z77EtYqr8JBLgu28OekT0ZIbwNT/lqg6zucZeIZUjxhGZ31I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785872673; c=relaxed/simple; bh=j3+K4h1wrpUIVVhL+z3lvViBQkniwHOhXJr+jcUmteI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MyaWryVrg+CRx4nbctDUDONBrxLat3Fn3g2PL62n5VHX2S7S2X15xgX1eDVU8G2/GIygasIUpv7byjVB+Am7N/+0UAL1KBRNyar02q/Cthlu7CWhsVuru/ymGT8ICxonlq0DIgUZtf5m1VNvq4tVgvcNIntt5i+2+73TvJJIPRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=wZvbJyPQ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="wZvbJyPQ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kfMWIjz06sn4XEVpzbsEA+MT9XMJpOofhYIonsVdqUE=; b=wZvbJyPQqM/v0df4gh/qeWP1AM CNyjsrV0dEBeBzsN0EA5fVwLpZPkJo+Y0EWu4YFXyHaxDcMpuRQiLee31C3bIeAFsK3nlURlXVXhr X72cTVsUzoTDdJ3AWJWQufHm4+Hr3DOWGy65GgA35/EnkzIEKx2GaU2ZI34FqoYhEELA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wrL3g-00G358-11; Tue, 04 Aug 2026 21:44:16 +0200 Date: Tue, 4 Aug 2026 21:44:15 +0200 From: Andrew Lunn To: James Hilliard Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Richard Genoud , Maxime Ripard , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Heiner Kallweit , Russell King , Saravana Kannan , Lee Jones , Heiko Stuebner , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mfd@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 10/21] net: phy: add X-Powers AC200 EPHY control driver Message-ID: <62591c23-87c5-4dd5-bf3b-d9adba3ae2cb@lunn.ch> References: <05b1e6a2-725e-4b8e-8629-249637bbcb81@lunn.ch> <9b8be475-1fde-409c-a82e-be4b2e402650@lunn.ch> <205e9051-8e43-44bb-a4b5-4ec69a192fa3@lunn.ch> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > However, the MFD and networking portions necessarily meet at the AC200 > EPHY function. I do not think the correct way to avoid that > cross-subsystem dependency is to make a driver bound to an MDIO > phy_device take ownership of registers and resources belonging to an > MFD device. We can pull the MFD Maintainer into this, but an MFD core driver typically just provides methods to access the shared registers, and instantiates drivers to make use of those shared registers. In this case, we don't need the instantiate part, that happens via the MDIO bus model. But we do need access to the shared registers. I personally don't care too much how that is done, but regmap would be normal. The PHY driver should then drive the whole, entire PHY, using both MDIO and whatever method the MFD exports to give access to the registers. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E4F6C55ABA for ; Tue, 4 Aug 2026 19:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c7vwPT2c0GfZsabLIzF3hinhfD1TWTQxCrfsGK6ipP8=; b=O59s2yeAm4r5qe xcrQTbjPXBvEQJaWe+vfWGRscUVi3z46EQzBHY0NjAGcKY6y02lmIq384T82z6hamqrm0GdFiPfjQ p1UhrJrOYadC+xarPdb32Io9oJM5U0+H//+zNgDZ8EasG5lgnHmZVdiXJuTQjAIT052F5vvZ7bw5t 0dSCF9RI3MO3BS3ppjAoymztcvQ3zn8Uy4eS8rIExRJwe8y5bJOdTiEhR5fZwXzWeB+jpvWQYnENQ Tguk+WBlSvShOQohIcRJHvuui+HHrBJh0zmer+fNyxUCp2urkNX6Pemb1FWnePV/aOFSOQ1VzVhvT LefMbdh4JRG1vwNxxmzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrL40-00000002hla-1i8f; Tue, 04 Aug 2026 19:44:36 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrL3y-00000002hj9-1QSL; Tue, 04 Aug 2026 19:44:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kfMWIjz06sn4XEVpzbsEA+MT9XMJpOofhYIonsVdqUE=; b=wZvbJyPQqM/v0df4gh/qeWP1AM CNyjsrV0dEBeBzsN0EA5fVwLpZPkJo+Y0EWu4YFXyHaxDcMpuRQiLee31C3bIeAFsK3nlURlXVXhr X72cTVsUzoTDdJ3AWJWQufHm4+Hr3DOWGy65GgA35/EnkzIEKx2GaU2ZI34FqoYhEELA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wrL3g-00G358-11; Tue, 04 Aug 2026 21:44:16 +0200 Date: Tue, 4 Aug 2026 21:44:15 +0200 From: Andrew Lunn To: James Hilliard Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Richard Genoud , Maxime Ripard , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Heiner Kallweit , Russell King , Saravana Kannan , Lee Jones , Heiko Stuebner , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mfd@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 10/21] net: phy: add X-Powers AC200 EPHY control driver Message-ID: <62591c23-87c5-4dd5-bf3b-d9adba3ae2cb@lunn.ch> References: <05b1e6a2-725e-4b8e-8629-249637bbcb81@lunn.ch> <9b8be475-1fde-409c-a82e-be4b2e402650@lunn.ch> <205e9051-8e43-44bb-a4b5-4ec69a192fa3@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260804_124434_380148_EE795B32 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org > However, the MFD and networking portions necessarily meet at the AC200 > EPHY function. I do not think the correct way to avoid that > cross-subsystem dependency is to make a driver bound to an MDIO > phy_device take ownership of registers and resources belonging to an > MFD device. We can pull the MFD Maintainer into this, but an MFD core driver typically just provides methods to access the shared registers, and instantiates drivers to make use of those shared registers. In this case, we don't need the instantiate part, that happens via the MDIO bus model. But we do need access to the shared registers. I personally don't care too much how that is done, but regmap would be normal. The PHY driver should then drive the whole, entire PHY, using both MDIO and whatever method the MFD exports to give access to the registers. Andrew _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip