All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: Alpine: smp support
Date: Mon, 26 Jan 2015 12:08:19 +0100	[thread overview]
Message-ID: <6259906.i1F47ar7ng@wuerfel> (raw)
In-Reply-To: <54c53660.F+mWFCmG+/oPpFS5%tsahee@annapurnalabs.com>

On Sunday 25 January 2015 20:30:56 Tsahee Zidenberg wrote:

> This patch introduces support for waking up secondary CPU cores on
> Alpine platform.

The actual code looks good, I just have minor comments about the
formatting:

> +
> +	np = of_find_compatible_node(
> +		NULL, NULL, "annapurna-labs,al-cpu-resume");

When wrapping lines, please continue the next line at the point of the
opening braces, like:


	np = of_find_compatible_node(NULL, NULL,
	                             "annapurna-labs,al-cpu-resume");

> +	al_cpu_resume_regs =
> +			(struct al_cpu_resume_regs __iomem *)of_iomap(np, 0);

Or remove a type case when it is not required.

> +int __cpuinit alpine_boot_secondary(unsigned int cpu
> +				, struct task_struct *idle)

As above.

	Arnd

  reply	other threads:[~2015-01-26 11:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 18:30 [PATCH 3/4] ARM: Alpine: smp support Tsahee Zidenberg
2015-01-26 11:08 ` Arnd Bergmann [this message]
2015-01-26 11:44 ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6259906.i1F47ar7ng@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.