Re: [PATCH mptcp-next 2/7] selftests: mptcp: add missing kconfig for NF Filter in v6

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

Thank you for the review!

Hi Geliang,

Thank you for the review!

On 22/01/2024 02:47, Geliang Tang wrote:
>> Since the commit mentioned below, 'mptcp_join' selftests is using
>> IPTables to add rules to the Filter table for IPv6.
>>
>> It is then required to have IP6_NF_FILTER KConfig.
>>
>> This KConfig is usually enabled by default in many defconfig, but we
>> recently noticed that some CI were running our selftests without them
>> enabled.
>>
>> Fixes: 523514ed0a99 ("selftests: mptcp: add ADD_ADDR IPv6 test cases")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>>  tools/testing/selftests/net/mptcp/config | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
>> index 2a00bf4acdfa..ec70b27288fc 100644
>> --- a/tools/testing/selftests/net/mptcp/config
>> +++ b/tools/testing/selftests/net/mptcp/config
>> @@ -20,6 +20,7 @@ CONFIG_NETFILTER_XT_TARGET_MARK=m
>>  CONFIG_NF_TABLES_INET=y
>>  CONFIG_NFT_TPROXY=m
>>  CONFIG_NFT_SOCKET=m
>> +CONFIG_IP6_NF_FILTER=m
> 
> How about adding this config right after CONFIG_IP_NF_TARGET_REJECT=m?
> 
> Since "IPv6: Netfilter Configuration" section in kconfig is always
> after "IP: Netfilter Configuration" one.

My intension was to place this new entry there to keep the file sorted
by alphabetical order. It is often recommended to do that for that kind
of files to ease the backports. So I put it before "IP_ADVANCED_ROUTER".

But now, I realise this file is not fully sorted by alphabetical order :)

I don't think the order matter, but I can place it after
"IPV6_MULTIPLE_TABLES". I can do that when applying the patches: I don't
think I need to send a v2 just for that.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.