From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] checkpatches.sh: Add checks for ABI symbol addition Date: Mon, 15 Jan 2018 22:52:25 +0100 Message-ID: <6261725.cSDxTUqfeb@xps> References: <20180115190545.25687-1-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com, Ferruh Yigit To: Neil Horman Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5531F2BBE for ; Mon, 15 Jan 2018 22:52:57 +0100 (CET) In-Reply-To: <20180115190545.25687-1-nhorman@tuxdriver.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/01/2018 20:05, Neil Horman: > Recently, some additional patches were added to allow for programmatic > marking of C symbols as experimental. The addition of these markers is > dependent on the manual addition of exported symbols to the EXPERIMENTAL > section of the corresponding libraries version map file. The consensus > on review is that, in addition to mandating the addition of symbols to > the EXPERIMENTAL version in the map, we need a mechanism to enforce our > documented process of mandating that addition when they are introduced. > To that end, I am proposing this change. It is an addition to the > checkpatches script, which scan incoming patches for additions and > removals of symbols to the map file, and warns the user appropriately Thanks for working on this. I won't pretend that I understand anything in this awk script :) I think it would be better to put this code in a new script, let's say check-symbol-change.sh, and call it in checkpatches.sh. It would be just moving functions, add your copyright, and list the new script in your MAINTAINERS section "ABI versioning".