From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Date: Tue, 5 Dec 2017 10:09:33 +0000 Subject: [U-Boot] [PATCH 05/14] env: Make it explicit where we're loading our environment from In-Reply-To: <45c910bdc2ad56e4ab10612ca801692812b3bbfc.1511864667.git-series.maxime.ripard@free-electrons.com> References: <45c910bdc2ad56e4ab10612ca801692812b3bbfc.1511864667.git-series.maxime.ripard@free-electrons.com> Message-ID: <626a9c31-0326-6ffb-beb4-693e07ae41e4@arm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 28/11/17 10:24, Maxime Ripard wrote: > Since we can have multiple environments now, it's better to provide a > decent indication on what environments were tried and which were the one to > fail and succeed. > > Signed-off-by: Maxime Ripard > --- > env/env.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/env/env.c b/env/env.c > index 1d13220aa79b..44f9908e2c2d 100644 > --- a/env/env.c > +++ b/env/env.c > @@ -109,12 +109,11 @@ int env_load(void) > if (!drv->load) > continue; > > + printf("Loading Environment from %s... ", drv->name); > ret = drv->load(); > + printf("%s\n", ret ? "Failed" : "OK"); This looses the error code that was printed with debug() below. Might be worth to keep it? Either always or as a debug? printf("%s (%d)\n", ...); Cheers, Andre. > if (!ret) > return 0; > - > - debug("%s: Environment %s failed to load (err=%d)\n", __func__, > - drv->name, ret); > } > > return -ENODEV; >