From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wl@xen.org>,
"Anthony PERARD" <anthony.perard@citrix.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Bernhard Kaindl" <bernhard.kaindl@citrix.com>
Subject: Re: [PATCH 5/7] tools: Use -s for python shebangs
Date: Tue, 14 Mar 2023 14:50:48 +0000 [thread overview]
Message-ID: <626de813-99aa-6d44-c895-73e9cdd19967@citrix.com> (raw)
In-Reply-To: <20230314141520.3652451-6-andrew.cooper3@citrix.com>
On 14/03/2023 2:15 pm, Andrew Cooper wrote:
> diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
> index 29ad0513212f..04b3995cc0f6 100644
> --- a/tools/pygrub/Makefile
> +++ b/tools/pygrub/Makefile
> @@ -7,7 +7,7 @@ PY_LDFLAGS = $(SHLIB_LDFLAGS) $(APPEND_LDFLAGS)
> INSTALL_LOG = build/installed_files.txt
>
> setup.py = CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" LDFLAGS="$(PY_LDFLAGS)" \
> - $(PYTHON) setup.py
> + $(PYTHON) setup.py --executable="$(PYTHON_PATH) -s"
/sigh
CI has gone a wall of red to this. Apparently --executable is only
known by setuputils, not distutils.
Which is a problem because it means the main pygrub executable won't get
a corrected shebang, as it doesn't pass through install-wrap.
In the short term, I could fix that by moving the main pygrub binary out
of setup.py and do it manually. Thoughts?
~Andrew
next prev parent reply other threads:[~2023-03-14 14:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 14:15 [PATCH 0/7] tools: More Python 3 fixes (part 1 of N) Andrew Cooper
2023-03-14 14:15 ` [PATCH 1/7] tools/python: Drop pylintrc Andrew Cooper
2023-03-16 11:23 ` Anthony PERARD
2023-03-16 18:00 ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 2/7] tools/misc: Drop xencons Andrew Cooper
2023-03-16 11:33 ` Anthony PERARD
2023-03-16 12:05 ` Andrew Cooper
2023-03-16 18:01 ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 3/7] tools: Delete trailing whitespace in python scripts Andrew Cooper
2023-03-16 11:35 ` Anthony PERARD
2023-03-16 18:02 ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 4/7] tools/pygrub: Factor out common setup.py parts Andrew Cooper
2023-03-16 11:39 ` Anthony PERARD
2023-03-14 14:15 ` [PATCH 5/7] tools: Use -s for python shebangs Andrew Cooper
2023-03-14 14:50 ` Andrew Cooper [this message]
2023-03-16 12:15 ` Anthony PERARD
2023-03-16 19:37 ` [PATCH v2 " Andrew Cooper
2023-03-16 20:09 ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 6/7] tools/python: Improve unit test handling Andrew Cooper
2023-03-16 18:06 ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 7/7] tools/python: Drop shebangs from library files Andrew Cooper
2023-03-16 18:12 ` Marek Marczykowski-Górecki
2023-03-15 2:37 ` [PATCH 0/7] tools: More Python 3 fixes (part 1 of N) Henry Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=626de813-99aa-6d44-c895-73e9cdd19967@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=bernhard.kaindl@citrix.com \
--cc=marmarek@invisiblethingslab.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.