From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support Date: Thu, 24 Nov 2016 13:34:03 +0530 Message-ID: <626df165-da09-298e-ed60-03d4119caec2@codeaurora.org> References: <8737j2bxba.wl%kuninori.morimoto.gx@renesas.com> <20161108111009.GO1041@n2100.armlinux.org.uk> <87oa1pscne.wl%kuninori.morimoto.gx@renesas.com> <87vavdcvgh.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87vavdcvgh.wl%kuninori.morimoto.gx@renesas.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Kuninori Morimoto Cc: Russell King - ARM Linux , Mark Brown , David Airlie , Fabio Estevam , Daniel Vetter , Koji Matsuoka , Thierry Reding , Linux-ALSA , Liam Girdwood , Simon , linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jose Abreu List-Id: alsa-devel@alsa-project.org Hi, On 11/24/2016 10:43 AM, Kuninori Morimoto wrote: > > Hi Archit, David, and DRM ML > > I had heared that Archit is the maintainer of dw-hdmi driver, but am I wrong ?? > I'm posting this patch series since half year ago, but no response > from him, and nothing happen (I got review from Russell though). > Is Archit really maintainer ?? > OTOH, get_maintainer.pl indicates David is the maintainer ? > What should I do for this patch ?? I'm not the maintainer of the dw-hdmi driver, but I pull in the changes that go into drm/bridge/ Will pull this. Thanks, Archit > >> Hi Russell >> >>>> @@ -11,4 +11,11 @@ struct dw_hdmi_audio_data { >>>> u8 *eld; >>>> }; >>>> >>>> +struct dw_hdmi_i2s_audio_data { >>>> + struct dw_hdmi *hdmi; >>>> + >>>> + void (*write)(struct dw_hdmi *hdmi, u8 val, int offset); >>>> + u8 (*read)(struct dw_hdmi *hdmi, int offset); >>>> +}; >>> >>> Another slight concern here is why we need this separate data for i2s - >>> maybe adding the write/read ops to struct dw_hdmi_audio_data would be >>> a better thing to do, which would then allow the AHB audio to drop >>> the .base argument in the future. >>> >>> I'm not that bothered about this though. So... >> >> Thank you for your feedback. >> Maybe we can merge these in incremental patch if needed ? >> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project