From: Martin KaFai Lau <martin.lau@linux.dev>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] tcp/dccp: cache line align inet_hashinfo
Date: Fri, 4 Aug 2023 16:13:44 -0700 [thread overview]
Message-ID: <626eb8ca-858b-680c-64ea-3d2b0a7d7908@linux.dev> (raw)
In-Reply-To: <CANn89iKhp6ghj6-+n9RXvP-Bc33kOdSMSTM1KQj=WSQ2DhgPWQ@mail.gmail.com>
On 8/4/23 1:33 PM, Eric Dumazet wrote:
> On Fri, Aug 4, 2023 at 10:30 AM <patchwork-bot+netdevbpf@kernel.org> wrote:
>>
>> Hello:
>>
>> This patch was applied to netdev/net-next.git (main)
>> by David S. Miller <davem@davemloft.net>:
>>
>> On Thu, 3 Aug 2023 07:53:34 +0000 you wrote:
>>> I have seen tcp_hashinfo starting at a non optimal location,
>>> forcing input handlers to pull two cache lines instead of one,
>>> and sharing a cache line that was dirtied more than necessary:
>>>
>>> ffffffff83680600 b tcp_orphan_timer
>>> ffffffff83680628 b tcp_orphan_cache
>>> ffffffff8368062c b tcp_enable_tx_delay.__tcp_tx_delay_enabled
>>> ffffffff83680630 B tcp_hashinfo
>>> ffffffff83680680 b tcp_cong_list_lock
>>>
>>> [...]
>>
>> Here is the summary with links:
>> - [net-next] tcp/dccp: cache line align inet_hashinfo
>> https://git.kernel.org/netdev/net-next/c/6f5ca184cbef
>>
>> You are awesome, thank you!
>> --
>> Deet-doot-dot, I am a bot.
>> https://korg.docs.kernel.org/patchwork/pwbot.html
>>
>>
>
> Thanks !
>
> Apparently this misalignment came with
>
> commit cae3873c5b3a4fcd9706fb461ff4e91bdf1f0120
> Author: Martin KaFai Lau <kafai@fb.com>
> Date: Wed May 11 17:06:05 2022 -0700
>
> net: inet: Retire port only listening_hash
Ah. Thanks for the fix. TIL.
prev parent reply other threads:[~2023-08-04 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 7:53 [PATCH net-next] tcp/dccp: cache line align inet_hashinfo Eric Dumazet
2023-08-04 8:30 ` patchwork-bot+netdevbpf
2023-08-04 20:33 ` Eric Dumazet
2023-08-04 23:13 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=626eb8ca-858b-680c-64ea-3d2b0a7d7908@linux.dev \
--to=martin.lau@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.