From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F657C4332F for ; Thu, 5 May 2022 14:02:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359154AbiEEOGW (ORCPT ); Thu, 5 May 2022 10:06:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380320AbiEEOGV (ORCPT ); Thu, 5 May 2022 10:06:21 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1264B5838B; Thu, 5 May 2022 07:02:42 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id bv19so8940107ejb.6; Thu, 05 May 2022 07:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Q9neuIG6NME92B0FTzFk6RBoNBkN6kIQjOv1wlxUZcU=; b=XIIk6Ky7qtfn8kZ/UQxBkUibIgQ47XkLw3jhb74lL4r+BcqtYPw3WOBfHbeNqIEIBf s6IqSw0ArC0/JQs86L/9KZN/GBBCHaIjS0o0vp79Pp/Xzj6m1WWRjlc15KM58Sn42Kub sEYbu21flVZvQcqwv201GAWI+nbswCy45nSKmKnc95jpoZbmMIxjY+CXNsHHBgrIlQLd c/ckr5COEpUhkD1kXWhgB8csewg2A8syj3ZKZkxf125j9zuQ5IndrpJWOtG3gBsn4OJ+ lfGBNNHIfwijVGk0SAJXQs+sqf0SV8f9QBTQ+SY9XUqQ+MVVSZk26mYtg+zVWrZjmvzP JcHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Q9neuIG6NME92B0FTzFk6RBoNBkN6kIQjOv1wlxUZcU=; b=oTSbgYD8EUS4yIa9lUZ/nWpozcE15VZvgdA7YgGkZzUvF/CdOoflWNzXGAPoTREYmO Axm+Ey65P6J7zAi734pA4+Kv5TDxP+m7FRAgW/EdX1WuFoeV/UzEWSv2pW9JlACYjPEk Pn1wRntZFha46GwN2nOtFlPPFM5Y5SMBI3SAQyirhetAl/GF5fNNO6Z+wNjrPICHLiYv mGmVxQn4n5RsIulyUIbzJmCxbNC4ZTF1RH38tyc1eDoVmPaLdQAenboav88nuGOkhnt0 42VUBWuhm2eYeC5TTiU9uIA60Mt1aCR8470zf5v2VvT3pboWaLqrqEOK3M9XX0FRSO0l e8jg== X-Gm-Message-State: AOAM531MaxgdvKODGjWUAboaZ1hl/cN77HKYM6JFakuYJogJS2zRLeCa GtI7oUnRaKI6fJ/E+pXcbuY= X-Google-Smtp-Source: ABdhPJyX7xzlri/QMUL6XIi2P62Xw0xu4IOyk6r8bZQael56Hh4wyTvmQfVBbU4Raq3O/J5FlDmR6w== X-Received: by 2002:a17:906:9749:b0:6f5:6cd:5bd9 with SMTP id o9-20020a170906974900b006f506cd5bd9mr1522345ejy.523.1651759360471; Thu, 05 May 2022 07:02:40 -0700 (PDT) Received: from Ansuel-xps. (93-42-70-190.ip85.fastwebnet.it. [93.42.70.190]) by smtp.gmail.com with ESMTPSA id h23-20020a1709070b1700b006f3ef214e3fsm769447ejl.165.2022.05.05.07.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 07:02:40 -0700 (PDT) Message-ID: <6273d900.1c69fb81.fbc61.4680@mx.google.com> X-Google-Original-Message-ID: Date: Thu, 5 May 2022 16:02:38 +0200 From: Ansuel Smith To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Rob Herring , Krzysztof Kozlowski , Pavel Machek , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Hauke Mehrtens , Jacek Anaszewski , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch, vivien.didelot@gmail.com, Vladimir Oltean , Jonathan Corbet , John Crispin , linux-doc@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers References: <20220505135512.3486-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220505135512.3486-1-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, May 05, 2022 at 03:55:07PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > Some LEDs are designed to represent a state of another device. That may > be USB port, Ethernet interface, CPU, hard drive and more. > > We already have support for LEDs that are designed to indicate USB port > (e.g. light on when USB device gets connected). There is DT binding for > that and Linux implementation in USB trigger. > > This patchset adds support for describing LEDs that should react to > Ethernet interface status. That is commonly used in routers. They often > have LED to display state and activity of selected physical port. It's > also common to have multiple LEDs, each reacting to a specific link > speed. > I notice this is specific to ethernet speed... I wonder if we should expand this also to other thing like duplex state or even rx/tx. > Patch 5/5 is proof of concept and is not meant to be applied yet. > > Rafał Miłecki (5): > dt-bindings: net: add bitfield defines for Ethernet speeds > dt-bindings: net: allow Ethernet devices as LED triggers > dt-bindings: leds: add Ethernet triggered LEDs to example > ARM: dts: BCM5301X: Add triggers for Luxul XWR-1200 network LEDs > leds: trigger: netdev: support DT "trigger-sources" property > > .../devicetree/bindings/leds/common.yaml | 21 +++++++++++++++ > .../bindings/net/ethernet-controller.yaml | 3 +++ > arch/arm/boot/dts/bcm47081-luxul-xwr-1200.dts | 22 +++++++++++---- > drivers/leds/trigger/ledtrig-netdev.c | 26 ++++++++++++++++++ > include/dt-bindings/net/eth.h | 27 +++++++++++++++++++ > 5 files changed, 94 insertions(+), 5 deletions(-) > create mode 100644 include/dt-bindings/net/eth.h > > -- > 2.34.1 > -- Ansuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77512C433FE for ; Thu, 5 May 2022 14:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KgDnzM0VoHIMKGh7JExOXbfI96ZQYHtbnlf0B1K/3zc=; b=ZVDyU4eaFzj0Wk znZgLXLa+MvUBI99DmrS9x8AMEkVy2vkZNtzOVV7vT8HVwcl8LeB3w2Cx0UrQH7sqakCdxtFZu4Tm s0ttlO3q+8eLxQP/RT9gF4jreVo2ZKjNGMgQPyIfmOqvwK4qozCe2h1CUlho8XZAeJNb+dlmRoFuA 0I/dvHiruWC7F7PI/xuyXDsPCJVSNYkMYzVXAp+rhEhtG9IkuuXNtYqOoU5WGYoWOt3fvi/cdUNGB 1opMvl1EvsvejH5nCYl/plYQ0rEVvDwexmbmBNtaNr0t3AxrNo2ynsWhLu0seAMxUk5JxnfFBgDdv ayMUjSQDeRemyTJdJdTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmc4A-00GFmw-16; Thu, 05 May 2022 14:02:50 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmc44-00GFjx-9H for linux-arm-kernel@lists.infradead.org; Thu, 05 May 2022 14:02:45 +0000 Received: by mail-ej1-x632.google.com with SMTP id n10so8944005ejk.5 for ; Thu, 05 May 2022 07:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Q9neuIG6NME92B0FTzFk6RBoNBkN6kIQjOv1wlxUZcU=; b=XIIk6Ky7qtfn8kZ/UQxBkUibIgQ47XkLw3jhb74lL4r+BcqtYPw3WOBfHbeNqIEIBf s6IqSw0ArC0/JQs86L/9KZN/GBBCHaIjS0o0vp79Pp/Xzj6m1WWRjlc15KM58Sn42Kub sEYbu21flVZvQcqwv201GAWI+nbswCy45nSKmKnc95jpoZbmMIxjY+CXNsHHBgrIlQLd c/ckr5COEpUhkD1kXWhgB8csewg2A8syj3ZKZkxf125j9zuQ5IndrpJWOtG3gBsn4OJ+ lfGBNNHIfwijVGk0SAJXQs+sqf0SV8f9QBTQ+SY9XUqQ+MVVSZk26mYtg+zVWrZjmvzP JcHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Q9neuIG6NME92B0FTzFk6RBoNBkN6kIQjOv1wlxUZcU=; b=QUUjkqxiZF0ZO+ccrSE5yTHSyvHCoGxXAHy84juDSf37Xo02R3oP3QwCNO7wRBlFLg R18S61krldsYbiKOJyMKCgQYgVN+2B/qN2OBcS84f4BsfpKl3uwCTF1FqmDnShau0AEb yw/WjAA3dsovGbDTk2E8sMtkyp2msg7TJppbNyAKL1Lcjju+l8GoI/LuKFyCksukwR1b j+oadg/EEbAZSZ6BB4UZrZKP7mwzuCymAkYr03JZM1weqqy4LisvydKLMQr2tgPlFpjB wKVn7CiRx7kA+7kKWyP/yv795669NSci2JxXWdTKl0pkxfdaw+ig9eoctrb3sSeVAfo0 iT5w== X-Gm-Message-State: AOAM532FQ6yQ4Hu9yxJyOxuEEJbzJmb8JfoUuOsw9D0I9PCXxwicHPli oD9IG36dwG89yEFw+aiJmG8= X-Google-Smtp-Source: ABdhPJyX7xzlri/QMUL6XIi2P62Xw0xu4IOyk6r8bZQael56Hh4wyTvmQfVBbU4Raq3O/J5FlDmR6w== X-Received: by 2002:a17:906:9749:b0:6f5:6cd:5bd9 with SMTP id o9-20020a170906974900b006f506cd5bd9mr1522345ejy.523.1651759360471; Thu, 05 May 2022 07:02:40 -0700 (PDT) Received: from Ansuel-xps. (93-42-70-190.ip85.fastwebnet.it. [93.42.70.190]) by smtp.gmail.com with ESMTPSA id h23-20020a1709070b1700b006f3ef214e3fsm769447ejl.165.2022.05.05.07.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 07:02:40 -0700 (PDT) Message-ID: <6273d900.1c69fb81.fbc61.4680@mx.google.com> X-Google-Original-Message-ID: Date: Thu, 5 May 2022 16:02:38 +0200 From: Ansuel Smith To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Rob Herring , Krzysztof Kozlowski , Pavel Machek , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Hauke Mehrtens , Jacek Anaszewski , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch, vivien.didelot@gmail.com, Vladimir Oltean , Jonathan Corbet , John Crispin , linux-doc@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers References: <20220505135512.3486-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220505135512.3486-1-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_070244_409092_91016744 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMDUsIDIwMjIgYXQgMDM6NTU6MDdQTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBT b21lIExFRHMgYXJlIGRlc2lnbmVkIHRvIHJlcHJlc2VudCBhIHN0YXRlIG9mIGFub3RoZXIgZGV2 aWNlLiBUaGF0IG1heQo+IGJlIFVTQiBwb3J0LCBFdGhlcm5ldCBpbnRlcmZhY2UsIENQVSwgaGFy ZCBkcml2ZSBhbmQgbW9yZS4KPiAKPiBXZSBhbHJlYWR5IGhhdmUgc3VwcG9ydCBmb3IgTEVEcyB0 aGF0IGFyZSBkZXNpZ25lZCB0byBpbmRpY2F0ZSBVU0IgcG9ydAo+IChlLmcuIGxpZ2h0IG9uIHdo ZW4gVVNCIGRldmljZSBnZXRzIGNvbm5lY3RlZCkuIFRoZXJlIGlzIERUIGJpbmRpbmcgZm9yCj4g dGhhdCBhbmQgTGludXggaW1wbGVtZW50YXRpb24gaW4gVVNCIHRyaWdnZXIuCj4gCj4gVGhpcyBw YXRjaHNldCBhZGRzIHN1cHBvcnQgZm9yIGRlc2NyaWJpbmcgTEVEcyB0aGF0IHNob3VsZCByZWFj dCB0bwo+IEV0aGVybmV0IGludGVyZmFjZSBzdGF0dXMuIFRoYXQgaXMgY29tbW9ubHkgdXNlZCBp biByb3V0ZXJzLiBUaGV5IG9mdGVuCj4gaGF2ZSBMRUQgdG8gZGlzcGxheSBzdGF0ZSBhbmQgYWN0 aXZpdHkgb2Ygc2VsZWN0ZWQgcGh5c2ljYWwgcG9ydC4gSXQncwo+IGFsc28gY29tbW9uIHRvIGhh dmUgbXVsdGlwbGUgTEVEcywgZWFjaCByZWFjdGluZyB0byBhIHNwZWNpZmljIGxpbmsKPiBzcGVl ZC4KPgoKSSBub3RpY2UgdGhpcyBpcyBzcGVjaWZpYyB0byBldGhlcm5ldCBzcGVlZC4uLiBJIHdv bmRlciBpZiB3ZSBzaG91bGQKZXhwYW5kIHRoaXMgYWxzbyB0byBvdGhlciB0aGluZyBsaWtlIGR1 cGxleCBzdGF0ZSBvciBldmVuIHJ4L3R4LgoKPiBQYXRjaCA1LzUgaXMgcHJvb2Ygb2YgY29uY2Vw dCBhbmQgaXMgbm90IG1lYW50IHRvIGJlIGFwcGxpZWQgeWV0Lgo+IAo+IFJhZmHFgiBNacWCZWNr aSAoNSk6Cj4gICBkdC1iaW5kaW5nczogbmV0OiBhZGQgYml0ZmllbGQgZGVmaW5lcyBmb3IgRXRo ZXJuZXQgc3BlZWRzCj4gICBkdC1iaW5kaW5nczogbmV0OiBhbGxvdyBFdGhlcm5ldCBkZXZpY2Vz IGFzIExFRCB0cmlnZ2Vycwo+ICAgZHQtYmluZGluZ3M6IGxlZHM6IGFkZCBFdGhlcm5ldCB0cmln Z2VyZWQgTEVEcyB0byBleGFtcGxlCj4gICBBUk06IGR0czogQkNNNTMwMVg6IEFkZCB0cmlnZ2Vy cyBmb3IgTHV4dWwgWFdSLTEyMDAgbmV0d29yayBMRURzCj4gICBsZWRzOiB0cmlnZ2VyOiBuZXRk ZXY6IHN1cHBvcnQgRFQgInRyaWdnZXItc291cmNlcyIgcHJvcGVydHkKPiAKPiAgLi4uL2Rldmlj ZXRyZWUvYmluZGluZ3MvbGVkcy9jb21tb24ueWFtbCAgICAgIHwgMjEgKysrKysrKysrKysrKysr Cj4gIC4uLi9iaW5kaW5ncy9uZXQvZXRoZXJuZXQtY29udHJvbGxlci55YW1sICAgICB8ICAzICsr Kwo+ICBhcmNoL2FybS9ib290L2R0cy9iY200NzA4MS1sdXh1bC14d3ItMTIwMC5kdHMgfCAyMiAr KysrKysrKysrKy0tLS0KPiAgZHJpdmVycy9sZWRzL3RyaWdnZXIvbGVkdHJpZy1uZXRkZXYuYyAg ICAgICAgIHwgMjYgKysrKysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvZHQtYmluZGluZ3MvbmV0 L2V0aC5oICAgICAgICAgICAgICAgICB8IDI3ICsrKysrKysrKysrKysrKysrKysKPiAgNSBmaWxl cyBjaGFuZ2VkLCA5NCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+ICBjcmVhdGUgbW9k ZSAxMDA2NDQgaW5jbHVkZS9kdC1iaW5kaW5ncy9uZXQvZXRoLmgKPiAKPiAtLSAKPiAyLjM0LjEK PiAKCi0tIAoJQW5zdWVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==