From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56260C433F5 for ; Thu, 5 May 2022 14:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232230AbiEEOeR (ORCPT ); Thu, 5 May 2022 10:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380716AbiEEOeO (ORCPT ); Thu, 5 May 2022 10:34:14 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89FCA101EE; Thu, 5 May 2022 07:30:34 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id z2so7513695ejj.3; Thu, 05 May 2022 07:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=uPRFuYIOzOX+lfHSk0TAnDa37PyGEjlIVUZQBvDYK1w=; b=Ms9X8X7IdWm5uZCCq9ScGLgW/sXkqzuQt2MfNvGCiSUdy3p1lmn/MQbFiO9gmHa4l5 SisY3i4Tnyif2yoKWa2WiCMUkEzJbVgp1xQN5CNGnuu0DG72B/S5X4+cqBg5ZzNFBI46 +KOpXVb50bBGy2bXxdsH/KdSPtoQW9d0hKi7dqah4HYBemjgMXT1+8mgOZfEHDiAYQTj 788BxS6V3RIr8akFPjMSeRasMYTWAOfMCBH2tamxmzbyA2CCzHQ1rAwJWmtmE2Urfxi9 hODTnyoCuYr0su4GNyEX6kBsTk/R7WmfF9k5DE1I6PRYGokbU+fSQseIw/uUqg3Y4So0 HBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uPRFuYIOzOX+lfHSk0TAnDa37PyGEjlIVUZQBvDYK1w=; b=HqTfpE5AOOhcb/aInSfzu6dl+xsDVzA7F8ECoeruD93LbZGW0BubJOOtzlnZrShun7 YFP7SvaZ21a0Y+ZojtU49Fj8YfcghqrOpp5DWlfHXkX1sRiUKUQ8RgM4mA02yQ3PgJf1 aLB0SYZ1EmCJRNWzqQGqqFrf7F8zoAJiZrDM/ZP5IoU4eIzVmUpE/WVWb+wQe2eolRRk wXcafGLfGuRZsX1G+5em+ypuU2VYAg2CEiGJJWVz/ARpAcLyCt+aD7VTCRfeUTY1UYaT mzUwni3wOFNZ1ZwUfJ/BFwZBfIVqmVGznq15WtZ3LNcbNDZWJWXiZKebj/YdSQvenV0b LGlw== X-Gm-Message-State: AOAM531p21hV/MKrhg9M+fjMotm/CHtYHqkhFwRn1M5bx1O67ldps6l5 B5ecVc6yYamTe3Emne6atW0= X-Google-Smtp-Source: ABdhPJyPihA5bLvhSw6UjJz5kS4lcJeRXQCszddNar6sz3CWTvzELecqGlLzWWo3/pL8xJfE3F+E5w== X-Received: by 2002:a17:907:a0c9:b0:6f4:bbdf:8081 with SMTP id hw9-20020a170907a0c900b006f4bbdf8081mr9156501ejc.257.1651761032841; Thu, 05 May 2022 07:30:32 -0700 (PDT) Received: from Ansuel-xps. (93-42-70-190.ip85.fastwebnet.it. [93.42.70.190]) by smtp.gmail.com with ESMTPSA id b18-20020aa7dc12000000b0042617ba63acsm918452edu.54.2022.05.05.07.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 07:30:32 -0700 (PDT) Message-ID: <6273df88.1c69fb81.1757e.5347@mx.google.com> X-Google-Original-Message-ID: Date: Thu, 5 May 2022 16:30:30 +0200 From: Ansuel Smith To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Rob Herring , Krzysztof Kozlowski , Pavel Machek , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Hauke Mehrtens , Jacek Anaszewski , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch, vivien.didelot@gmail.com, Vladimir Oltean , Jonathan Corbet , John Crispin , linux-doc@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers References: <20220505135512.3486-1-zajec5@gmail.com> <6273d900.1c69fb81.fbc61.4680@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, May 05, 2022 at 04:21:33PM +0200, Rafał Miłecki wrote: > On 5.05.2022 16:02, Ansuel Smith wrote: > > On Thu, May 05, 2022 at 03:55:07PM +0200, Rafał Miłecki wrote: > > > From: Rafał Miłecki > > > > > > Some LEDs are designed to represent a state of another device. That may > > > be USB port, Ethernet interface, CPU, hard drive and more. > > > > > > We already have support for LEDs that are designed to indicate USB port > > > (e.g. light on when USB device gets connected). There is DT binding for > > > that and Linux implementation in USB trigger. > > > > > > This patchset adds support for describing LEDs that should react to > > > Ethernet interface status. That is commonly used in routers. They often > > > have LED to display state and activity of selected physical port. It's > > > also common to have multiple LEDs, each reacting to a specific link > > > speed. > > > > > > > I notice this is specific to ethernet speed... I wonder if we should > > expand this also to other thing like duplex state or even rx/tx. > > I didn't see any router with separated Rx/Tx LEDs, but it still sounds > like a valid case. > Not a normal configuration but it's doable. For qca8k you can really set the led to do whatever you want. > We could add flags for that in proposed field like: > trigger-sources = <&port (SPEED_1000 | LINK | TX)>; > > Or add separated field for non-speed flags like: > trigger-sources = <&port SPEED_1000 (LINK | TX)>; > > Let's see what DT experts say about it. -- Ansuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAF33C433F5 for ; Thu, 5 May 2022 14:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WrPvqLj34RKwwSIs6s10MLEa6YfDa9vbK/nlDhHN898=; b=ufm6MX7AcROdsm eK2ly5fAQTdIiLLf7WBJTf/Px8JOcS5WqBG6yy1jZALk+0NaoY3yecwsEj3vQlvgPNahaIo9sfyU1 2Ky2MxO9gT6TjsQAG8N8QDZTv23ezBRcS+E6B89Itg2NXE406aS8OB5fa4G+fjOy9kXhAIb6YRNxK Pz9yN+m2TX46Gp76deuTLOZsgkoKQ2hAbCr6xtYO3V2S+z9eR4/zjkibhVNnt5mNi0UDNurg3/WWX 6qrSoBgQuDTW2VBG81y+8sd/rw2k7wulYezeHxpAJsx/KSD2hZITuTLfK7xQoY8wQXZpUNIHZBLpS X5ahHTcM2gm1srp2QuXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmcV4-00GO7L-T6; Thu, 05 May 2022 14:30:39 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmcV1-00GO5z-7G for linux-arm-kernel@lists.infradead.org; Thu, 05 May 2022 14:30:37 +0000 Received: by mail-ej1-x633.google.com with SMTP id l18so9080047ejc.7 for ; Thu, 05 May 2022 07:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=uPRFuYIOzOX+lfHSk0TAnDa37PyGEjlIVUZQBvDYK1w=; b=Ms9X8X7IdWm5uZCCq9ScGLgW/sXkqzuQt2MfNvGCiSUdy3p1lmn/MQbFiO9gmHa4l5 SisY3i4Tnyif2yoKWa2WiCMUkEzJbVgp1xQN5CNGnuu0DG72B/S5X4+cqBg5ZzNFBI46 +KOpXVb50bBGy2bXxdsH/KdSPtoQW9d0hKi7dqah4HYBemjgMXT1+8mgOZfEHDiAYQTj 788BxS6V3RIr8akFPjMSeRasMYTWAOfMCBH2tamxmzbyA2CCzHQ1rAwJWmtmE2Urfxi9 hODTnyoCuYr0su4GNyEX6kBsTk/R7WmfF9k5DE1I6PRYGokbU+fSQseIw/uUqg3Y4So0 HBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uPRFuYIOzOX+lfHSk0TAnDa37PyGEjlIVUZQBvDYK1w=; b=HSKPIBzWdgBvoydLLHrN9SKmWKawB4vI8lQzROrvw2HcDRGZGPREKVwL+o0qfvBjgl YYsFm3sf+aLp+I4jiIyTDzJPuBmXcE0vp3FEg8NO5GxhMvWLP+37HKPyorNCZhjVr89v QANxZfS9Fo8Z270chc0Kt+sFfhMUvrgnwe+iRi9GTbvx9iEN9Fnrx98AkwHHDbFuT2Uk ajuFWOVUcBoVrEUJ1/G89qjo4AvfyMrWXO3Foo5iSCsnBjwwLxh+OcffQiqVWnVQ4dWA PLzYaoIshe6Y/7rCpJveHMiNlPE1ndUqL0aYX1N5VPNVq1r0wBHjKtHeQGP48tjP6HkL uKUg== X-Gm-Message-State: AOAM532MSIHI+NonOFjeD3fWapK3B/vMNJUHk/FjTUaEt8IZo4MKqxpN rjJYd4+0f6sljIBcTe37n0E= X-Google-Smtp-Source: ABdhPJyPihA5bLvhSw6UjJz5kS4lcJeRXQCszddNar6sz3CWTvzELecqGlLzWWo3/pL8xJfE3F+E5w== X-Received: by 2002:a17:907:a0c9:b0:6f4:bbdf:8081 with SMTP id hw9-20020a170907a0c900b006f4bbdf8081mr9156501ejc.257.1651761032841; Thu, 05 May 2022 07:30:32 -0700 (PDT) Received: from Ansuel-xps. (93-42-70-190.ip85.fastwebnet.it. [93.42.70.190]) by smtp.gmail.com with ESMTPSA id b18-20020aa7dc12000000b0042617ba63acsm918452edu.54.2022.05.05.07.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 07:30:32 -0700 (PDT) Message-ID: <6273df88.1c69fb81.1757e.5347@mx.google.com> X-Google-Original-Message-ID: Date: Thu, 5 May 2022 16:30:30 +0200 From: Ansuel Smith To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Rob Herring , Krzysztof Kozlowski , Pavel Machek , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Hauke Mehrtens , Jacek Anaszewski , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch, vivien.didelot@gmail.com, Vladimir Oltean , Jonathan Corbet , John Crispin , linux-doc@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers References: <20220505135512.3486-1-zajec5@gmail.com> <6273d900.1c69fb81.fbc61.4680@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_073035_298087_D3D0BF61 X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMDUsIDIwMjIgYXQgMDQ6MjE6MzNQTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IE9uIDUuMDUuMjAyMiAxNjowMiwgQW5zdWVsIFNtaXRoIHdyb3RlOgo+ID4gT24g VGh1LCBNYXkgMDUsIDIwMjIgYXQgMDM6NTU6MDdQTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tpIHdy b3RlOgo+ID4gPiBGcm9tOiBSYWZhxYIgTWnFgmVja2kgPHJhZmFsQG1pbGVja2kucGw+Cj4gPiA+ IAo+ID4gPiBTb21lIExFRHMgYXJlIGRlc2lnbmVkIHRvIHJlcHJlc2VudCBhIHN0YXRlIG9mIGFu b3RoZXIgZGV2aWNlLiBUaGF0IG1heQo+ID4gPiBiZSBVU0IgcG9ydCwgRXRoZXJuZXQgaW50ZXJm YWNlLCBDUFUsIGhhcmQgZHJpdmUgYW5kIG1vcmUuCj4gPiA+IAo+ID4gPiBXZSBhbHJlYWR5IGhh dmUgc3VwcG9ydCBmb3IgTEVEcyB0aGF0IGFyZSBkZXNpZ25lZCB0byBpbmRpY2F0ZSBVU0IgcG9y dAo+ID4gPiAoZS5nLiBsaWdodCBvbiB3aGVuIFVTQiBkZXZpY2UgZ2V0cyBjb25uZWN0ZWQpLiBU aGVyZSBpcyBEVCBiaW5kaW5nIGZvcgo+ID4gPiB0aGF0IGFuZCBMaW51eCBpbXBsZW1lbnRhdGlv biBpbiBVU0IgdHJpZ2dlci4KPiA+ID4gCj4gPiA+IFRoaXMgcGF0Y2hzZXQgYWRkcyBzdXBwb3J0 IGZvciBkZXNjcmliaW5nIExFRHMgdGhhdCBzaG91bGQgcmVhY3QgdG8KPiA+ID4gRXRoZXJuZXQg aW50ZXJmYWNlIHN0YXR1cy4gVGhhdCBpcyBjb21tb25seSB1c2VkIGluIHJvdXRlcnMuIFRoZXkg b2Z0ZW4KPiA+ID4gaGF2ZSBMRUQgdG8gZGlzcGxheSBzdGF0ZSBhbmQgYWN0aXZpdHkgb2Ygc2Vs ZWN0ZWQgcGh5c2ljYWwgcG9ydC4gSXQncwo+ID4gPiBhbHNvIGNvbW1vbiB0byBoYXZlIG11bHRp cGxlIExFRHMsIGVhY2ggcmVhY3RpbmcgdG8gYSBzcGVjaWZpYyBsaW5rCj4gPiA+IHNwZWVkLgo+ ID4gPiAKPiA+IAo+ID4gSSBub3RpY2UgdGhpcyBpcyBzcGVjaWZpYyB0byBldGhlcm5ldCBzcGVl ZC4uLiBJIHdvbmRlciBpZiB3ZSBzaG91bGQKPiA+IGV4cGFuZCB0aGlzIGFsc28gdG8gb3RoZXIg dGhpbmcgbGlrZSBkdXBsZXggc3RhdGUgb3IgZXZlbiByeC90eC4KPiAKPiBJIGRpZG4ndCBzZWUg YW55IHJvdXRlciB3aXRoIHNlcGFyYXRlZCBSeC9UeCBMRURzLCBidXQgaXQgc3RpbGwgc291bmRz Cj4gbGlrZSBhIHZhbGlkIGNhc2UuCj4KCk5vdCBhIG5vcm1hbCBjb25maWd1cmF0aW9uIGJ1dCBp dCdzIGRvYWJsZS4gRm9yIHFjYThrIHlvdSBjYW4gcmVhbGx5IHNldAp0aGUgbGVkIHRvIGRvIHdo YXRldmVyIHlvdSB3YW50LgoKPiBXZSBjb3VsZCBhZGQgZmxhZ3MgZm9yIHRoYXQgaW4gcHJvcG9z ZWQgZmllbGQgbGlrZToKPiB0cmlnZ2VyLXNvdXJjZXMgPSA8JnBvcnQgKFNQRUVEXzEwMDAgfCBM SU5LIHwgVFgpPjsKPiAKPiBPciBhZGQgc2VwYXJhdGVkIGZpZWxkIGZvciBub24tc3BlZWQgZmxh Z3MgbGlrZToKPiB0cmlnZ2VyLXNvdXJjZXMgPSA8JnBvcnQgU1BFRURfMTAwMCAoTElOSyB8IFRY KT47Cj4gCj4gTGV0J3Mgc2VlIHdoYXQgRFQgZXhwZXJ0cyBzYXkgYWJvdXQgaXQuCgotLSAKCUFu c3VlbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=