All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: sarath.ganapathiraju@oss.qualcomm.com, andersson@kernel.org,
	abelvesa@kernel.org, sboyd@kernel.org, bmasney+clk@redhat.com,
	jbrunet+clk@baylibre.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, srinivas.kandagatla@oss.qualcomm.com
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	prasad.kumpatla@oss.qualcomm.com
Subject: Re: [PATCH v14 2/2] clk: qcom: Add LPASS VA CSR heartbeat pulse clock
Date: Fri, 20 Nov 2026 09:58:51 +0100	[thread overview]
Message-ID: <627410e4-e674-4ea2-bccb-e1842f71fbe6@kernel.org> (raw)
In-Reply-To: <20261120-master-v14-2-112cfd63438d@oss.qualcomm.com>

On 20/11/2026 09:36, Sarath Ganapathiraju via B4 Relay wrote:
> From: Sarath Ganapathiraju <sarath.ganapathiraju@oss.qualcomm.com>
> 
> The HeartBeat Pulse, also known as RateGen Pulse, synchronizes the
> start of DMAs and Codec Interfaces for the audio usecases and can
> serve as a periodic wakeup source for the DSP.
> 
> Add the LPASS VA CSR driver that models the rate generator as a clock
> provider so consumers can enable and disable it through the common
> clock framework.
> 
> Attach the DT vote clocks to runtime PM and program the rate generator
> counter and delay registers from runtime resume after the votes are
> enabled. This restores the state if the LPASS register context is lost
> across runtime suspend.
> 
> Rely on the clock core provider runtime PM handling around clock
> prepare and unprepare to keep the votes active for regmap gate
> accesses. Use the same runtime suspend and resume callbacks for
> system sleep so the vote clocks are enabled before restoring the
> rate generator after suspend. Track the heartbeat gate state in the
> clock callbacks and restore LPASS_RATE_GEN_CTRL on resume when the
> clock was enabled before the LPASS register context was lost.
> 
> Reviewed-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> Tested-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> Signed-off-by: Sarath Ganapathiraju <sarath.ganapathiraju@oss.qualcomm.com>
> ---


So entire patch will need one more revision because of triviality in the
binding... why not making applying tags correctly :/

Best regards,
Krzysztof

      reply	other threads:[~2026-11-20  8:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  8:36 [PATCH v14 0/2] Add LPASS VA CSR HeartBeat pulse clock support Sarath Ganapathiraju via B4 Relay
2026-11-20  8:36 ` Sarath Ganapathiraju
2026-11-20  8:36 ` [PATCH v14 1/2] dt-bindings: clock: qcom: Add LPASS VA CSR HeartBeat pulse clock Sarath Ganapathiraju via B4 Relay
2026-11-20  8:36   ` Sarath Ganapathiraju
2026-11-20  8:57   ` Krzysztof Kozlowski
2026-11-20  8:36 ` [PATCH v14 2/2] clk: qcom: Add LPASS VA CSR heartbeat " Sarath Ganapathiraju via B4 Relay
2026-11-20  8:36   ` Sarath Ganapathiraju
2026-11-20  8:58   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=627410e4-e674-4ea2-bccb-e1842f71fbe6@kernel.org \
    --to=krzk@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prasad.kumpatla@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sarath.ganapathiraju@oss.qualcomm.com \
    --cc=sboyd@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.