From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B8D375ABE for ; Wed, 1 Jul 2026 16:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782923899; cv=none; b=bfvBZ5pDagFFM53CVw0UcVHWFCXx6f9cXZC8PK4D3WSly77s65r+LC0cxGPSWqI+0nCDbACo8Y9ghCXf056KDi1wn6UiC6VMtlVZSqmKUfwQL/7DB8PRWMP5FbpaNfcqgfg5QIFzrsLvJjLbQ+KeUXekaeFh1AthV3DM3LB54nE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782923899; c=relaxed/simple; bh=MCc33PG5p6gEO6J+a6fhcnys53i8ernfue4dysbXudM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uqqAfjBD+KFyfh66ltSixfPkIhu8QxbumvNoFxh4LeC8jso1ymszZ1or//c9aSwh293X91DOoSCwTpO9GtYgrAFJNg0Lj9SWeVXQ1oiBntXhGLn8xunzJTAhfBEqxXyR2oEE5oLIWrowGs/xW2h6xUbbnsP36ZdujG3g2fsmiXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codeweavers.com; spf=pass smtp.mailfrom=codeweavers.com; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b=JDbcc/td; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=VgxS59kM; arc=none smtp.client-ip=103.168.172.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b="JDbcc/td"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="VgxS59kM" Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 0E0D6EC0074; Wed, 1 Jul 2026 12:38:17 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Wed, 01 Jul 2026 12:38:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeweavers.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1782923897; x=1783010297; bh=EIuPCelpS6x6HFEtiUaJJ0W6Tkc0x9sn vE/elY1t2h0=; b=JDbcc/tdnhCpfqArSdp+vyrMV/q8WNg4j8GpWLMoVRxoxEOi S47JOlZfTZX6u73b//84GZjG+qDXXUgamMm/GuNX5nEGgG/qlUWBoD/I5mwqRPK4 MMVEGI61ZT13OsmHdn4VJ7AsrmIlEJwN1CtvGb6ZWVQnIvYeo87P+Z7p4vFBR4J7 W/k9zDE7FTOGsLTL6ibAeQDTdq1YxtSOqbJTcdl924z3Z/Ls+QbmhlnNou/fnnay mDExK4B5IUy+eeY8rmMCP+auQBu7inYsHD6BWZg0Z8OOuuo0yh8ZYT5NLInzfxk0 xCcVeBz7zPD3DDq4vbt+DyqrlFzjAGuXauUM9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1782923897; x= 1783010297; bh=EIuPCelpS6x6HFEtiUaJJ0W6Tkc0x9snvE/elY1t2h0=; b=V gxS59kM5kuPKyM6LdJqTLHv2L1EcwizjgJnq3rm31Pdw1EXoxOttlmaI2RfLUZR9 lFDphqfpMUpKBAAkcKN3EDNl+wD7NQI7wxpb0dvw1miYMfWqMa3UeDVQNqoz77tf 91163ySMRHxmhiJ2QDfY5pOdi7hH+JcE70cP2y+P8pi7xXrW0dxuC2W4qUTp3vPY qSa30/2kv5wKpheeN0gR9ru2Hi+l4doG5UXTf89nAkPSdglNcKBJ7dmOhwlbInnL LM5MOwEwku0vXeswHwovP5OXgNvV8xdchTKWsAh/gIrCIpqDmdJWqdh+iAlssOaZ N5LB7toLNxBQNzAxmSR4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGlDGVQBcgU6PtqszHG7KDGqFffpaecO7xDlkF47P0wBHYaTAnxZr8ZUMA1uriED5 pB9IBH6F399wix2OlhB6OOfQKsAbng2bTGXdtvDUS6AMEivXSQxBRyc1BotteIT4Jc3ivE qQtqXEorg5NsH6JXe++62dtIfBrrc5a9a/nXf5Yw81g9fcMpPtgH6bc25nBbpFHeD4F2oo pnQvU5YovIDVQJYZNIG5qOa3KBL/59Z2fvtEGwMIwUvkslfCnjkDEfovuXUTH+93L9GUbu enFybqS68ypBf6WR8lTR7bwExNSi/3KUPERtc6MdWyuEgrQCjK1CezQ7Y0O3vkXTTzu5OB ViIWMusSYIO7OyZ7tMfsxGXLyqr+XfyQKJzPCrSA/oHe7DbKyqRe0zRQ2L8Ma2uJ/eK1ON xzBa0i2JiA8iep1PIq4Z+LXZPgl8CuPqPPPJdCuOWIsNcQvzlePKeqtkZFVlexfo3SMIpf e6dmF+FoyEE9EFCgaSasltoG+o2rsOLbT4s8+GNN63OMHcuvNJ4npvJNt/lNn1UeDHOWZ+ QQiozi2nqssILGeRSTC5/KDj9BSD/qULCUVeRzjBNy+R+8qQZSVvv7bu3/rIid6hG6tVIZ hqaa684pEdvaBX7Ls0QMI7rwyyRLiigUdVXDt+isChQvmeC8Wi4V9SAnb5kg X-ME-Proxy: Feedback-ID: i01ae4b70:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Jul 2026 12:38:16 -0400 (EDT) From: Elizabeth Figura To: =?UTF-8?B?SXbDoW4=?= Ezequiel Rodriguez Cc: wine-devel@winehq.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] selftests: ntsync: fix wake_all CREATE_EVENT fd expectation Date: Wed, 01 Jul 2026 11:38:16 -0500 Message-ID: <6279993.lOV4Wx5bFT@camazotz> In-Reply-To: <20260628024239.152852-3-ivanrwcm25@gmail.com> References: <20260628024239.152852-1-ivanrwcm25@gmail.com> <20260628024239.152852-3-ivanrwcm25@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Saturday, 27 June 2026 21:42:37 CDT Iv=C3=A1n Ezequiel Rodriguez wrote: > wake_all used EXPECT_EQ(0, objs[3]) after NTSYNC_IOC_CREATE_EVENT. > The ioctl returns a non-negative file descriptor on success; check > EXPECT_LE(0, objs[3]) like the other CREATE_* paths. The incorrect > expectation was noted on list (Mar 2025) but is still present in > mainline. >=20 > Signed-off-by: Iv=C3=A1n Ezequiel Rodriguez > --- > tools/testing/selftests/drivers/ntsync/ntsync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/test= ing/selftests/drivers/ntsync/ntsync.c > index e6a37214aa46..12b4b81edf7f 100644 > --- a/tools/testing/selftests/drivers/ntsync/ntsync.c > +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c > @@ -968,7 +968,7 @@ TEST(wake_all) > auto_event_args.manual =3D false; > auto_event_args.signaled =3D true; > objs[3] =3D ioctl(fd, NTSYNC_IOC_CREATE_EVENT, &auto_event_args); > - EXPECT_EQ(0, objs[3]); > + EXPECT_LE(0, objs[3]); > =20 > wait_args.timeout =3D get_abs_timeout(1000); > wait_args.objs =3D (uintptr_t)objs; >=20 Reviewed-by: Elizabeth Figura =2D- This was already sent as and never committed.