From: Sven Eckelmann <sven@narfation.org>
To: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] ath_hw: Use common REG_WRITE parameter order
Date: Thu, 04 Oct 2012 19:42:59 +0200 [thread overview]
Message-ID: <6280245.pW1SF1FHQv@bentobox> (raw)
In-Reply-To: <CAB=NE6XrTVQuAqGqD2wjyjN6ynyfB+yHXqBcAhRgOn=njBpAuA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Thursday 04 October 2012 10:29:59 Luis R. Rodriguez wrote:
> On Thu, Oct 4, 2012 at 9:05 AM, Sven Eckelmann <sven@narfation.org> wrote:
> > All defines for REG_WRITE in Atheros wireless drivers use the order "ah",
> > "register" and "value". hw.c is the only file using the order "ah",
> > "value" and "register". This inconsistent definition can easily lead to
> > implementation errors.
> >
> > Signed-off-by: Sven Eckelmann <sven@narfation.org>
>
> Good catch! But can you resend specifying in your commit log that this
> change is a no-op?
I really don't know what you want from me here.
> Also it may help the reader for you to git grep and
> show the other REG_WRITE() definitions on the other c files within the
> commit log.
Ehrm, ok.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-04 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 16:05 [PATCH] ath_hw: Use common REG_WRITE parameter order Sven Eckelmann
2012-10-04 17:29 ` Luis R. Rodriguez
2012-10-04 17:42 ` Sven Eckelmann [this message]
2012-10-04 17:46 ` Luis R. Rodriguez
2012-10-04 17:43 ` [PATCHv2] " Sven Eckelmann
2012-10-04 20:35 ` Luis R. Rodriguez
2012-10-05 16:29 ` Arend van Spriel
2012-10-05 5:15 ` [PATCH] " Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6280245.pW1SF1FHQv@bentobox \
--to=sven@narfation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.