From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: spinlock: Move constructor function out of header
	file
Date: Fri, 15 Jul 2016 10:31:49 +0200
Message-ID: <6282391.Mg1yxlkp5v@xps13>
References: <20160714132729.27024-1-damarion@cisco.com>
 <16886146.HTal4qelT5@xps13> <A8DE54E9-B995-491B-AFA3-CE6792E242BE@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 David Marchand <david.marchand@6wind.com>
To: "Damjan Marion (damarion)" <damarion@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 1F1542A66
 for <dev@dpdk.org>; Fri, 15 Jul 2016 10:31:51 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id o80so18709677wme.1
 for <dev@dpdk.org>; Fri, 15 Jul 2016 01:31:51 -0700 (PDT)
In-Reply-To: <A8DE54E9-B995-491B-AFA3-CE6792E242BE@cisco.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-14 22:20, Damjan Marion:
>=20
> > On 15 Jul 2016, at 00:06, Thomas Monjalon <thomas.monjalon@6wind.co=
m> wrote:
> >=20
> > 2016-07-14 18:10, Damjan Marion:
> >> Dear Jan,
> >>=20
> >> Thank you for your comments. A bit too much overhead to submit sim=
ple patch
> >> so let=E2=80=99s forget about it. I will just add it as it is to o=
ur private
> >> collection of patches.
> >=20
> > These are changes trivial to fix when applying.
> > I strongly prefer that you upstream patches instead of keeping patc=
hes
> > in the VPP repository. I will help you in this task.
> > Thanks for the effort.
>=20
> Yeah, I agree with you, unfortunately it is all about time,
> for me it is still cheaper to rebase them.
>=20
> I respect your rules, but I just don=E2=80=99t have enough free cycle=
s
> to spend learning all of them, for my occasional patch submission.

We know there is a learning curve for the submission process.
That's why we do not expect it to be fully satisfied, especially
from occasional contributors.
I am used to do some not significant changes before applying to
help newcomers patches being accepted. That's what I will do in
your case.
As I said previously I will help you to drop your local patches.

Please continue sending other patches with a detailed explanation
and we will take care of them.