From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Peter Xu" <peterx@redhat.com>, "Fabiano Rosas" <farosas@suse.de>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
qemu-block@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Fam Zheng" <fam@euphon.net>, "Denis V. Lunev" <den@openvz.org>,
"Greg Kurz" <groug@kaod.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony@xenproject.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
xen-devel@lists.xenproject.org,
"Li Zhijian" <lizhijian@fujitsu.com>
Subject: Re: [PATCH 7/8] hw/9pfs: annotate V9fsTransport callbacks as coroutine_fn
Date: Tue, 21 Jul 2026 10:37:39 +0200 [thread overview]
Message-ID: <6287083.lOV4Wx5bFT@weasel> (raw)
In-Reply-To: <af19f823-234c-462d-8c52-4d8cf4b93c4c@oss.qualcomm.com>
On Tuesday, 21 July 2026 10:25:34 CEST Philippe Mathieu-Daudé wrote:
> On 21/7/26 10:06, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Jul 21, 2026 at 11:58 AM Marc-André Lureau
> >
> > <marcandre.lureau@redhat.com> wrote:
[...]
> >> most of them are "return-type co_annotation fn(..)"
> >> we even have scripts/block-coroutine-wrapper.py that relies and
> >> produce this order..
> >> a bit late to change the style imho...
> >>
> >> At least, let's not make this a requirement for this series, please
>
> Not a requirement on my side, but if we had to pick a style,
> I'd vote for "attribute before return type".
Yep, because that's a) the most compiler-friendly option (all compilers allow
it, including MSC) and b) it's the most diff-noise friendly solution (can be
prepended on its own line without touching any of the existing line(s) at
all).
/Christian
next prev parent reply other threads:[~2026-07-21 8:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 7:55 [PATCH 0/8] coroutine: add missing annotations Marc-André Lureau
2026-07-20 7:55 ` [PATCH 1/8] monitor: annotate monitor_qmp_dispatcher_pop_any() as coroutine Marc-André Lureau
2026-07-20 12:34 ` Markus Armbruster
2026-07-20 14:26 ` Philippe Mathieu-Daudé
2026-07-20 7:55 ` [PATCH 2/8] migration: fix qemu_get_counted_string annotation Marc-André Lureau
2026-07-20 14:09 ` Peter Xu
2026-07-20 14:27 ` Philippe Mathieu-Daudé
2026-07-20 7:55 ` [PATCH 3/8] io: add missing coroutine annotation Marc-André Lureau
2026-07-20 14:28 ` Philippe Mathieu-Daudé
2026-07-20 7:55 ` [PATCH 4/8] block: " Marc-André Lureau
2026-07-20 14:28 ` Philippe Mathieu-Daudé
2026-07-24 13:21 ` Kevin Wolf
2026-07-20 7:55 ` [PATCH 5/8] qcow2: remove invalid qcow2_check_refcounts calls Marc-André Lureau
2026-07-20 20:57 ` Philippe Mathieu-Daudé
2026-07-20 7:55 ` [PATCH 6/8] block: add missing coroutine_fn annotations Marc-André Lureau
2026-07-20 20:58 ` Philippe Mathieu-Daudé
2026-07-22 17:19 ` Denis V. Lunev
2026-07-24 13:19 ` Kevin Wolf
2026-07-24 21:20 ` Marc-André Lureau
2026-07-20 7:55 ` [PATCH 7/8] hw/9pfs: annotate V9fsTransport callbacks as coroutine_fn Marc-André Lureau
2026-07-20 14:02 ` Christian Schoenebeck
2026-07-20 20:42 ` Philippe Mathieu-Daudé
2026-07-20 20:54 ` Philippe Mathieu-Daudé
2026-07-21 7:58 ` Marc-André Lureau
2026-07-21 8:06 ` Marc-André Lureau
2026-07-21 8:25 ` Philippe Mathieu-Daudé
2026-07-21 8:37 ` Christian Schoenebeck [this message]
2026-07-21 8:39 ` Marc-André Lureau
2026-07-21 8:50 ` Christian Schoenebeck
2026-07-20 7:55 ` [PATCH 8/8] migration/rdma: annotate and simplify wait_comp_channel() Marc-André Lureau
2026-07-20 14:13 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6287083.lOV4Wx5bFT@weasel \
--to=qemu_oss@crudebyte.com \
--cc=anthony@xenproject.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=edgar.iglesias@gmail.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=groug@kaod.org \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.