RE: [PATCH v4 bpf-next 04/10] ice: do not setup vlan for loopback VSI

[John Fastabend <john.fastabend@gmail.com>]

Maciej Fijalkowski wrote:
> Currently loopback test is failiing due to the error returned from
> ice_vsi_vlan_setup(). Skip calling it when preparing loopback VSI.
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

These look like fixes unrelated to BPF and probably should go as
driver fixes into net tree?

> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 5bdd515142ec..882f8e280317 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -6026,10 +6026,12 @@ int ice_vsi_cfg(struct ice_vsi *vsi)
>  	if (vsi->netdev) {
>  		ice_set_rx_mode(vsi->netdev);
>  
> -		err = ice_vsi_vlan_setup(vsi);
> +		if (vsi->type != ICE_VSI_LB) {
> +			err = ice_vsi_vlan_setup(vsi);
>  

Extra newline here makes it less readable in my opinion.

> -		if (err)
> -			return err;
> +			if (err)
> +				return err;
> +		}