From: Dan Williams <dan.j.williams@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>, <linux-cxl@vger.kernel.org>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
Abhi Cs <abhi.cs@intel.com>, <stable@vger.kernel.org>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Alison Schofield <alison.schofield@intel.com>
Subject: RE: [PATCH] cxl/mbox: Fix missing variable payload checks in cmd size validation
Date: Tue, 28 Jun 2022 14:49:08 -0700 [thread overview]
Message-ID: <62bb77547fb2f_1ab19729496@dwillia2-xfh.notmuch> (raw)
In-Reply-To: <20220628200427.601714-1-vishal.l.verma@intel.com>
Vishal Verma wrote:
> The conversion of command sizes to unsigned missed a couple of checks
> against variable size payloads during command validation, which made all
> variable payload commands unconditionally fail. Add the checks back using
> the new CXL_VARIABLE_PAYLOAD scheme.
Ah, looks good. Need to get label read/write regression test into
cxl-cli post-haste.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
prev parent reply other threads:[~2022-06-28 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 20:04 [PATCH] cxl/mbox: Fix missing variable payload checks in cmd size validation Vishal Verma
2022-06-28 21:42 ` Alison Schofield
2022-06-28 21:46 ` Verma, Vishal L
2022-06-28 21:52 ` Dan Williams
2022-06-28 21:49 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62bb77547fb2f_1ab19729496@dwillia2-xfh.notmuch \
--to=dan.j.williams@intel.com \
--cc=abhi.cs@intel.com \
--cc=alison.schofield@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.