From: "Ihor Solodrai" <ihor.solodrai@linux.dev>
To: "David Howells" <dhowells@redhat.com>
Cc: dhowells@redhat.com, "Marc Dionne" <marc.dionne@auristor.com>,
"Steve French" <stfrench@microsoft.com>,
"Eric Van Hensbergen" <ericvh@kernel.org>,
"Latchesar Ionkov" <lucho@ionkov.net>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Christian Schoenebeck" <linux_oss@crudebyte.com>,
"Paulo Alcantara" <pc@manguebit.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Christian Brauner" <brauner@kernel.org>,
v9fs@lists.linux.dev, linux-cifs@vger.kernel.org,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, ast@kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH] netfs: Fix setting NETFS_RREQ_ALL_QUEUED to be after all subreqs queued
Date: Wed, 12 Feb 2025 18:01:40 +0000 [thread overview]
Message-ID: <62dacb9480327bfececb60e956f18f6f1924745b@linux.dev> (raw)
In-Reply-To: <3459755.1739353676@warthog.procyon.org.uk>
On 2/12/25 1:47 AM, David Howells wrote:
> Hi Ihor,
>
> Okay, the bug you're hitting appears to be a different one to the one I
> thought first. Can you try the attached patch? I managed to reproduce it
> with AFS by injecting a delay.
>
> [...]
>
> netfs: Fix setting NETFS_RREQ_ALL_QUEUED to be after all subreqs queued
>
> [...]
Hi David.
I tried this patch locally, and then on BPF CI. It fixes the 9p hanging issue.
A couple of platforms and toolchains are tested there:
https://github.com/kernel-patches/vmtest/actions/runs/13291034531
Tested-by: Ihor Solodrai <ihor.solodrai@linux.dev>
Note that on CI the "netfs: Fix a number of read-retry hangs" patch [1]
is *not* applied. Only this one.
Thank you!
[1] https://lore.kernel.org/v9fs/3173328.1738024385@warthog.procyon.org.uk/
> [...]
next prev parent reply other threads:[~2025-02-12 18:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 0:33 [PATCH] netfs: Fix a number of read-retry hangs David Howells
2025-01-28 9:33 ` [PATCH] netfs: Add retry stat counters David Howells
2025-01-28 19:11 ` Ihor Solodrai
2025-02-03 18:01 ` Ihor Solodrai
2025-02-10 10:57 ` David Howells
2025-02-10 11:12 ` David Howells
2025-02-10 21:54 ` Ihor Solodrai
2025-02-10 23:18 ` David Howells
2025-02-11 0:54 ` Ihor Solodrai
2025-02-12 9:47 ` [PATCH] netfs: Fix setting NETFS_RREQ_ALL_QUEUED to be after all subreqs queued David Howells
2025-02-12 18:01 ` Ihor Solodrai [this message]
2025-01-28 16:51 ` [PATCH] netfs: Fix a number of read-retry hangs Marc Dionne
2025-02-11 1:07 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62dacb9480327bfececb60e956f18f6f1924745b@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=asmadeus@codewreck.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=ericvh@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=marc.dionne@auristor.com \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.com \
--cc=stfrench@microsoft.com \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.