From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 26 Nov 2017 17:43:17 +0000 Subject: [PATCH 3/3] video: omap: Delete an error message for a failed memory allocation in mipid_spi_probe() Message-Id: <62f8d5bb-64cd-487f-6ef4-e3aa7a8b5fd5@users.sourceforge.net> List-Id: References: <1e17c727-884d-5745-2726-48dd3a53c32f@users.sourceforge.net> In-Reply-To: <1e17c727-884d-5745-2726-48dd3a53c32f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Tomi Valkeinen Cc: kernel-janitors@vger.kernel.org, LKML From: Markus Elfring Date: Sun, 26 Nov 2017 18:21:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/omap/lcd_mipid.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/omap/lcd_mipid.c b/drivers/video/fbdev/omap/lcd_mipid.c index e3a85432f926..e71b674b47d8 100644 --- a/drivers/video/fbdev/omap/lcd_mipid.c +++ b/drivers/video/fbdev/omap/lcd_mipid.c @@ -564,10 +564,8 @@ static int mipid_spi_probe(struct spi_device *spi) int r; md = kzalloc(sizeof(*md), GFP_KERNEL); - if (md = NULL) { - dev_err(&spi->dev, "out of memory\n"); + if (!md) return -ENOMEM; - } spi->mode = SPI_MODE_0; md->spi = spi; -- 2.15.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 3/3] video: omap: Delete an error message for a failed memory allocation in mipid_spi_probe() Date: Sun, 26 Nov 2017 18:43:17 +0100 Message-ID: <62f8d5bb-64cd-487f-6ef4-e3aa7a8b5fd5@users.sourceforge.net> References: <1e17c727-884d-5745-2726-48dd3a53c32f@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1e17c727-884d-5745-2726-48dd3a53c32f@users.sourceforge.net> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Tomi Valkeinen Cc: kernel-janitors@vger.kernel.org, LKML List-Id: linux-omap@vger.kernel.org RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgpEYXRl OiBTdW4sIDI2IE5vdiAyMDE3IDE4OjIxOjI1ICswMTAwCgpPbWl0IGFuIGV4dHJhIG1lc3NhZ2Ug Zm9yIGEgbWVtb3J5IGFsbG9jYXRpb24gZmFpbHVyZSBpbiB0aGlzIGZ1bmN0aW9uLgoKVGhpcyBp c3N1ZSB3YXMgZGV0ZWN0ZWQgYnkgdXNpbmcgdGhlIENvY2NpbmVsbGUgc29mdHdhcmUuCgpTaWdu ZWQtb2ZmLWJ5OiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+ Ci0tLQogZHJpdmVycy92aWRlby9mYmRldi9vbWFwL2xjZF9taXBpZC5jIHwgNCArLS0tCiAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv ZHJpdmVycy92aWRlby9mYmRldi9vbWFwL2xjZF9taXBpZC5jIGIvZHJpdmVycy92aWRlby9mYmRl di9vbWFwL2xjZF9taXBpZC5jCmluZGV4IGUzYTg1NDMyZjkyNi4uZTcxYjY3NGI0N2Q4IDEwMDY0 NAotLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAvbGNkX21pcGlkLmMKKysrIGIvZHJpdmVy cy92aWRlby9mYmRldi9vbWFwL2xjZF9taXBpZC5jCkBAIC01NjQsMTAgKzU2NCw4IEBAIHN0YXRp YyBpbnQgbWlwaWRfc3BpX3Byb2JlKHN0cnVjdCBzcGlfZGV2aWNlICpzcGkpCiAJaW50IHI7CiAK IAltZCA9IGt6YWxsb2Moc2l6ZW9mKCptZCksIEdGUF9LRVJORUwpOwotCWlmIChtZCA9PSBOVUxM KSB7Ci0JCWRldl9lcnIoJnNwaS0+ZGV2LCAib3V0IG9mIG1lbW9yeVxuIik7CisJaWYgKCFtZCkK IAkJcmV0dXJuIC1FTk9NRU07Ci0JfQogCiAJc3BpLT5tb2RlID0gU1BJX01PREVfMDsKIAltZC0+ c3BpID0gc3BpOwotLSAKMi4xNS4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751500AbdKZRnw (ORCPT ); Sun, 26 Nov 2017 12:43:52 -0500 Received: from mout.web.de ([212.227.15.3]:56149 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdKZRnu (ORCPT ); Sun, 26 Nov 2017 12:43:50 -0500 Subject: [PATCH 3/3] video: omap: Delete an error message for a failed memory allocation in mipid_spi_probe() From: SF Markus Elfring To: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Tomi Valkeinen Cc: LKML , kernel-janitors@vger.kernel.org References: <1e17c727-884d-5745-2726-48dd3a53c32f@users.sourceforge.net> Message-ID: <62f8d5bb-64cd-487f-6ef4-e3aa7a8b5fd5@users.sourceforge.net> Date: Sun, 26 Nov 2017 18:43:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1e17c727-884d-5745-2726-48dd3a53c32f@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:e4vrOfYuZJdHufUonaE8fYAr1/lC7Zwjzsan+6h3GCh0dA+qZqL pEaEwumjTv0a0k3k3+BC9G2Jbuo3LugTFErSy13FS1K3ZwIrN0L0CufQAXQplGnk3w/A1tg uxZ0cOPL2bwdHZcbu67ujf4N0hTdsNDc6rMCTuxUxxmWT1Dnip1wE20S9tENcMLLQMYgdyj 0YClES7KhpWaIQbc59udw== X-UI-Out-Filterresults: notjunk:1;V01:K0:+9rYzxGoaUs=:aE/MWxDe7bPv8oROtUNd/b 8ucTM+GN6IYQiS5Vw328qip7LKke1uOC31RRNGNNeTFiTJZiOQNSLYyvt44YiXyZeOTa8W7n3 IVeMIjKWeyMNeHjf8/mW7Izf/sFzsH4sdvMcg1PXCIPzHcsmBvZdIvjVUK+ty7RnMMF30Yc76 SRDKhrcO5ZcYZ6JVcdn2kIqCsAlaNPreWVF8HIMmv5vc/rri5iiOE9hMkFrKZMBf1qVGb7ZTy fS1YEkcj2chCOXvyzeWE2I8fSDdsHIzGXVVxc6e5iqx1or7j4c5mcYUne/hBbX+az0T1IzXJe +DBtlZyoG5fGGI2lyGniCWfXzuOxk66E4a8LLZf4U8XFC2gcizxc8KWe80PccavErJzOZyU7p CjbwmlzQqNwlvnr0V+1E+gdVV42AnDDovErjrKVABYU3KZt6z8wR9qJOSnX3xIvYCHhm2I3EK 34l5XyyUJBEfMIntEgieDZjgVdX00SRGikvLtyJnMTtn6vqr8Ia52hGYV7LWnm9bHxri/HDt2 belEx1CvU2byk6IL5glL1ZUtUN7F3zCneMFOzAXga0KDb97svfjpHNX5z/2JYsGsB2G9DN57a GrL9UbTjhqb1R2k0Xssz6sIWNryKVbuSO8IiAfNucKzLzsLFhFcp/3aFOyu5q41JO+lsdHOlx 5tVlPXLa7cPzJsfwnXQkZdsoPW+g7xUr63kM6Y3vY3AX0ZoZj6QtKt6uCmUmkZftyWQlSWhex QZq+lV2lRF7w06f9BrnwWLeM45hhGoUJmCS+OMBDhN9p/tNkvDfsnBgSwZfHMIxw8sQ4MB9qb FtG93NP8TkxXmqKb9DfY9S0sCdnWiSCTIseU5bocMoRG9d6CbM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 26 Nov 2017 18:21:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/omap/lcd_mipid.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/omap/lcd_mipid.c b/drivers/video/fbdev/omap/lcd_mipid.c index e3a85432f926..e71b674b47d8 100644 --- a/drivers/video/fbdev/omap/lcd_mipid.c +++ b/drivers/video/fbdev/omap/lcd_mipid.c @@ -564,10 +564,8 @@ static int mipid_spi_probe(struct spi_device *spi) int r; md = kzalloc(sizeof(*md), GFP_KERNEL); - if (md == NULL) { - dev_err(&spi->dev, "out of memory\n"); + if (!md) return -ENOMEM; - } spi->mode = SPI_MODE_0; md->spi = spi; -- 2.15.0