From: Arnd Bergmann <arnd@arndb.de>
To: Darren Hart <dvhart@infradead.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: shut up unused-function warning
Date: Tue, 10 Jan 2017 22:39:04 +0100 [thread overview]
Message-ID: <6301921.5KldR71luq@wuerfel> (raw)
In-Reply-To: <20170110204117.GB4371@f23x64.localdomain>
On Tuesday, January 10, 2017 12:41:17 PM CET Darren Hart wrote:
>
> Thanks Arnd,
>
> This appears to be the preferred approach from coding-style.rst 20) Conditional
> Compilation - we have some cleanup to do in this area I guess.
>
> Queued to next, thanks.
Thanks!
No need to do mass-conversions to __maybe_unused though,
Kirtika Ruchandani has started working on a way for the suspend/resume
functions to automatically get silently discarded when they are
unused, without having an #ifdef or __maybe_unused annotation.
For new code, using __maybe_unused helps avoid this bug though,
and the conversion to the future macros would be easy enough.
Arnd
prev parent reply other threads:[~2017-01-10 21:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 15:28 [PATCH] platform/x86: shut up unused-function warning Arnd Bergmann
2017-01-10 15:33 ` Benjamin Tissoires
2017-01-10 20:41 ` Darren Hart
2017-01-10 21:39 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6301921.5KldR71luq@wuerfel \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.