From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8] mem: command line option to delete hugepage backing files Date: Wed, 04 Nov 2015 02:03:26 +0100 Message-ID: <6306594.cul4fQvtrc@xps13> References: <1446069865-18733-1-git-send-email-shesha@cisco.com> <5631590F.9040606@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Shesha Sreenivasamurthy Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 880908E93 for ; Wed, 4 Nov 2015 02:04:42 +0100 (CET) Received: by wmff134 with SMTP id f134so98249429wmf.1 for ; Tue, 03 Nov 2015 17:04:42 -0800 (PST) In-Reply-To: <5631590F.9040606@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-28 23:23, Sergio Gonzalez Monroy: > On 28/10/2015 22:04, Shesha Sreenivasamurthy wrote: > > When an application using huge-pages crash or exists, the hugetlbfs > > backing files are not cleaned up. This is a patch to clean those files. > > There are multi-process DPDK applications that may be benefited by those > > backing files. Therefore, I have made that configurable so that the > > application that does not need those backing files can remove them, thus > > not changing the current default behavior. The application itself can > > clean it up, however the rationale behind DPDK cleaning it up is, DPDK > > created it and therefore, it is better it unlinks it. > > > > Signed-off-by: Shesha Sreenivasamurthy > > Acked-by: Sergio Gonzalez Monroy > Patch looks good! > > Just a couple of things for the next time ;) > You might be aware of them, but it doesn't hurt to remind them: > - When sending new version, use --in-reply-to to the last version of the > patch sent, it's easier to have all patches on the same thread (if your > email client supports it) > - Also when sending new versions it's useful to add what has changed > from the previous to the new version. > (add such info after the three dashes as shown above) +1 Other things: Some lists like EAL options are alphabetically sorted. When adding a new line, please try to keep the order. Applied with orders fixed, thanks.