All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] ARM: shmobile: Remove unneeded check in SMP initialization
Date: Wed, 05 Oct 2016 16:04:39 +0300	[thread overview]
Message-ID: <6311567.Xmt6xgUBQy@avalon> (raw)
In-Reply-To: <CAMuHMdUwussH1Tvzrz3=cOmt0b-+fS5ybd7gvy2FdYRiVADO1g@mail.gmail.com>

Hi Geert,

On Wednesday 05 Oct 2016 13:25:12 Geert Uytterhoeven wrote:
> On Wed, Oct 5, 2016 at 12:28 PM, Laurent Pinchart wrote:
> > The SMP initialization function is only called if CONFIG_SMP is defined.
> > Remove the duplicate check.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/mach-shmobile/platsmp.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/arch/arm/mach-shmobile/platsmp.c
> > b/arch/arm/mach-shmobile/platsmp.c index 02e21bceb085..48595a397220
> > 100644
> > --- a/arch/arm/mach-shmobile/platsmp.c
> > +++ b/arch/arm/mach-shmobile/platsmp.c
> > @@ -39,9 +39,5 @@ bool shmobile_smp_cpu_can_disable(unsigned int cpu)
> > 
> >  bool __init shmobile_smp_init_fallback_ops(void)
> >  {
> > -       /* fallback on PSCI/smp_ops if no other DT based method is
> > detected */
> > -       if (!IS_ENABLED(CONFIG_SMP))
> > -               return false;
> > -
> >         return platform_can_secondary_boot() ? true : false;
> >  }
> 
> This check was added recently, because the UP build was broken.

I should have found that out. Sorry about the noise and thanks for the review.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2016-10-05 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05 10:28 [PATCH] ARM: shmobile: Remove unneeded check in SMP initialization Laurent Pinchart
2016-10-05 11:25 ` Geert Uytterhoeven
2016-10-05 13:04   ` Laurent Pinchart [this message]
2016-10-07  3:27     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6311567.Xmt6xgUBQy@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=geert@linux-m68k.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.