From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
Subject: Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer
Date: Wed, 30 May 2012 11:24:50 +0200 [thread overview]
Message-ID: <6315567.0lP5TunKB7@avalon> (raw)
In-Reply-To: <20120530091856.GA6888@phenom.ffwll.local>
Hi Daniel,
On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote:
> On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote:
> > The passed mode must not be modified by the operation, make it const.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thank you for the ack. Would you also be so kind as to tell me how to fix the
related i915 issue (as briefly stated in the patch, the i915 driver modifies
mode->clock in intel_dp_mode_fixup()) ? Or, even better, provide a patch for
that ? :-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-05-30 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 23:01 [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer Laurent Pinchart
2012-05-30 9:18 ` Daniel Vetter
2012-05-30 9:24 ` Laurent Pinchart [this message]
2012-05-30 10:02 ` Daniel Vetter
2012-05-30 10:11 ` Laurent Pinchart
2012-05-30 10:25 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6315567.0lP5TunKB7@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.