From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25B6BC43334 for ; Thu, 9 Jun 2022 15:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y71Nwbj/OTJN8c+y7hAoJygS/ZVZUaua9ZolvcIYWo0=; b=XU+R9uK00ovVF4 EqsxZ9chiEE6RkI0CO8xIbbwyacqMvJqUFYQS0CLovOS1Gkwx57P+BtI1WY9G4a3kwZlAjR0k0m43 fR6RxcVANeQOdaf07JDC2hiCHulWfuZjLLGbTXPuADqlB9nf1Q9O1YkkJcbY2YDne/VrYSV883TcZ nzv6NQ4tHUn96QnCOIPfUnC7xvMEn2SfsxVFCaSwZCNctrbUDKhBthXUd2DdzCDKszeJ/H3MR5qC2 u+J49FsLWFoecYAPPbLAMx5Vq/Wy7ubTtMzLFhE4IcE7DsiaogX4+bErNGEWXBuD0QAclGa2wgIwj zLmRtzfirTI43zGCqxCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzKVQ-002nVP-UF; Thu, 09 Jun 2022 15:55:32 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzKVG-002nTz-8F; Thu, 09 Jun 2022 15:55:23 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzKVB-0007Jz-Ts; Thu, 09 Jun 2022 17:55:17 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Maya Matuszczyk , Krzysztof Kozlowski Cc: Arnd Bergmann , Olof Johansson , arm@kernel.org, soc@kernel.org, Rob Herring , Krzysztof Kozlowski , devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 32/48] arm64: dts: rockchip: align gpio-key node names with dtschema Date: Thu, 09 Jun 2022 17:55:17 +0200 Message-ID: <6317926.K2JlShyGXD@diego> In-Reply-To: References: <20220609113721.379932-1-krzysztof.kozlowski@linaro.org> <2126178.C4sosBPzcN@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_085522_336330_4525BDC4 X-CRM114-Status: GOOD ( 29.42 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gRG9ubmVyc3RhZywgOS4gSnVuaSAyMDIyLCAxNzowNTo0OSBDRVNUIHNjaHJpZWIgS3J6eXN6 dG9mIEtvemxvd3NraToKPiBPbiAwOS8wNi8yMDIyIDE2OjU2LCBIZWlrbyBTdMO8Ym5lciB3cm90 ZToKPiA+IEFtIERvbm5lcnN0YWcsIDkuIEp1bmkgMjAyMiwgMTY6MTU6MjUgQ0VTVCBzY2hyaWVi IEtyenlzenRvZiBLb3psb3dza2k6Cj4gPj4gT24gMDkvMDYvMjAyMiAxNTo1NywgTWF5YSBNYXR1 c3pjenlrIHdyb3RlOgo+ID4+PiBjencuLCA5IGN6ZSAyMDIyIG8gMTM6NTYgS3J6eXN6dG9mIEtv emxvd3NraQo+ID4+PiA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPiBuYXBpc2HFgihh KToKPiA+Pj4+Cj4gPj4+PiBUaGUgbm9kZSBuYW1lcyBzaG91bGQgYmUgZ2VuZXJpYyBhbmQgRFQg c2NoZW1hIGV4cGVjdHMgY2VydGFpbiBwYXR0ZXJuCj4gPj4+PiAoZS5nLiB3aXRoIGtleS9idXR0 b24vc3dpdGNoKS4KPiA+Pj4+Cj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgS296bG93 c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+Cj4gPj4+PiAtLS0KPiA+Pj4+ICBh cmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMwOC1ldmIuZHRzICAgfCAgMiArLQo+ID4+ Pj4gIC4uLi9ib290L2R0cy9yb2NrY2hpcC9yazMzMjYtb2Ryb2lkLWdvMi5kdHMgICB8IDMyICsr KysrKysrKy0tLS0tLS0tLS0KPiA+Pj4+ICAuLi4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzI4LW5h bm9waS1yMnMuZHRzICAgfCAgMiArLQo+ID4+Pj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2No aXAvcmszMzY4LWV2Yi5kdHNpICB8ICAyICstCj4gPj4+PiAgLi4uL2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzM2OC1nZWVrYm94LmR0cyAgICAgIHwgIDIgKy0KPiA+Pj4+ICAuLi4vZHRzL3JvY2tjaGlw L3JrMzM2OC1vcmlvbi1yNjgtbWV0YS5kdHMgICAgfCAgMiArLQo+ID4+Pj4gIC4uLi9ib290L2R0 cy9yb2NrY2hpcC9yazMzNjgtcHg1LWV2Yi5kdHMgICAgICB8ICAyICstCj4gPj4+PiAgYXJjaC9h cm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzNjgtcjg4LmR0cyAgIHwgIDIgKy0KPiA+Pj4+ICAu Li4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LWZpcmVmbHkuZHRzICAgICAgfCAgMiArLQo+ID4+ Pj4gIC4uLi9kdHMvcm9ja2NoaXAvcmszMzk5LWdydS1jaHJvbWVib29rLmR0c2kgICB8ICAyICst Cj4gPj4+PiAgLi4uL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1ncnUta2V2aW4uZHRzICAgIHwg IDIgKy0KPiA+Pj4+ICAuLi4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LWdydS1zY2FybGV0LmR0 c2kgfCAgMiArLQo+ID4+Pj4gIC4uLi9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkta2hhZGFzLWVk Z2UuZHRzaSB8ICAyICstCj4gPj4+PiAgLi4uL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1uYW5v cGktcjRzLmR0cyAgIHwgIDQgKy0tCj4gPj4+PiAgLi4uL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5 OS1uYW5vcGk0LmR0c2kgICAgIHwgIDIgKy0KPiA+Pj4+ICAuLi4vYm9vdC9kdHMvcm9ja2NoaXAv cmszMzk5LW9yYW5nZXBpLmR0cyAgICAgfCAgMiArLQo+ID4+Pj4gIC4uLi9ib290L2R0cy9yb2Nr Y2hpcC9yazMzOTktcGluZWJvb2stcHJvLmR0cyB8ICA0ICstLQo+ID4+Pj4gIC4uLi9ib290L2R0 cy9yb2NrY2hpcC9yazMzOTktcm9jLXBjLmR0c2kgICAgICB8ICAyICstCj4gPj4+PiAgLi4uL2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1yb2NrcHJvNjQuZHRzaSAgIHwgIDIgKy0KPiA+Pj4+ICAu Li4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LXNhcHBoaXJlLmR0c2kgICAgfCAgMiArLQo+ID4+ Pj4gIC4uLi9ib290L2R0cy9yb2NrY2hpcC9yazM1NjYtcGluZW5vdGUuZHRzaSAgICB8ICAyICst Cj4gPj4+PiAgMjEgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25z KC0pCj4gPj4+Pgo+ID4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2No aXAvcmszMzA4LWV2Yi5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMwOC1l dmIuZHRzCj4gPj4+PiBpbmRleCA5YjRmODU1ZWE1ZDQuLjRiNTQxM2IxMmJmYSAxMDA2NDQKPiA+ Pj4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzA4LWV2Yi5kdHMKPiA+ Pj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzA4LWV2Yi5kdHMKPiA+ Pj4+IEBAIC03NSw3ICs3NSw3IEBAIGdwaW8ta2V5cyB7Cj4gPj4+PiAgICAgICAgICAgICAgICAg cGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiA+Pj4+ICAgICAgICAgICAgICAgICBwaW5jdHJs LTAgPSA8JnB3cl9rZXk+Owo+ID4+Pj4KPiA+Pj4+IC0gICAgICAgICAgICAgICBwb3dlciB7Cj4g Pj4+PiArICAgICAgICAgICAgICAgcG93ZXIta2V5IHsKPiA+IAo+ID4gaG1tLCBpdCBsb29rcyBs aWtlIGFsbCB0aGUgb3RoZXJzIGJlbG93IGFyZSBuYW1lZCBrZXktcG93ZXIsIHdoaWxlCj4gPiBv bmx5IHRoaXMgdXNlcyBwb3dlci1rZXkgPwo+ID4gCj4gCj4gQmVjYXVzZSBhIGJpdCBlYXJsaWVy IGluIERUUywgdGhlcmUgYXJlIHR3byBhZGMta2V5cyBub2RlcyB3aXRoICJrZXkiCj4gc3VmZml4 LCBzbyBJIGtlcHQgdGhhdCBhcHByb2FjaCB0byBiZSBjb25zaXN0ZW50IHdpdGhpbiBvbmUgRFRT LiBJZiB5b3UKPiBwcmVmZXIsIEkgY2FuIGNoYW5nZSBpdCB0byBrZXktcG93ZXIuCgpJIGp1c3Qg c2F3IHRoYXQgZGlzY3JlcGFuY3kgYW5kIHdhcyBub3Qgc3VyZSBpZiB0aGF0IHdhcyBpbnRlbnRp b25hbC4KQWx0aG91Z2ggd2l0aCB0aGUgYmVsb3csIEkgZ3Vlc3MgaXQgbWFrZXMgc2Vuc2UgdG8g Z28gd2l0aAokdHlwZS0kbmFtZSwgYWthIGtleS1wb3dlciwgc2FtZSBhcyBidXR0b24tc3cxIGV0 Yy4KCgo+ID4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgZ3Bpb3MgPSA8JmdwaW8wIFJLX1BB NiBHUElPX0FDVElWRV9MT1c+Owo+ID4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgbGludXgs Y29kZSA9IDxLRVlfUE9XRVI+Owo+ID4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgbGFiZWwg PSAiR1BJTyBLZXkgUG93ZXIiOwo+ID4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9k dHMvcm9ja2NoaXAvcmszMzI2LW9kcm9pZC1nbzIuZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9y b2NrY2hpcC9yazMzMjYtb2Ryb2lkLWdvMi5kdHMKPiA+Pj4+IGluZGV4IGVhMDY5NWI1MWVjZC4u NzIzMjhkZDk5M2VlIDEwMDY0NAo+ID4+Pj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazMzMjYtb2Ryb2lkLWdvMi5kdHMKPiA+Pj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9k dHMvcm9ja2NoaXAvcmszMzI2LW9kcm9pZC1nbzIuZHRzCj4gPj4+PiBAQCAtNzEsODIgKzcxLDgy IEBAIGdwaW8ta2V5cyB7Cj4gPj4+PiAgICAgICAgICAgICAgICAgICogfC0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLXwKPiA+Pj4+ICAgICAgICAgICAgICAg ICAgKi8KPiA+Pj4+Cj4gPj4+PiAtICAgICAgICAgICAgICAgc3cxIHsKPiA+Pj4+ICsgICAgICAg ICAgICAgICBzd2l0Y2gtMSB7Cj4gPj4+IFdvdWxkbid0IGl0IG1ha2UgbW9yZSBzZW5zZSB0byBy ZW5hbWUgdGhpcyBhbmQgYWxsIG90aGVyCj4gPj4+IHJlbmFtZWQgbm9kZXMgaW4gdGhpcyBkdHMg aW50byAiYnV0dG9uLWRwYWQtdXAiIG9yICJidXR0b24tMSIsCj4gPj4+IGFzIG9uIHRoZSBwaHlz aWNhbCBkZXZpY2UgdGhvc2UgYXJlIGJ1dHRvbnMgYW5kIHRoZSBuYW1pbmcKPiA+Pj4gc2NoZW1l IG9mICJzdyIgKyBudW1iZXIgc2VlbXMgdG8gYmUgYSBjYXJyeW92ZXIgZnJvbQo+ID4+PiBkb3du c3RyZWFtIHNvdXJjZXMuCj4gPiAKPiA+IFRoZSBuYW1pbmcgYWN0dWFsbHkgY2FycmllcyBvdmVy IGZyb20gdGhlIGRldmljZSBpdHNlbGYuCj4gPiBJbiB0aGUgc2NoZW1hdGljcyB0aGUgcmVsZXZh bnQga2V5cyBhcmUgYWxzbyBuYW1lZCBzdzEsIHN3MiwgZXRjLgo+ID4gCj4gPiBBbmQgSSBkbyBi ZWxpZXZlIGl0IGlzIHdheSBuaWNlciB3aGVuIGRldmljZXRyZWUgbmFtZXMgY29ycmVzcG9uZCB0 byB0aGUKPiA+IHRoaW5ncyB5b3UgZmluZCBpbiBkZXZpY2Ugc2NoZW1hdGljcyBhbmQgbm90IGJl IG5hbWVkICJhcmJpdGFyaWx5IiB0bwo+ID4gb25seSBjb25mb3JtIHRvIHNvbWUgc2NoZW1hIDst KQo+IAo+IFRoZW4geW91IGFyZSBlbnRpcmVseSBkZXBlbmRpbmcgb24gaGFyZHdhcmUgZW5naW5l ZXJzIHdoaWNoIG1pZ2h0IHN0YXJ0Cj4gY2FsbGluZyB0aGVpciBidXR0b25zICJjdXRlLXBvbnkt eHh4IiA6KQoKV2hhdCdzIHdyb25nIHdpdGggY3V0ZS1wb25pZXM/ClRob3VnaCBpdCBzaG91bGQg YmUgYnV0dG9uLWN1dGUtcG9ueS14eHggdGhlbiA7LSkKCgo+ID4gU28gcGVyc29uYWxseSBJJ2Qg YWN0dWFsbHkgcHJlZmVyIGdvaW5nIHdpdGggc3dpdGNoLXN3MSAob3IgYnV0dG9uLXN3MSBpZgo+ ID4geW91IHByZWZlcikgYXMgYmVpbmcgYWJsZSB0byBqdXN0IHVzZSB0aGUgc2VhcmNoIGZ1bmN0 aW9uIGluIHNjaGVtYXRpYyBwZGZzCj4gPiBpcyBhIGhlbHBmdWwgdG9vbC4KPiAKPiBCb3RoIGFy ZSBmaW5lIHdpdGggbWUsIGxldCdzIGp1c3QgcGljayBvbmUgLSBzd2l0Y2gtc3cxIG9yIGJ1dHRv bi1zdzEuCj4gU2luY2UgdGhlc2UgYXJlIHBoeXNpY2FsbHkgYnV0dG9ucywgSSBwcm9wb3NlIHRo ZSBsYXR0ZXIuCgpmaW5lIGJ5IG1lLCBidXR0b24tc3cxLCBldGMgaXQgaXMgdGhlbiA6LSkKCkhl aWtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9j a2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65FB2C43334 for ; Thu, 9 Jun 2022 15:55:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 1DE99C341C4; Thu, 9 Jun 2022 15:55:23 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 12297C34114; Thu, 9 Jun 2022 15:55:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 12297C34114 Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzKVB-0007Jz-Ts; Thu, 09 Jun 2022 17:55:17 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Maya Matuszczyk , Krzysztof Kozlowski List-Id: Cc: Arnd Bergmann , Olof Johansson , arm@kernel.org, soc@kernel.org, Rob Herring , Krzysztof Kozlowski , devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 32/48] arm64: dts: rockchip: align gpio-key node names with dtschema Date: Thu, 09 Jun 2022 17:55:17 +0200 Message-ID: <6317926.K2JlShyGXD@diego> In-Reply-To: References: <20220609113721.379932-1-krzysztof.kozlowski@linaro.org> <2126178.C4sosBPzcN@diego> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Am Donnerstag, 9. Juni 2022, 17:05:49 CEST schrieb Krzysztof Kozlowski: > On 09/06/2022 16:56, Heiko St=C3=BCbner wrote: > > Am Donnerstag, 9. Juni 2022, 16:15:25 CEST schrieb Krzysztof Kozlowski: > >> On 09/06/2022 15:57, Maya Matuszczyk wrote: > >>> czw., 9 cze 2022 o 13:56 Krzysztof Kozlowski > >>> napisa=C5=82(a): > >>>> > >>>> The node names should be generic and DT schema expects certain patte= rn > >>>> (e.g. with key/button/switch). > >>>> > >>>> Signed-off-by: Krzysztof Kozlowski > >>>> --- > >>>> arch/arm64/boot/dts/rockchip/rk3308-evb.dts | 2 +- > >>>> .../boot/dts/rockchip/rk3326-odroid-go2.dts | 32 +++++++++-------= =2D-- > >>>> .../boot/dts/rockchip/rk3328-nanopi-r2s.dts | 2 +- > >>>> arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 2 +- > >>>> .../boot/dts/rockchip/rk3368-geekbox.dts | 2 +- > >>>> .../dts/rockchip/rk3368-orion-r68-meta.dts | 2 +- > >>>> .../boot/dts/rockchip/rk3368-px5-evb.dts | 2 +- > >>>> arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 2 +- > >>>> .../boot/dts/rockchip/rk3399-firefly.dts | 2 +- > >>>> .../dts/rockchip/rk3399-gru-chromebook.dtsi | 2 +- > >>>> .../boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +- > >>>> .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 2 +- > >>>> .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 2 +- > >>>> .../boot/dts/rockchip/rk3399-nanopi-r4s.dts | 4 +-- > >>>> .../boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +- > >>>> .../boot/dts/rockchip/rk3399-orangepi.dts | 2 +- > >>>> .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 +-- > >>>> .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +- > >>>> .../boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 +- > >>>> .../boot/dts/rockchip/rk3399-sapphire.dtsi | 2 +- > >>>> .../boot/dts/rockchip/rk3566-pinenote.dtsi | 2 +- > >>>> 21 files changed, 38 insertions(+), 38 deletions(-) > >>>> > >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3308-evb.dts b/arch/arm6= 4/boot/dts/rockchip/rk3308-evb.dts > >>>> index 9b4f855ea5d4..4b5413b12bfa 100644 > >>>> --- a/arch/arm64/boot/dts/rockchip/rk3308-evb.dts > >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3308-evb.dts > >>>> @@ -75,7 +75,7 @@ gpio-keys { > >>>> pinctrl-names =3D "default"; > >>>> pinctrl-0 =3D <&pwr_key>; > >>>> > >>>> - power { > >>>> + power-key { > >=20 > > hmm, it looks like all the others below are named key-power, while > > only this uses power-key ? > >=20 >=20 > Because a bit earlier in DTS, there are two adc-keys nodes with "key" > suffix, so I kept that approach to be consistent within one DTS. If you > prefer, I can change it to key-power. I just saw that discrepancy and was not sure if that was intentional. Although with the below, I guess it makes sense to go with $type-$name, aka key-power, same as button-sw1 etc. > >>>> gpios =3D <&gpio0 RK_PA6 GPIO_ACTIVE_LOW>; > >>>> linux,code =3D ; > >>>> label =3D "GPIO Key Power"; > >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/ar= ch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts > >>>> index ea0695b51ecd..72328dd993ee 100644 > >>>> --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts > >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts > >>>> @@ -71,82 +71,82 @@ gpio-keys { > >>>> * |------------------------------------------------| > >>>> */ > >>>> > >>>> - sw1 { > >>>> + switch-1 { > >>> Wouldn't it make more sense to rename this and all other > >>> renamed nodes in this dts into "button-dpad-up" or "button-1", > >>> as on the physical device those are buttons and the naming > >>> scheme of "sw" + number seems to be a carryover from > >>> downstream sources. > >=20 > > The naming actually carries over from the device itself. > > In the schematics the relevant keys are also named sw1, sw2, etc. > >=20 > > And I do believe it is way nicer when devicetree names correspond to the > > things you find in device schematics and not be named "arbitarily" to > > only conform to some schema ;-) >=20 > Then you are entirely depending on hardware engineers which might start > calling their buttons "cute-pony-xxx" :) What's wrong with cute-ponies? Though it should be button-cute-pony-xxx then ;-) > > So personally I'd actually prefer going with switch-sw1 (or button-sw1 = if > > you prefer) as being able to just use the search function in schematic = pdfs > > is a helpful tool. >=20 > Both are fine with me, let's just pick one - switch-sw1 or button-sw1. > Since these are physically buttons, I propose the latter. fine by me, button-sw1, etc it is then :-) Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80D3ECCA473 for ; Thu, 9 Jun 2022 15:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4b/8nkXdEwM39/A1co82xWF80TH2EhkexPbNWbEtpE0=; b=rFvxbFIoZd2gCK HtCe/spx4XH8nnE24shTST4SmChkex5ZmSXPsYHsF0S5ZPpUF7Wb5vIfvmeUrR9+8WuRCz9KQ9Vcv UkBCRa4vvehH35VzZpvFN3c7uPrQY0gzA/I4ZcBW8yjEXls4vSjUryr+SYIN9LWZIbRI5MLeayFtc m7ek1Y9vovIL63E2jfQOXdBR7LGOrC/W+b2wYXhBDmvc+2vR72sygDfGixmNH/pakoqNCZgHP5wyF UJxfEAwNxTi6CToFKDx/2pqnHVbg7bHqTacw+6OgyPyJhZO2TpACjwS9hZy/hsCAkuSRFFZdjetv5 v8K08f9s6Maa1gEnobFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzKVJ-002nUY-4b; Thu, 09 Jun 2022 15:55:25 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzKVG-002nTz-8F; Thu, 09 Jun 2022 15:55:23 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzKVB-0007Jz-Ts; Thu, 09 Jun 2022 17:55:17 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Maya Matuszczyk , Krzysztof Kozlowski Cc: Arnd Bergmann , Olof Johansson , arm@kernel.org, soc@kernel.org, Rob Herring , Krzysztof Kozlowski , devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 32/48] arm64: dts: rockchip: align gpio-key node names with dtschema Date: Thu, 09 Jun 2022 17:55:17 +0200 Message-ID: <6317926.K2JlShyGXD@diego> In-Reply-To: References: <20220609113721.379932-1-krzysztof.kozlowski@linaro.org> <2126178.C4sosBPzcN@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_085522_336330_4525BDC4 X-CRM114-Status: GOOD ( 29.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gRG9ubmVyc3RhZywgOS4gSnVuaSAyMDIyLCAxNzowNTo0OSBDRVNUIHNjaHJpZWIgS3J6eXN6 dG9mIEtvemxvd3NraToKPiBPbiAwOS8wNi8yMDIyIDE2OjU2LCBIZWlrbyBTdMO8Ym5lciB3cm90 ZToKPiA+IEFtIERvbm5lcnN0YWcsIDkuIEp1bmkgMjAyMiwgMTY6MTU6MjUgQ0VTVCBzY2hyaWVi IEtyenlzenRvZiBLb3psb3dza2k6Cj4gPj4gT24gMDkvMDYvMjAyMiAxNTo1NywgTWF5YSBNYXR1 c3pjenlrIHdyb3RlOgo+ID4+PiBjencuLCA5IGN6ZSAyMDIyIG8gMTM6NTYgS3J6eXN6dG9mIEtv emxvd3NraQo+ID4+PiA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPiBuYXBpc2HFgihh KToKPiA+Pj4+Cj4gPj4+PiBUaGUgbm9kZSBuYW1lcyBzaG91bGQgYmUgZ2VuZXJpYyBhbmQgRFQg c2NoZW1hIGV4cGVjdHMgY2VydGFpbiBwYXR0ZXJuCj4gPj4+PiAoZS5nLiB3aXRoIGtleS9idXR0 b24vc3dpdGNoKS4KPiA+Pj4+Cj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgS296bG93 c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+Cj4gPj4+PiAtLS0KPiA+Pj4+ICBh cmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMwOC1ldmIuZHRzICAgfCAgMiArLQo+ID4+ Pj4gIC4uLi9ib290L2R0cy9yb2NrY2hpcC9yazMzMjYtb2Ryb2lkLWdvMi5kdHMgICB8IDMyICsr KysrKysrKy0tLS0tLS0tLS0KPiA+Pj4+ICAuLi4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzI4LW5h bm9waS1yMnMuZHRzICAgfCAgMiArLQo+ID4+Pj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2No aXAvcmszMzY4LWV2Yi5kdHNpICB8ICAyICstCj4gPj4+PiAgLi4uL2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzM2OC1nZWVrYm94LmR0cyAgICAgIHwgIDIgKy0KPiA+Pj4+ICAuLi4vZHRzL3JvY2tjaGlw L3JrMzM2OC1vcmlvbi1yNjgtbWV0YS5kdHMgICAgfCAgMiArLQo+ID4+Pj4gIC4uLi9ib290L2R0 cy9yb2NrY2hpcC9yazMzNjgtcHg1LWV2Yi5kdHMgICAgICB8ICAyICstCj4gPj4+PiAgYXJjaC9h cm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzNjgtcjg4LmR0cyAgIHwgIDIgKy0KPiA+Pj4+ICAu Li4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LWZpcmVmbHkuZHRzICAgICAgfCAgMiArLQo+ID4+ Pj4gIC4uLi9kdHMvcm9ja2NoaXAvcmszMzk5LWdydS1jaHJvbWVib29rLmR0c2kgICB8ICAyICst Cj4gPj4+PiAgLi4uL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1ncnUta2V2aW4uZHRzICAgIHwg IDIgKy0KPiA+Pj4+ICAuLi4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LWdydS1zY2FybGV0LmR0 c2kgfCAgMiArLQo+ID4+Pj4gIC4uLi9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkta2hhZGFzLWVk Z2UuZHRzaSB8ICAyICstCj4gPj4+PiAgLi4uL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1uYW5v cGktcjRzLmR0cyAgIHwgIDQgKy0tCj4gPj4+PiAgLi4uL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5 OS1uYW5vcGk0LmR0c2kgICAgIHwgIDIgKy0KPiA+Pj4+ICAuLi4vYm9vdC9kdHMvcm9ja2NoaXAv cmszMzk5LW9yYW5nZXBpLmR0cyAgICAgfCAgMiArLQo+ID4+Pj4gIC4uLi9ib290L2R0cy9yb2Nr Y2hpcC9yazMzOTktcGluZWJvb2stcHJvLmR0cyB8ICA0ICstLQo+ID4+Pj4gIC4uLi9ib290L2R0 cy9yb2NrY2hpcC9yazMzOTktcm9jLXBjLmR0c2kgICAgICB8ICAyICstCj4gPj4+PiAgLi4uL2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1yb2NrcHJvNjQuZHRzaSAgIHwgIDIgKy0KPiA+Pj4+ICAu Li4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LXNhcHBoaXJlLmR0c2kgICAgfCAgMiArLQo+ID4+ Pj4gIC4uLi9ib290L2R0cy9yb2NrY2hpcC9yazM1NjYtcGluZW5vdGUuZHRzaSAgICB8ICAyICst Cj4gPj4+PiAgMjEgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25z KC0pCj4gPj4+Pgo+ID4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2No aXAvcmszMzA4LWV2Yi5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMwOC1l dmIuZHRzCj4gPj4+PiBpbmRleCA5YjRmODU1ZWE1ZDQuLjRiNTQxM2IxMmJmYSAxMDA2NDQKPiA+ Pj4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzA4LWV2Yi5kdHMKPiA+ Pj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzA4LWV2Yi5kdHMKPiA+ Pj4+IEBAIC03NSw3ICs3NSw3IEBAIGdwaW8ta2V5cyB7Cj4gPj4+PiAgICAgICAgICAgICAgICAg cGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiA+Pj4+ICAgICAgICAgICAgICAgICBwaW5jdHJs LTAgPSA8JnB3cl9rZXk+Owo+ID4+Pj4KPiA+Pj4+IC0gICAgICAgICAgICAgICBwb3dlciB7Cj4g Pj4+PiArICAgICAgICAgICAgICAgcG93ZXIta2V5IHsKPiA+IAo+ID4gaG1tLCBpdCBsb29rcyBs aWtlIGFsbCB0aGUgb3RoZXJzIGJlbG93IGFyZSBuYW1lZCBrZXktcG93ZXIsIHdoaWxlCj4gPiBv bmx5IHRoaXMgdXNlcyBwb3dlci1rZXkgPwo+ID4gCj4gCj4gQmVjYXVzZSBhIGJpdCBlYXJsaWVy IGluIERUUywgdGhlcmUgYXJlIHR3byBhZGMta2V5cyBub2RlcyB3aXRoICJrZXkiCj4gc3VmZml4 LCBzbyBJIGtlcHQgdGhhdCBhcHByb2FjaCB0byBiZSBjb25zaXN0ZW50IHdpdGhpbiBvbmUgRFRT LiBJZiB5b3UKPiBwcmVmZXIsIEkgY2FuIGNoYW5nZSBpdCB0byBrZXktcG93ZXIuCgpJIGp1c3Qg c2F3IHRoYXQgZGlzY3JlcGFuY3kgYW5kIHdhcyBub3Qgc3VyZSBpZiB0aGF0IHdhcyBpbnRlbnRp b25hbC4KQWx0aG91Z2ggd2l0aCB0aGUgYmVsb3csIEkgZ3Vlc3MgaXQgbWFrZXMgc2Vuc2UgdG8g Z28gd2l0aAokdHlwZS0kbmFtZSwgYWthIGtleS1wb3dlciwgc2FtZSBhcyBidXR0b24tc3cxIGV0 Yy4KCgo+ID4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgZ3Bpb3MgPSA8JmdwaW8wIFJLX1BB NiBHUElPX0FDVElWRV9MT1c+Owo+ID4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgbGludXgs Y29kZSA9IDxLRVlfUE9XRVI+Owo+ID4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgbGFiZWwg PSAiR1BJTyBLZXkgUG93ZXIiOwo+ID4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9k dHMvcm9ja2NoaXAvcmszMzI2LW9kcm9pZC1nbzIuZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9y b2NrY2hpcC9yazMzMjYtb2Ryb2lkLWdvMi5kdHMKPiA+Pj4+IGluZGV4IGVhMDY5NWI1MWVjZC4u NzIzMjhkZDk5M2VlIDEwMDY0NAo+ID4+Pj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazMzMjYtb2Ryb2lkLWdvMi5kdHMKPiA+Pj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9k dHMvcm9ja2NoaXAvcmszMzI2LW9kcm9pZC1nbzIuZHRzCj4gPj4+PiBAQCAtNzEsODIgKzcxLDgy IEBAIGdwaW8ta2V5cyB7Cj4gPj4+PiAgICAgICAgICAgICAgICAgICogfC0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLXwKPiA+Pj4+ICAgICAgICAgICAgICAg ICAgKi8KPiA+Pj4+Cj4gPj4+PiAtICAgICAgICAgICAgICAgc3cxIHsKPiA+Pj4+ICsgICAgICAg ICAgICAgICBzd2l0Y2gtMSB7Cj4gPj4+IFdvdWxkbid0IGl0IG1ha2UgbW9yZSBzZW5zZSB0byBy ZW5hbWUgdGhpcyBhbmQgYWxsIG90aGVyCj4gPj4+IHJlbmFtZWQgbm9kZXMgaW4gdGhpcyBkdHMg aW50byAiYnV0dG9uLWRwYWQtdXAiIG9yICJidXR0b24tMSIsCj4gPj4+IGFzIG9uIHRoZSBwaHlz aWNhbCBkZXZpY2UgdGhvc2UgYXJlIGJ1dHRvbnMgYW5kIHRoZSBuYW1pbmcKPiA+Pj4gc2NoZW1l IG9mICJzdyIgKyBudW1iZXIgc2VlbXMgdG8gYmUgYSBjYXJyeW92ZXIgZnJvbQo+ID4+PiBkb3du c3RyZWFtIHNvdXJjZXMuCj4gPiAKPiA+IFRoZSBuYW1pbmcgYWN0dWFsbHkgY2FycmllcyBvdmVy IGZyb20gdGhlIGRldmljZSBpdHNlbGYuCj4gPiBJbiB0aGUgc2NoZW1hdGljcyB0aGUgcmVsZXZh bnQga2V5cyBhcmUgYWxzbyBuYW1lZCBzdzEsIHN3MiwgZXRjLgo+ID4gCj4gPiBBbmQgSSBkbyBi ZWxpZXZlIGl0IGlzIHdheSBuaWNlciB3aGVuIGRldmljZXRyZWUgbmFtZXMgY29ycmVzcG9uZCB0 byB0aGUKPiA+IHRoaW5ncyB5b3UgZmluZCBpbiBkZXZpY2Ugc2NoZW1hdGljcyBhbmQgbm90IGJl IG5hbWVkICJhcmJpdGFyaWx5IiB0bwo+ID4gb25seSBjb25mb3JtIHRvIHNvbWUgc2NoZW1hIDst KQo+IAo+IFRoZW4geW91IGFyZSBlbnRpcmVseSBkZXBlbmRpbmcgb24gaGFyZHdhcmUgZW5naW5l ZXJzIHdoaWNoIG1pZ2h0IHN0YXJ0Cj4gY2FsbGluZyB0aGVpciBidXR0b25zICJjdXRlLXBvbnkt eHh4IiA6KQoKV2hhdCdzIHdyb25nIHdpdGggY3V0ZS1wb25pZXM/ClRob3VnaCBpdCBzaG91bGQg YmUgYnV0dG9uLWN1dGUtcG9ueS14eHggdGhlbiA7LSkKCgo+ID4gU28gcGVyc29uYWxseSBJJ2Qg YWN0dWFsbHkgcHJlZmVyIGdvaW5nIHdpdGggc3dpdGNoLXN3MSAob3IgYnV0dG9uLXN3MSBpZgo+ ID4geW91IHByZWZlcikgYXMgYmVpbmcgYWJsZSB0byBqdXN0IHVzZSB0aGUgc2VhcmNoIGZ1bmN0 aW9uIGluIHNjaGVtYXRpYyBwZGZzCj4gPiBpcyBhIGhlbHBmdWwgdG9vbC4KPiAKPiBCb3RoIGFy ZSBmaW5lIHdpdGggbWUsIGxldCdzIGp1c3QgcGljayBvbmUgLSBzd2l0Y2gtc3cxIG9yIGJ1dHRv bi1zdzEuCj4gU2luY2UgdGhlc2UgYXJlIHBoeXNpY2FsbHkgYnV0dG9ucywgSSBwcm9wb3NlIHRo ZSBsYXR0ZXIuCgpmaW5lIGJ5IG1lLCBidXR0b24tc3cxLCBldGMgaXQgaXMgdGhlbiA6LSkKCkhl aWtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK