From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F4029606A331 for ; Tue, 27 Oct 2026 10:56:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=NHytisb7; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=Jze5PRda DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=/j7FdZ5bHZs93LdU4beTRPdlSlC6GmAQnAHvjC0+zVk=; b=NHytisb7l9Lj2k3bt0mfWo0JK1 g0lXohVlrvcm+87gr62z6Z4svOwN6etJvoQXFo3NSFUlRqQIs75OpcesIsZh7yRsBb1RNeBV3Z0nx obQ+SrciVE+L1CLZpLvRXLDScFJ5Z+eYkZImr0OQvslLYWHcMlx12PeKN42WBtow4H6Plb8NwzKvr 1yRlI/xKWNn5MZ7c901wBJT2igGtulg5x37zIcbMhCa9I5f7t5G/rXHieXaXqNfsPXe06q11ruecc cgCS22ZLM7P+E63gLo6SnvDzSdjIGt7c0FcM8GFuA1WzIYW+6/e24bpdFgfYPbx3qB0clBFfYvB5/ zFY4L+cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLeql-00000004Mfi-1Uhm; Tue, 27 Oct 2026 10:56:15 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLeqi-00000004Mf7-31Pg; Tue, 27 Oct 2026 10:56:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=iRDyXe44Y1voxIFFug2VYkvVa9+PxgdNI7cbcINaWFg=; b=Jze5PRdaRk9WLOOmvuXfp6Fv5c z/BRwx79xy+Bac7g8xaYFbMgRA4ELz86k5d/AfFqTIsCADA3A2n7jTE1rVlWdtA8LyfiPMNtRztjW G89mdyzGt4ka6hPAT9OfTAgv9SQ5F7GVD+6fzH8mVyZ5mmdTU0WnW7hR6nal9n+n4nN6yiCA72bd0 vB2K+U8dlcvPuTdD6n2V1vTmP0vNMlxw2E30WIlvyFeDb2Ag5vL9n8zR3tsN0RKSSgMfswC5cV25n bHbArBhy9RoRocsNbMs4ITAUdGjm3CCNtkGdNgqPa9wiqau3Sasx4Yhx9+OzdVVAhYb9ncqx4nkX0 OH8DZpKQ==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Shawn Lin , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Elaine Zhang , Richard Cochran , Cunhao Lu <1579567540@qq.com> Cc: "shawn.lin" , linux-clk , devicetree , linux-arm-kernel , linux-rockchip , linux-kernel , netdev Subject: Re: [PATCH v4 2/4] clk: rockchip: Add internal support for 24-bit fractional dividers Date: Tue, 27 Oct 2026 11:56:01 +0100 Message-ID: <6321950.31tnzDBltd@diego> In-Reply-To: References: <20261027-add-board-ok3572-c-clk-v4-0-d4152b4fedaa@qq.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261027_035612_765552_B9CE2AE5 X-CRM114-Status: GOOD ( 13.13 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gRGllbnN0YWcsIDI3LiBPa3RvYmVyIDIwMjYsIDExOjQxOjI1IE1pdHRlbGV1cm9ww6Rpc2No ZSBOb3JtYWx6ZWl0IHNjaHJpZWIgQ3VuaGFvIEx1Ogo+ID4gSSBndWVzcyB5b3UgYXJlIGRlc2Ny aWJpbmcgd2hhdCB5b3UgY2hhbmdlZCBhZ2FpbnN0IHRoZQo+ID4gb3JpZ2luYWwgcGF0Y2ggZnJv bSBFbGFpbmUuIEJ1dCB0aGlzIGlzIG5vdCBob3cgaXQgd29ya3MuCj4gCj4gSSdtIHZlcnkgc29y cnkgZm9yIHRoZSBtaXN0YWtlLiBBZnRlciBjYXJlZnVsbHkgcmV2aWV3aW5nIHRoZSBndWlkZWxp bmVzLAo+IEkgdW5kZXJzdGFuZCB0aGF0IG15IG5vdGVzIGFib3V0IGNoYW5nZXMgdG8gRWxhaW5l J3Mgb3JpZ2luYWwgcGF0Y2ggc2hvdWxkCj4gaGF2ZSBiZWVuIGVuY2xvc2VkIGluIHNxdWFyZSBi cmFja2V0cyBbXS4gSSB3aWxsIGtlZXAgb25seSB0aGUgc2lnbmlmaWNhbnQKPiBjaGFuZ2VzIGlu IHRob3NlIG5vdGVzIGFuZCBwbGFjZSB0aGVtIHdpdGhpbiBzcXVhcmUgYnJhY2tldHMuCj4gCj4g VGhhbmsgeW91IGFnYWluIGZvciBwb2ludGluZyBvdXQgbXkgbWlzdGFrZS4gVGhpcyByZW1pbmRz IG1lIHRoYXQgSSBzdGlsbAo+IGhhdmUgbXVjaCB0byBsZWFybi4KCmFuZCBhcyBJIHdyb3RlIGlu IG15IHJlcGx5IHRvIEtyenlzenRvZiBzbGlnaHRseSwgbGVzcyB2ZXJib3NpdHkgaXMKdXN1YWxs eSBiZXR0ZXIuIEkuZS4gYSBzaG9ydCBkZXNjcmlwdGlvbiB3aGF0IHlvdSBkaWQsIG5vdCBhIGRl dGFpbGVkCmxpc3QgaXMgdXN1YWxseSBuaWNlciwgaS5lLiBzb21ldGhpbmcgbGlrZQoKKysrKysr KysrKysrKwpTaWduZWQtb2ZmLWJ5OiBFbGFpbmUgWmhhbmcgPHpoYW5ncWluZ0Byb2NrLWNoaXBz LmNvbT4KW2FkYXB0ZWQgdG8gbWFpbmxpbmUgcm9ja2NoaXAgY2xvY2sgYW5kIHJlc2V0IGhhbmRs aW5nICh4aW4yNG0gaW5wdXQsCiAgZG9uJ3QgaW50cm9kdWNlIENMS19OUl9DTEtTLCBldGMpIF0K U2lnbmVkLW9mZi1ieTogQ3VuaGFvIEx1IDwxNTc5NTY3NTQwQHFxLmNvbT4KKysrKysrKysrKysr KwoKQW5kIGFzIGZvciBzcGVlZCwgbWF5YmUgZ2l2ZSBpdCBhIGJpdCBtb3JlIHRpbWUgYmV0d2Vl biBpdGVyYXRpb25zLgpBIHZlcnNpb24gcGVyIGRheSBpcyBhIGJpdCBmYXN0LCBhcyBpdCBkb2Vz bid0IGdpdmUgcGVvcGxlIHRpbWUgdG8gYWN0dWFsbHkKcmVzcG9uZC4KCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGlu ZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793098574; b=065WZvUKVpX5vn1MyzsIeBoU2yY7a7/R+iXYZKTzr6RRlahM0Ldk8hASY/x6zqe96pwv HblW6vL4wTa03ix9Hy2X0SSZDHyLGg3RZYaJ7MY2LAbvdQrWJsmSdbSWrsGUv1T64sfZd UCS4wvRJnNnubJcUjPL/O1EP71LsArq//ft+GyIPLD5bIE1g+B04+MzTCvxrDQlQYBPEq cyvpX579HqNx2m6FEAS9Rejz4oMJahtJtZvBcn8p2PVvWHjm/o6bMXburrC1oHceAICOl hRP9DV7MLELCcTc7BMRxTW2NcDH9p6q+QXqUA3ZBaBQe6af13A+ZbyLSeTNu8uazpww== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793098574; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=iRDyXe44Y1voxIFFug2VYkvVa9+PxgdNI7cbcINaWFg=; b=MJ+EhJplTBDW/uptdM46TKSKujO2IuidE7o34B/fYHG4NP4mv2Uhksr+UKZ4yUusF/bN Jm7H7hPecqOnyy+Y4pDVF6CZAtI5xxDI96z2vfp2QRmLYDtFJaUwmkdngLukYGfMWgMYr 4IgUhfgoTxQfAA0ln5uB+HJehwUWUeS0g3KkwcnTFdgJO3ctqZuap/EV8v6e3tvtWQGiv ahuae+Dr8BF8NmH2GaDLpauQ3vSIs5/oCJIRElRN6PvWgP/ACLDMbyI1qa9hfZOFJjdGs KmnLmtsbrZXMxQXPsXse5YXobV8o46xntH2H9O1VIWLL9bIkwWpec1PgnmE1wZwZNkA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=Jze5PRda; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 306C1606A31A; Tue, 27 Oct 2026 10:56:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 306C1606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=Jze5PRda DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=iRDyXe44Y1voxIFFug2VYkvVa9+PxgdNI7cbcINaWFg=; b=Jze5PRdaRk9WLOOmvuXfp6Fv5c z/BRwx79xy+Bac7g8xaYFbMgRA4ELz86k5d/AfFqTIsCADA3A2n7jTE1rVlWdtA8LyfiPMNtRztjW G89mdyzGt4ka6hPAT9OfTAgv9SQ5F7GVD+6fzH8mVyZ5mmdTU0WnW7hR6nal9n+n4nN6yiCA72bd0 vB2K+U8dlcvPuTdD6n2V1vTmP0vNMlxw2E30WIlvyFeDb2Ag5vL9n8zR3tsN0RKSSgMfswC5cV25n bHbArBhy9RoRocsNbMs4ITAUdGjm3CCNtkGdNgqPa9wiqau3Sasx4Yhx9+OzdVVAhYb9ncqx4nkX0 OH8DZpKQ==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Shawn Lin , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Elaine Zhang , Richard Cochran , Cunhao Lu <1579567540@qq.com> Cc: "shawn.lin" , linux-clk , devicetree , linux-arm-kernel , linux-rockchip , linux-kernel , netdev Subject: Re: [PATCH v4 2/4] clk: rockchip: Add internal support for 24-bit fractional dividers Date: Tue, 27 Oct 2026 11:56:01 +0100 Message-ID: <6321950.31tnzDBltd@diego> In-Reply-To: References: <20261027-add-board-ok3572-c-clk-v4-0-d4152b4fedaa@qq.com> X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Dienstag, 27. Oktober 2026, 11:41:25 Mitteleurop=C3=A4ische Normalzeit s= chrieb Cunhao Lu: > > I guess you are describing what you changed against the > > original patch from Elaine. But this is not how it works. >=20 > I'm very sorry for the mistake. After carefully reviewing the guidelines, > I understand that my notes about changes to Elaine's original patch should > have been enclosed in square brackets []. I will keep only the significant > changes in those notes and place them within square brackets. >=20 > Thank you again for pointing out my mistake. This reminds me that I still > have much to learn. and as I wrote in my reply to Krzysztof slightly, less verbosity is usually better. I.e. a short description what you did, not a detailed list is usually nicer, i.e. something like +++++++++++++ Signed-off-by: Elaine Zhang [adapted to mainline rockchip clock and reset handling (xin24m input, don't introduce CLK_NR_CLKS, etc) ] Signed-off-by: Cunhao Lu <1579567540@qq.com> +++++++++++++ And as for speed, maybe give it a bit more time between iterations. A version per day is a bit fast, as it doesn't give people time to actually respond.