From: Dan Williams <dan.j.williams@intel.com>
To: Bo Liu <liubo03@inspur.com>, <dan.j.williams@intel.com>,
<vishal.l.verma@intel.com>, <dave.jiang@intel.com>
Cc: <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
Bo Liu <liubo03@inspur.com>
Subject: RE: [PATCH] dax: Remove usage of the deprecated ida_simple_xxx API
Date: Thu, 29 Sep 2022 17:29:03 -0700 [thread overview]
Message-ID: <6336384fcc803_795a629415@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20220926012635.3205-1-liubo03@inspur.com>
Bo Liu wrote:
> Use ida_alloc_xxx()/ida_free() instead of
> ida_simple_get()/ida_simple_remove().
> The latter is deprecated and more verbose.
The better justification is:
ida_alloc_max() makes it clear that the
second argument is inclusive, and the alloc/free terminology is more
idiomatic and symmetric then get/remove.
Otherwise, I would not apply the patch is the only justfication was
deprecation and verbosity.
I'll fixup the changelog.
prev parent reply other threads:[~2022-09-30 0:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 1:26 [PATCH] dax: Remove usage of the deprecated ida_simple_xxx API Bo Liu
2022-09-26 18:01 ` Ira Weiny
2022-09-30 0:29 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6336384fcc803_795a629415@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.