diff for duplicates of <6341264.ceyzOgjW1K@avalon> diff --git a/a/1.txt b/N1/1.txt index 9851ed0..c762104 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -404,7 +404,7 @@ You can return -ENOMEM; directly here. > + /* deal with driver instance configuration */ > + if (pdata) -Shouldn't you return an error if pdata = NULL ? +Shouldn't you return an error if pdata == NULL ? > + memcpy(&p->config, pdata, sizeof(*pdata)); diff --git a/a/content_digest b/N1/content_digest index e842e82..fff7acf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020130305003219.14792.13300.sendpatchset@w520\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH] gpio: Renesas R-Car GPIO driver\0" - "Date\0Sat, 09 Mar 2013 18:16:47 +0000\0" + "Date\0Sat, 09 Mar 2013 19:16:47 +0100\0" "To\0Magnus Damm <magnus.damm@gmail.com>\0" "Cc\0linux-kernel@vger.kernel.org" grant.likely@secretlab.ca @@ -416,7 +416,7 @@ "> +\t/* deal with driver instance configuration */\n" "> +\tif (pdata)\n" "\n" - "Shouldn't you return an error if pdata = NULL ?\n" + "Shouldn't you return an error if pdata == NULL ?\n" "\n" "> +\t\tmemcpy(&p->config, pdata, sizeof(*pdata));\n" "\n" @@ -608,4 +608,4 @@ "\n" Laurent Pinchart -85dc883fe8245205ea56de066ce17ce15568e46b18574dce66dff52afbb2bb53 +dd3d1d91146b9ee6003fb1f3a1e468ec9badb9c032195720066163de50b5d8cd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.