All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Tycho Andersen <tycho@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Ashish Kalra <ashish.kalra@amd.com>,
	John Allen <john.allen@amd.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Ard Biesheuvel <ardb@kernel.org>,
	Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>,
	Kishon Vijay Abraham I <kvijayab@amd.com>,
	Alexey Kardashevskiy <aik@amd.com>,
	Nikunj A Dadhania <nikunj@amd.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Kim Phillips <kim.phillips@amd.com>,
	Sean Christopherson <seanjc@google.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 1/2] x86/sev: Do not initialize SNP if missing CPUs
Date: Sat, 18 Apr 2026 08:55:26 -0500	[thread overview]
Message-ID: <63535447-37a9-446b-961b-52f284479e8a@amd.com> (raw)
In-Reply-To: <c88d7a24-1806-4ceb-9e0b-1a07ecf955ce@amd.com>

On 4/8/26 08:10, Tom Lendacky wrote:
> On 4/7/26 12:47, Tycho Andersen wrote:
>> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
>>
>> The SEV firmware checks that the SNP enable bit is set on each CPU during
>> SNP initialization, and will fail if it is not. If there are some CPUs
>> offline, they will not run the setup functions, so SNP initialization will
>> always fail.
>>
>> Skip the IPIs in this case and return an error so that the CCP driver can
>> skip the SNP_INIT that will fail. Also print the CPU masks as a breadcrumb
>> so people can figure out what happened.
>>
>> Suggested-by: Borislav Petkov (AMD) <bp@alien8.de>
>> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
>> ---

> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@gmail.com>

Ugh, that's not the right email address:

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

At least I spelled my name right...

> 
>> +	return ret;
>>  }
>>  EXPORT_SYMBOL_FOR_MODULES(snp_prepare, "ccp");
>>  
> 


  reply	other threads:[~2026-04-18 13:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 17:47 [PATCH v2 0/2] Skip SNP initialization if CPUs are offlined Tycho Andersen
2026-04-07 17:47 ` [PATCH v2 1/2] x86/sev: Do not initialize SNP if missing CPUs Tycho Andersen
2026-04-08  5:40   ` Nikunj A. Dadhania
2026-04-08 13:10   ` Tom Lendacky
2026-04-18 13:55     ` Tom Lendacky [this message]
2026-04-07 17:47 ` [PATCH v2 2/2] crypto/ccp: Skip SNP_INIT if preparation fails Tycho Andersen
2026-04-08  6:01   ` Nikunj A. Dadhania
2026-04-08 13:17   ` Tom Lendacky
2026-04-08 14:06     ` Tycho Andersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63535447-37a9-446b-961b-52f284479e8a@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=Neeraj.Upadhyay@amd.com \
    --cc=aik@amd.com \
    --cc=ardb@kernel.org \
    --cc=ashish.kalra@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=hpa@zytor.com \
    --cc=john.allen@amd.com \
    --cc=kim.phillips@amd.com \
    --cc=kvijayab@amd.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikunj@amd.com \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    --cc=tglx@kernel.org \
    --cc=tycho@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.