diff for duplicates of <6355006.FnTDFbP0bb@avalon> diff --git a/a/1.txt b/N1/1.txt index b0f1c06..a065e7b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -72,8 +72,7 @@ On Tuesday 30 June 2015 17:54:09 Ben Hutchings wrote: > + PORT_GP_32(3, PIN_IO_VOLTAGE, unused), > + > + /* Pins not associated with a GPIO port, placed after all the GPIOs */ -> + [RCAR_GP_PIN(5, 31) + 1] = - +> + [RCAR_GP_PIN(5, 31) + 1] I'm sorry but I still don't like this. gcc outputs a warning when overriding an initializer if you enable -Wextra, which leads me to believe this construct is dubious. It should at least be tested with LLVM. @@ -142,7 +141,7 @@ the warning completely. Same for shdi_set_io_voltage(). > + > + data = ioread32(mapped_reg); > + -> + if (voltage_mV == 3300) +> + if (voltage_mV = 3300) > + data |= mask; > + else > + data &= ~mask; diff --git a/a/content_digest b/N1/content_digest index 326d418..a06cce7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01435683249.23818.62.camel@codethink.co.uk\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH v4 2/8] pinctrl: sh-pfc: r8a7790: Implement voltage switching for SDHI\0" - "Date\0Wed, 01 Jul 2015 10:37:20 +0300\0" + "Date\0Wed, 01 Jul 2015 07:37:20 +0000\0" "To\0Ben Hutchings <ben.hutchings@codethink.co.uk>\0" "Cc\0Ian Molton <ian@mnementh.co.uk>" linux-mmc@vger.kernel.org @@ -88,8 +88,7 @@ "> +\tPORT_GP_32(3, PIN_IO_VOLTAGE, unused),\n" "> +\n" "> +\t/* Pins not associated with a GPIO port, placed after all the GPIOs */\n" - "> +\t[RCAR_GP_PIN(5, 31) + 1] =\n" - "\n" + "> +\t[RCAR_GP_PIN(5, 31) + 1] \n" "I'm sorry but I still don't like this. gcc outputs a warning when overriding \n" "an initializer if you enable -Wextra, which leads me to believe this construct \n" "is dubious. It should at least be tested with LLVM.\n" @@ -158,7 +157,7 @@ "> +\n" "> +\tdata = ioread32(mapped_reg);\n" "> +\n" - "> +\tif (voltage_mV == 3300)\n" + "> +\tif (voltage_mV = 3300)\n" "> +\t\tdata |= mask;\n" "> +\telse\n" "> +\t\tdata &= ~mask;\n" @@ -193,4 +192,4 @@ "\n" Laurent Pinchart -0c515641bb3b8d986a2a9f5d64ea61e282f5e8ed81c6e7370d6e86143be4fe56 +4ec6ef6b6ed491f3d03be5aa2eec5f2bbf033534dd053bf072d9b990154eabbb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.