From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24FC6606A31A for ; Tue, 27 Oct 2026 12:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vBsfqz/G; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mRc9dkJP DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=XYm7/sjNUpkuRHgxcIjWrg43zSNu+ekCptGxvF68bvk=; b=vBsfqz/G3AMzij6w3hojkfEtep DipSEACOSve/I5o9FiJdH5myOT7VtS/FrZl3OtcES03ni72tzs21czhN3rj8U8JpzgITDUYrHUmDR 594SVCb1DPZe5dxATq0M3OwWX3bPBPqGmEGAaSQrIsgpkfSkO3YivdY52spP1FFJeeQtRofHJYoQ0 4doRiglByt4G1z4cjcxVVBR/WF1G1s+WHRQHITjZhcMKSu+gJPNTL5kMBM2CD9fXGGH0JRWNjzRbY uLSDE+r21GBMfoBv8Lkns8ahAHZOTL99LWoCqj1D8Xld8eQAElhUhKA4VZ6yYC2Bfu9bv456G/Khs 88jhRl+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLgkF-00000004jPv-3g8f; Tue, 27 Oct 2026 12:57:39 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLgkE-00000004jPp-251u for linux-phy@lists.infradead.org; Tue, 27 Oct 2026 12:57:38 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id ABAD1601FE; Tue, 27 Oct 2026 12:57:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BB821F01825; Tue, 27 Oct 2026 12:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793105857; bh=ladm7VNw3w94qCYNsul6pq86i2SGy96Tryu3X7+mFyY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=mRc9dkJP49MiwKf3rSOK32sJbhXthHhtbOG/JfyMsNlpq7pddc8gs2aJtUy8AY7Mh e6fQH/rpFVkUt8zIxrDEPKetT2/IVD5SDxlMNlpd4B1KjR5E/NPJRgUKtMPNeeyJUp wRqyNNMGOH8MgTooKcF+gd8ErmtonbxJKyUs5/hmKrrBE5bjsaaRYSdHsZwtWl0DVx i3IFSra+WQuJmNFXuA28aJnUOLl4TvRN2SffGsty6xKJq99kBbfX1DA/1BPL2AyAXs DEUqcdLKfPs7C4l3dOWepcqNoiFYD9dOggir6Vsr3/0u3ZWs8O58uYpDxNriGMY/SF dncx6iS/hqWuw== Message-ID: <6358dcdc-cdf4-4986-ba6b-a5cca4a093fa@kernel.org> Date: Tue, 27 Oct 2026 14:57:31 +0200 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] arm64: dts: qcom: sm8450: Add CAMSS device tree node To: Loic Poulain Cc: Bjorn Andersson , Konrad Dybcio , Abel Vesa , Bryan O'Donoghue , Vinod Koul , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, Neil Armstrong , Manivannan Sadhasivam , linux-phy@lists.infradead.org, Conor Dooley , devicetree@vger.kernel.org References: <20261023163057.775917-1-vz@kernel.org> <20261023163057.775917-5-vz@kernel.org> <378094fb-5f7f-42c6-a91f-158e2083a6cb@kernel.org> <0d25a732-ccd5-4a7b-9809-93e67899b4e7@kernel.org> From: Vladimir Zapolskiy In-Reply-To: X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-phy" X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 SGkgTG9pYy4KCk9uIDEwLzI3LzI2IDEyOjMxLCBMb2ljIFBvdWxhaW4gd3JvdGU6Cj4gSGkgVmxh ZCwKPiAKPiAKPiBPbiBUdWUsIE9jdCAyNywgMjAyNiBhdCAxMDo1NOKAr0FNIFZsYWRpbWlyIFph cG9sc2tpeSA8dnpAa2VybmVsLm9yZz4gd3JvdGU6Cj4+Cj4+IE9uIDEwLzI3LzI2IDExOjA3LCBM b2ljIFBvdWxhaW4gd3JvdGU6Cj4+PiBPbiBNb24sIE9jdCAyNiwgMjAyNiBhdCAxMTozOeKAr1BN IFZsYWRpbWlyIFphcG9sc2tpeSA8dnpAa2VybmVsLm9yZz4gd3JvdGU6Cj4+Pj4KPj4+PiBIaSBM b2ljLgo+Pj4+Cj4+Pj4gT24gMTAvMjYvMjYgMTg6MzIsIExvaWMgUG91bGFpbiB3cm90ZToKPj4+ Pj4gT24gRnJpLCBPY3QgMjMsIDIwMjYgYXQgNjozMeKAr1BNIFZsYWRpbWlyIFphcG9sc2tpeSA8 dnpAa2VybmVsLm9yZz4gd3JvdGU6Cj4+Pj4+Pgo+Pj4+Pj4gQWRkIFF1YWxjb21tIFdhaXBpbyBD QU1TUyBkZXZpY2UgdHJlZSBub2RlIHRvIHRoZSBwbGF0Zm9ybSBkdHNpIGZpbGUsCj4+Pj4+PiB0 aGUgQ0FNU1MgaW5wdXQgcG9ydHMgYXJlIGNvbm5lY3RlZCB0byBvdXRwdXQgcG9ydHMgb2YgQ1NJ UEhZIGRldmljZXMuCj4+Pj4+Pgo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogVmxhZGltaXIgWmFwb2xz a2l5IDx2ekBrZXJuZWwub3JnPgo+Pj4+Pj4gLS0tCj4+Pj4+PiAgICAgYXJjaC9hcm02NC9ib290 L2R0cy9xY29tL3NtODQ1MC5kdHNpIHwgMTY3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAxNjcgaW5zZXJ0aW9ucygrKQo+Pj4+Pj4KPj4+Pj4+ IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20vc204NDUwLmR0c2kgYi9hcmNo L2FybTY0L2Jvb3QvZHRzL3Fjb20vc204NDUwLmR0c2kKPj4+Pj4+IGluZGV4IGJhYmYxYTQxOTZh MS4uN2Y1YjA1MDFhMjNlIDEwMDY0NAo+Pj4+Pj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9x Y29tL3NtODQ1MC5kdHNpCj4+Pj4+PiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20vc204 NDUwLmR0c2kKPj4+Pj4+IEBAIC0zMzEwLDYgKzMzMTAsMTY3IEBAIGNjaTFfaTJjMTogaTJjLWJ1 c0AxIHsKPj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07Cj4+Pj4+PiAgICAgICAg ICAgICAgICAgICAgfTsKPj4+Pj4+Cj4+Pj4+PiArICAgICAgICAgICAgICAgY2Ftc3M6IGlzcEBh Y2I2MDAwIHsKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAicWNv bSx3YWlwaW8tY2Ftc3MiOwo+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDAg MHhhY2I2MDAwIDAgMHgxMDAwPiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg IDwwIDB4YWNiNzAwMCAwIDB4MTAwMD4sCj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICA8MCAweGFjYjkwMDAgMCAweDEwMDA+LAo+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgPDAgMHhhY2JiMDAwIDAgMHgxMDAwPiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDwwIDB4YWNjNjAwMCAwIDB4MTAwMD4sCj4+Pj4+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICA8MCAweGFjY2EwMDAgMCAweDEwMDA+LAo+Pj4+Pj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgPDAgMHhhY2Y2MDAwIDAgMHgxMDAwPiwKPj4+Pj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDwwIDB4YWNmNzAwMCAwIDB4MTAwMD4sCj4+Pj4+PiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8MCAweGFjZjgwMDAgMCAweDEwMDA+LAo+Pj4+ Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPDAgMHhhYzYyMDAwIDAgMHgzMDAwPiwK Pj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwwIDB4YWM3MTAwMCAwIDB4MzAw MD4sCj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8MCAweGFjODAwMDAgMCAw eDMwMDA+LAo+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPDAgMHhhY2M3MDAw IDAgMHgyMDAwPiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwwIDB4YWNj YjAwMCAwIDB4MjAwMD47Cj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICByZWctbmFtZXMg PSAiY3NpZF93cmFwcGVyIiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICJjc2lkMCIsCj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi Y3NpZDEiLAo+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImNzaWQy IiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjc2lkX2xpdGUw IiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjc2lkX2xpdGUx IiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ0cGcwIiwKPj4+ Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ0cGcxIiwKPj4+Pj4+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ0cGcyIiwKPj4+Pj4+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ2ZmUwIiwKPj4+Pj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJ2ZmUxIiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICJ2ZmUyIiwKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJ2ZmVfbGl0ZTAiLAo+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgInZmZV9saXRlMSI7Cj4+Pj4+Cj4+Pj4+IElzIHRoZXJlIGEgY2Ftc3MgInRvcCIg cmVnaXN0ZXIgdG8gZGVzY3JpYmUgaGVyZT8gZS5nLiB0byByZXRyaWV2ZSB0aGUKPj4+Pj4gQ0FN U1MgaGFyZHdhcmUgdmVyc2lvbi4KPj4+Pgo+Pj4+IEknbSBub3QgYXdhcmUgb2YgYW55dGhpbmcg bGlrZSB0aGF0LiBXaGF0IGlzICJDQU1TUyBoYXJkd2FyZSB2ZXJzaW9uIj8KPj4+Pgo+Pj4+IENB TVNTIGVtYnJhY2VzIHZhcmlvdXMgYmxvY2tzLCB0aGVyZSBhcmUgQ1NJRCBhbmQgVkZFLCBmdWxs IGFuZCBsaXRlCj4+Pj4gSVBzLCBhbmQgYWxsIHRoZXNlIGNvbXBvbmVudHMgZG8gZXhwb3J0IHRo ZWlyIHZlcnNpb25zIGluZGl2aWR1YWxseS4KPj4+Cj4+PiBJIG1lYW4sIENBTVNTIHVzdWFsbHkg aGFzIGEgdG9wLWxldmVsIHJlZ2lzdGVyIGJsb2NrIChvZnRlbiB0b3Agb3IKPj4+IGNwYXNfdG9w KSB0aGF0IGNvbnRhaW5zIHRoZSBUaXRhbi9TcGVjdHJhIHZlcnNpb24gaW5mb3JtYXRpb24sIGFs b25nCj4+PiB3aXRoIHZhcmlvdXMgZ2xvYmFsIGNvbmZpZ3VyYXRpb24gYW5kIG11eCByZWdpc3Rl cnMuCj4+Cj4+IE9uIFNNODQ1MCB0aGVyZSBpcyAiY3Bhc190b3AiIHJlZ2lzdGVyIDwweGFjMTMw MDAgMHgxMDAwPiAobm90IGluIHRoZQo+PiBzZXJpZXMpLCBJIGJlbGlldmUgeW91IHJlZmVyZW5j ZSB0byBpdC4KPj4KPj4gSXMgQ1BBUyBhIG5hdHVyYWwgcGFydCBvZiBDQU1TUz8gQ2FuIGl0IGJl IG1vZGVsbGVkIGRpZmZlcmVudGx5LCBlLmcuCj4+IGFzIGEgc2VwYXJhdGUgZGV2aWNlL2RyaXZl ciwgbGlrZSBpdCB3YXMgZG9uZSB3aXRoIEpQRUcgb3IgQ1NJUEhZPwo+Pgo+PiBJIHNlZSB0aGF0 IHRoZXJlIGFyZSBvbmx5IFNNNjE1MCBhbmQgU002MzUwIHBsYXRmb3JtcyBtZW50aW9uIHRoaXMK Pj4gcmVnaXN0ZXIsIHRvIGNhcHR1cmUgYW5kIHByb2Nlc3MgZnJhbWVzIG9uIFNNODQ1MCB0aGVy ZSBpcyBubyBuZWVkCj4+IHRvIHByb2dyYW0gQ1BBUy4KPj4KPj4gTm90ZSwgdGhhdCBldmVuIFNN NjE1MCBhbmQgU002MzUwIHBsYXRmb3JtcyBkbyBub3QgdXNlIHRoaXMgcmVnaXN0ZXIsCj4+IGl0 IG1ha2VzIGl0IHJlZHVuZGFudC4KPj4KPj4+IEluIHBhcnRpY3VsYXIsIGV4cG9zaW5nIHRoaXMg YmxvY2sgY291bGQgYmUgdXNlZnVsIGZvciByZXBvcnRpbmcgdGhlCj4+PiBTcGVjdHJhIHZlcnNp b24gdG8gdXNlcnNwYWNlLCBmb3IgZXhhbXBsZSB0aHJvdWdoIGxpYmNhbWVyYS4KPj4KPj4gSXQg Y291bGQgYmUgc28sIGJ1dCBhZGRpbmcgZGVhZCBjb2RlIGlzIGFuIGFudGktcGF0dGVybiBpbiBz b2Z0d2FyZSBkZXNpZ24uCj4+Cj4+PiBNb3Jlb3ZlciwgaWYgdGhlIGdvYWwgaXMgdG8gZGVzY3Jp YmUgdGhlIENBTVNTIGhhcmR3YXJlIGV4aGF1c3RpdmVseQo+Pj4gaW4gRFQsIHRoaXMgYmxvY2sg c2hvdWxkIHByb2JhYmx5IGJlIHJlcHJlc2VudGVkIGFzIHdlbGwuIFdoZXRoZXIgaXQKPj4KPj4g SGVyZSBJIG9wcG9zZSBzdWNoIGEgZ29hbCBhcyBpbXByYWN0aWNhbCwgdGhlIHNldCBnb2FsIGlz IHRvIGdldCB3b3JraW5nCj4+IGNhbWVyYSBvbiB0aGUgcGxhdGZvcm0gd2l0aCB0aGUgbWluaW11 bSBvZiBpcnJldmVyc2libGUgY2hhbmdlcy4gSXQgd2FzCj4+IHByb3ZlbiBtdWx0aXBsZSB0aW1l cyBpbiB0aGUgcGFzdCwgdGhhdCAiYW4gZXhoYXVzdGl2ZSBkZXNjcmlwdGlvbiIKPj4gZXF1YWxz IHRvICJ0aGUgdG90YWxseSBicm9rZW4gZGVzY3JpcHRpb24iLCBhbmQgYnJpbmdzIG5vdGhpbmcg dmFsdWFibGUKPj4gYnV0IGlycmVjb3ZlcmFibGUgZXRoZXJuYWwgcHJvYmxlbXMgdG8gb3ZlcmNv bWUuCj4+Cj4+PiBiZWxvbmdzIGluIHRoaXMgc3BlY2lmaWMgYmluZGluZyBpcyBvcGVuIGZvciBk aXNjdXNzaW9uLCBidXQgbXkKPj4+IGluY2xpbmF0aW9uIGlzIHRoYXQgaXQgZG9lcy4KPj4KPj4g VGhpcyByZWdpc3RlciBpcyBub3QgbmVlZGVkIHRvIGdldCBDQU1TUyB1cCB0byB0aGUgZnVuY3Rp b25hbGx5Cj4+IHdvcmtpbmcgc3RhZ2UsIHdoaWNoIGlzIHJlcHJlc2VudGVkIGJ5IHRoZSBzZXJp ZXMuCj4gCj4gQ0FNU1MgYWxyZWFkeSBzdXBwb3J0cyByZWFkaW5nIHRoZSBoYXJkd2FyZSB2ZXJz aW9uIGZyb20gc3VjaAo+IHRvcC1sZXZlbCByZWdpc3RlciBibG9ja3MgYW5kIGV4cG9zaW5nIGl0 IHRocm91Z2ggdGhlIG1lZGlhIGZyYW1ld29yay4KPiBXaGlsZSB0aGlzIGlzIG5vdCBzdHJpY3Rs eSByZXF1aXJlZCwgaXQgd2lsbCBsaWtlbHkgYmVjb21lIHVzZWZ1bCB0bwo+IGxpYmNhbWVyYSBp biB0aGUgZnV0dXJlLgoKTGlrZWx5IHNvLCBhbmQgSSBkaWRuJ3Qga25vdyBhYm91dCB0aGUgZmFj dCB0aGF0ICJjcGFzX3RvcCIgc3RvcmVzIHNvbWUKaGFyZHdhcmUgdmVyc2lvbiBpbmZvcm1hdGlv biwgd2hpY2ggbWF5IGJlIHV0aWxpemVkIGJ5IHVzZXJzcGFjZSwgdGhhbmsKeW91IGZvciBzaGFy aW5nIHRoaXMuCgpBbnl3YXkgYXQgdGhpcyBzdGFnZSwgaWYgdGhlcmUgaXMgbm8gc3Ryb25nIG9i amVjdGlvbnMsIEknZCBwcmVmZXIgdG8KZm9sbG93IHRoZSBjb25zZXJ2YXRpdmUgbW9kZWwgb2Yg bm90IGFkZGluZyAiY3Bhc190b3AiIHRvIENBTVNTLgoKTGlrZSBpdCdzIGJlZW4gc2FpZCwgaXQg bWlnaHQgYmUgcHJlZmVycmVkIHRvIGNyZWF0ZSBhIG5ldyBzdGFuZC1hbG9uZQpDUEFTIGRldmlj ZSBhYnN0cmFjdGlvbiwgd2l0aCBubyBjb25mbGljdCBmb3IgSS9PIHJlZ2lvbnMgd2l0aCBDQU1T UywKZXNwZWNpYWxseSBhc3N1bWluZyB0aGUgbGF0dGVyIG9uZSBqdXN0IGRvZXMgbm90IG5lZWQg dGhpcyBJL08gcmVnaW9uCmF0IGFsbCB0byBiZSBmdW5jdGlvbmFsLgoKQWxzbywgSSdtIGEgYml0 IGNvbmNlcm5lZCB3aGVuIHRoZSBhYnN0cmFjdGlvbiBpbnZlcnNpb24gaXMgdXNlZCBhcwphbiBh cmd1bWVudCwgaGVyZSB0aGUga2VybmVsIHNob3VsZCBub3QgZGVwZW5kIG9uIGxpYmNhbWVyYSBv ciBvdGhlcgp1c2Vyc3BhY2UgY29tcG9uZW50LCBidXQgdGhlIG9wcG9zaXRlIGlzIHRvIGJlIHNh dGlzZmllZCwgaS5lLiBsaWJjYW1lcmEKc2hvdWxkIHdvcmsgcHJvcGVybHkgd2l0aCA5MCUgb2Yg Q0FNU1MgdmFyaWFudHMsIHdoaWNoIGRvIG5vdCBleHBvcnQKImNwYXNfdG9wIiBpbmZvLCBsaWtl IHRoaXMgb3IgbWFueSBvdGhlciByZWNlbnRseSBhZGRlZCBDQU1TUyB2YXJpYW50cy4KCj4+IEkg YmVsaWV2ZSBzb21lb25lIG1heSBjcmVhdGUgYSBuZXcgZmFuY3kgQ1BBUyBkZXZpY2UgZHJpdmVy IG9yIHNvLCBhbmQKPj4gdGhlIG5ldyBkZXZpY2UgZHJpdmVyIHdpbGwgdXRpbGl6ZSB0aGUgImNw YXNfdG9wIiByZWdpc3RlciBhbmQgb3RoZXIKPj4gQ1BBUyByZXNvdXJjZXMgaW4gYSBiZXR0ZXIg d2F5LCB0aGUgcmVnaXN0ZXIgc2hhbGwgbm90IGJlIG5haWxlZCB0bwo+PiB0aGUgQ0FNU1MgcHJl bGltaW5hcmx5Lgo+IAo+IFdlbGwsIHllcywgd2UgY291bGQgY2VydGFpbmx5IG1vZGVsIGl0IGFz IGEgc3lzY29uIG5vZGUsIGVzcGVjaWFsbHkKPiBub3cgdGhhdCBDQU1TUyBpcyBubyBsb25nZXIg dGhlIG1vbm9saXRoaWMgYmxvY2sgaXQgdXNlZCB0byBiZS4KPiAKClN1cmUsIHRoYXQncyB0aGUg dmlldyBJIHNoYXJlIHRvIGV4cGxvaXQgdGhlIG1vZHVsYXJpc2F0aW9uIGF0IG1heGltdW0uCgpB cyBhbHdheXMsIHRoYW5rIHlvdSB2ZXJ5IG11Y2ggZm9yIHJldmlldyEKCi0tIApCZXN0IHdpc2hl cywKVmxhZGltaXIKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793105858; b=32ig/YH3NctxQ2nO7n1xmR2LBlSgbstzGkJL7VX6mC9lM3fc9aJ2+FWWAr8SmU1nMg9J J6uB62UK8r4eWilQ3ePEn81NtJC73bmWlHeIMpRZBOHDjUROnW3dwdrhFgvfL99kc3Mcz lhrbXy6Uq42qP6CdA418sWZm4GY2gWogCVOp3EVQxXO8sAt39uWvlt/ezveP+cDrFwXoD Nvijd45dA80c1sPOjTlnfxCn0b7Ifp3NtBgFMg8f4ygQWy//PcX7rz/Imz16hlKPAWFxe y1g8SXTTIChZKQQe04u9+c/9LB2wWhpd0ZYR8QkaH5xtMwODxtUFmVrZCmAf7v9Zxqw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793105858; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=ladm7VNw3w94qCYNsul6pq86i2SGy96Tryu3X7+mFyY=; b=23aMJRzZ+fBTZ7JoBtpzTCbu62WU7FBFxcUFPQD/gG18OuHcijUQ3jQQ3rQDBUKfjiPt DmCMhnjXU662pDKpX0w7Ve5hL8eihUEpWqmCAFY1KDlwSZ4HRvEJemWDl7T0xdhUQZ8AU e/Zjrgetj8KozjQZv6VsS3a91uNDE92fANrF41srHsLeqvf84Igpe1cbA7YUC4jCRssDg F1q/TbusdEga5ov/ams3VWNkLuao1qbv3CNRJ+p2bLw6myvhwySNkdCdUl+MDr5+N5N8Q gACrKuXVKX3QVpgZ5Th1rMOCKgKAvHgPA427Pah0JrLhG79gtQZF24eBlqoZ4mkimWw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mRc9dkJP; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F853606A31B; Tue, 27 Oct 2026 12:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mRc9dkJP Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BB821F01825; Tue, 27 Oct 2026 12:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793105857; bh=ladm7VNw3w94qCYNsul6pq86i2SGy96Tryu3X7+mFyY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=mRc9dkJP49MiwKf3rSOK32sJbhXthHhtbOG/JfyMsNlpq7pddc8gs2aJtUy8AY7Mh e6fQH/rpFVkUt8zIxrDEPKetT2/IVD5SDxlMNlpd4B1KjR5E/NPJRgUKtMPNeeyJUp wRqyNNMGOH8MgTooKcF+gd8ErmtonbxJKyUs5/hmKrrBE5bjsaaRYSdHsZwtWl0DVx i3IFSra+WQuJmNFXuA28aJnUOLl4TvRN2SffGsty6xKJq99kBbfX1DA/1BPL2AyAXs DEUqcdLKfPs7C4l3dOWepcqNoiFYD9dOggir6Vsr3/0u3ZWs8O58uYpDxNriGMY/SF dncx6iS/hqWuw== Message-ID: <6358dcdc-cdf4-4986-ba6b-a5cca4a093fa@kernel.org> Date: Tue, 27 Oct 2026 14:57:31 +0200 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] arm64: dts: qcom: sm8450: Add CAMSS device tree node To: Loic Poulain Cc: Bjorn Andersson , Konrad Dybcio , Abel Vesa , Bryan O'Donoghue , Vinod Koul , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, Neil Armstrong , Manivannan Sadhasivam , linux-phy@lists.infradead.org, Conor Dooley , devicetree@vger.kernel.org References: <20261023163057.775917-1-vz@kernel.org> <20261023163057.775917-5-vz@kernel.org> <378094fb-5f7f-42c6-a91f-158e2083a6cb@kernel.org> <0d25a732-ccd5-4a7b-9809-93e67899b4e7@kernel.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Loic. On 10/27/26 12:31, Loic Poulain wrote: > Hi Vlad, > > > On Tue, Oct 27, 2026 at 10:54 AM Vladimir Zapolskiy wrote: >> >> On 10/27/26 11:07, Loic Poulain wrote: >>> On Mon, Oct 26, 2026 at 11:39 PM Vladimir Zapolskiy wrote: >>>> >>>> Hi Loic. >>>> >>>> On 10/26/26 18:32, Loic Poulain wrote: >>>>> On Fri, Oct 23, 2026 at 6:31 PM Vladimir Zapolskiy wrote: >>>>>> >>>>>> Add Qualcomm Waipio CAMSS device tree node to the platform dtsi file, >>>>>> the CAMSS input ports are connected to output ports of CSIPHY devices. >>>>>> >>>>>> Signed-off-by: Vladimir Zapolskiy >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 167 +++++++++++++++++++++++++++ >>>>>> 1 file changed, 167 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>> index babf1a4196a1..7f5b0501a23e 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>> @@ -3310,6 +3310,167 @@ cci1_i2c1: i2c-bus@1 { >>>>>> }; >>>>>> }; >>>>>> >>>>>> + camss: isp@acb6000 { >>>>>> + compatible = "qcom,waipio-camss"; >>>>>> + reg = <0 0xacb6000 0 0x1000>, >>>>>> + <0 0xacb7000 0 0x1000>, >>>>>> + <0 0xacb9000 0 0x1000>, >>>>>> + <0 0xacbb000 0 0x1000>, >>>>>> + <0 0xacc6000 0 0x1000>, >>>>>> + <0 0xacca000 0 0x1000>, >>>>>> + <0 0xacf6000 0 0x1000>, >>>>>> + <0 0xacf7000 0 0x1000>, >>>>>> + <0 0xacf8000 0 0x1000>, >>>>>> + <0 0xac62000 0 0x3000>, >>>>>> + <0 0xac71000 0 0x3000>, >>>>>> + <0 0xac80000 0 0x3000>, >>>>>> + <0 0xacc7000 0 0x2000>, >>>>>> + <0 0xaccb000 0 0x2000>; >>>>>> + reg-names = "csid_wrapper", >>>>>> + "csid0", >>>>>> + "csid1", >>>>>> + "csid2", >>>>>> + "csid_lite0", >>>>>> + "csid_lite1", >>>>>> + "tpg0", >>>>>> + "tpg1", >>>>>> + "tpg2", >>>>>> + "vfe0", >>>>>> + "vfe1", >>>>>> + "vfe2", >>>>>> + "vfe_lite0", >>>>>> + "vfe_lite1"; >>>>> >>>>> Is there a camss "top" register to describe here? e.g. to retrieve the >>>>> CAMSS hardware version. >>>> >>>> I'm not aware of anything like that. What is "CAMSS hardware version"? >>>> >>>> CAMSS embraces various blocks, there are CSID and VFE, full and lite >>>> IPs, and all these components do export their versions individually. >>> >>> I mean, CAMSS usually has a top-level register block (often top or >>> cpas_top) that contains the Titan/Spectra version information, along >>> with various global configuration and mux registers. >> >> On SM8450 there is "cpas_top" register <0xac13000 0x1000> (not in the >> series), I believe you reference to it. >> >> Is CPAS a natural part of CAMSS? Can it be modelled differently, e.g. >> as a separate device/driver, like it was done with JPEG or CSIPHY? >> >> I see that there are only SM6150 and SM6350 platforms mention this >> register, to capture and process frames on SM8450 there is no need >> to program CPAS. >> >> Note, that even SM6150 and SM6350 platforms do not use this register, >> it makes it redundant. >> >>> In particular, exposing this block could be useful for reporting the >>> Spectra version to userspace, for example through libcamera. >> >> It could be so, but adding dead code is an anti-pattern in software design. >> >>> Moreover, if the goal is to describe the CAMSS hardware exhaustively >>> in DT, this block should probably be represented as well. Whether it >> >> Here I oppose such a goal as impractical, the set goal is to get working >> camera on the platform with the minimum of irreversible changes. It was >> proven multiple times in the past, that "an exhaustive description" >> equals to "the totally broken description", and brings nothing valuable >> but irrecoverable ethernal problems to overcome. >> >>> belongs in this specific binding is open for discussion, but my >>> inclination is that it does. >> >> This register is not needed to get CAMSS up to the functionally >> working stage, which is represented by the series. > > CAMSS already supports reading the hardware version from such > top-level register blocks and exposing it through the media framework. > While this is not strictly required, it will likely become useful to > libcamera in the future. Likely so, and I didn't know about the fact that "cpas_top" stores some hardware version information, which may be utilized by userspace, thank you for sharing this. Anyway at this stage, if there is no strong objections, I'd prefer to follow the conservative model of not adding "cpas_top" to CAMSS. Like it's been said, it might be preferred to create a new stand-alone CPAS device abstraction, with no conflict for I/O regions with CAMSS, especially assuming the latter one just does not need this I/O region at all to be functional. Also, I'm a bit concerned when the abstraction inversion is used as an argument, here the kernel should not depend on libcamera or other userspace component, but the opposite is to be satisfied, i.e. libcamera should work properly with 90% of CAMSS variants, which do not export "cpas_top" info, like this or many other recently added CAMSS variants. >> I believe someone may create a new fancy CPAS device driver or so, and >> the new device driver will utilize the "cpas_top" register and other >> CPAS resources in a better way, the register shall not be nailed to >> the CAMSS preliminarly. > > Well, yes, we could certainly model it as a syscon node, especially > now that CAMSS is no longer the monolithic block it used to be. > Sure, that's the view I share to exploit the modularisation at maximum. As always, thank you very much for review! -- Best wishes, Vladimir