From: Artem Bityutskiy <dedekind1@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Linux PM Mailing List <linux-pm@vger.kernel.org>
Subject: Re: [PATCH resend] platform/x86: intel-uncore-freq: add Emerald Rapids support
Date: Wed, 23 Nov 2022 10:45:57 +0200 [thread overview]
Message-ID: <635d481206b8945db751ea036cf789fe13b9698e.camel@gmail.com> (raw)
In-Reply-To: <0b867f52-5fe8-f0e8-3f05-746b1db0059e@redhat.com>
Hello Hans,
On Tue, 2022-11-22 at 16:30 +0100, Hans de Goede wrote:
There are 3 different issues with this patch, next time please
check your patch a bit more thorough before submitting it:
1. This is the first time I see this, or that the
platform-driver-x86@vger.kernel.org
list sees this. Next time please make sure you address the patch to the right
people the first time you send it:
sure, thanks.
2. This has checkpatch warnings which are easily fixable:
[hans@shalem platform-drivers-x86]$ scripts/checkpatch.pl 0001-platform-x86-
intel-uncore-freq-add-Emerald-Rapids-su.patch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)
OK.
3. This fails to build on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
OK, thanks for the pointer. I'd need platfrom-drivers-x86 git tree to include
this upstream commit:
7beade0dd41d x86/cpu: Add several Intel server CPU model numbers
Would you please consider updating?
Thanks!
next prev parent reply other threads:[~2022-11-23 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 7:00 [PATCH resend] platform/x86: intel-uncore-freq: add Emerald Rapids support Artem Bityutskiy
2022-11-22 15:30 ` Hans de Goede
2022-11-23 8:45 ` Artem Bityutskiy [this message]
2022-11-23 14:37 ` Hans de Goede
2022-11-23 14:59 ` Rafael J. Wysocki
2022-11-23 15:22 ` Rafael J. Wysocki
2022-11-23 15:54 ` Hans de Goede
2022-11-23 15:57 ` Rafael J. Wysocki
2022-11-23 17:25 ` srinivas pandruvada
2022-11-23 20:59 ` Hans de Goede
2022-11-24 7:04 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=635d481206b8945db751ea036cf789fe13b9698e.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-pm@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.