From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932167AbbKBPiP (ORCPT ); Mon, 2 Nov 2015 10:38:15 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:62177 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471AbbKBPiO (ORCPT ); Mon, 2 Nov 2015 10:38:14 -0500 From: Arnd Bergmann To: Geliang Tang Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tony Luck , Fenghua Yu Subject: Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init Date: Mon, 02 Nov 2015 16:37:51 +0100 Message-ID: <6366386.xsGhxxeFtE@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <280fb52bda85af452e129fa5633598954801871c.1446475492.git.geliangtang@163.com> References: <4a37e163f338e9f16c4bae9c819b35afaacbf585.1446475492.git.geliangtang@163.com> <280fb52bda85af452e129fa5633598954801871c.1446475492.git.geliangtang@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:yt43Xyuac+a602CjDLSsVMv5CDXcgMQBgXAX1Cc/oQPF4xyCK1T S4Z4kttK9GmTM4IukfVZRG5eW+bckl5DsQLGGfMCbPcrY5sz7LA3QmUmvmQJxIBZ7DhvMav BlGaWSXoWU6p9lTJsF02rmTlduc9Me40s4iAGOuwuiJ0ei9aehOD9X8iiWfZPEVLMeLUD6J ZKCpGWvIuNbhZ+DqV847A== X-UI-Out-Filterresults: notjunk:1;V01:K0:cGBIxKceX4c=:hslJe1ee916EC/MJupIgjd +U5aWyJfth2HLIFUiLhuQmE7JIT2f8dpXOuVnD9MMEgxpHUS0OGkdPD5BcDHhW5CVDt7G6htX MHYWVNg01nizZz+cCAYMjYggW0F2RtclXjDYDCVgqp8grqSqlngf/KNhlsqLe1PoFBeG5PpRv w/IM8cUj3emSkZlCThmhnkbQkI6QC2PDlgJgZAUKAs85o+xhMFLf334AMk7ZNnPZJzsv7OfKc ywFVh93o5+2Z0bwWN5jz+hSZOFhtwk0OjRuCju77KrhRbVK63Hcc6Y5jZ9GxQScTTRk60VWtP Zad03FQ5WqwtbzdhRwGuDAqw/UFi5OpF3Bp7OocTQzYsT9/BIYOZgkQVg1z/o28j5ilhlrdFM LBugQ12aSQ9Z/HXhtRUYycCXGDxUwnX/93Rl2HguV18bmk0rfmvF17PNyL/eeiyM5d7gG/NF9 aj3aTLtGPWZxb/jk0ZWVA2gep7+ojyO60PdEI3ClyQXElY8bNh3AZf6wBWvbMzEl+8zLDG8A0 IeYFGARLEqB8Nj2dL081v+W0c62YklghcOD5EhuK9vWvWr2m9YLEyrav3hZ3E/y1KRJ0zGfqs 9SRdBSz9z/pkmCj5E8lCG0I4MNiY/4cSiWEeAWmlp6uS3qgE/O+fkZZxlgcLNB1CfYQIPvcra dTAFI42BPnqyfbmxbCkmLc0aOKVyUjcLdzhfDkketdS9KfjTkLhZcBq/BRVTampUNk33fcqlr FQ0xZRFx5A6eHzFb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 02 November 2015 22:49:01 Geliang Tang wrote: > diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c > index 5323d8c..80058bd 100644 > --- a/drivers/char/efirtc.c > +++ b/drivers/char/efirtc.c > @@ -378,6 +378,9 @@ efi_rtc_init(void) > int ret; > struct proc_dir_entry *dir; > > + if (!efi_enabled(EFI_RUNTIME_SERVICES)) > + return 0; > Are there any Itanium machines that don't enable runtime services? This seems a little redundant otherwise. Are you trying to run the ancient driver on non-Itanium systems? Arnd