Re: [PATCH v5 4/4] ARM: dts: stm32: add initial support for stm32mp157-ultra-fly-sbc board

[Goran Radenovic <goran.radni@gmail.com>]

Hi Andrew,

thank You very much for Your comments.

Andrew Lunn wrote:
>> +&ethernet0 {
>> +	status = "okay";
>> +	pinctrl-0 = <&ethernet0_ux_rgmii_pins_a>;
>> +	pinctrl-1 = <&ethernet0_ux_rgmii_pins_sleep_a>;
>> +	pinctrl-names = "default", "sleep";
>> +	phy-mode = "rgmii-id";
>> +	max-speed = <1000>;
> 
> max-speed is probably pointless, rgmii cannot do more than 1G.

Agreed. I'll drop the `max-speed` property in the next revision.


>> +	phy-handle = <&phy1>;
>> +
>> +	mdio {
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +		compatible = "snps,dwmac-mdio";
>> +		phy1: ethernet-phy@1 {
>> +			reg = <1>;
>> +			interrupt-parent = <&gpiod>;
>> +			interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
> 
> PHY interrupts are 99% time level, not edge.

That is correct, but I am facing strange behavior, when I set 
IRQ_TYPE_LEVEL_LOW.
My board stops booting at:

[    2.343233] Waiting for root device /dev/mmcblk0p4...
[   12.638818] platform 5a006000.usbphyc: deferred probe pending
[   12.643192] platform 49000000.usb-otg: deferred probe pending
[   12.649029] platform 48003000.adc: deferred probe pending
[   12.654277] platform 5800d000.usb: deferred probe pending
[   12.659744] platform 5800c000.usb: deferred probe pending
[   12.665089] amba 58005000.mmc: deferred probe pending
[   12.670239] amba 58007000.mmc: deferred probe pending
[   12.675185] platform 50025000.vrefbuf: deferred probe pending

I must investigate this. If You have any idea, You are welcome to share it.

> 	Andrew