From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, anand.rawat@intel.com, stable@dpdk.org,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [PATCH] eal/windows: fix data race when creating threads
Date: Wed, 30 Mar 2022 19:04:29 +0200 [thread overview]
Message-ID: <6367643.tM3a2QDmDi@thomas> (raw)
In-Reply-To: <20220310191932.17985164@sovereign>
10/03/2022 17:19, Dmitry Kozlyuk:
> Hi Tyler,
>
> 2022-03-09 23:35 (UTC-0800), Tyler Retzlaff:
> > create lcore worker threads suspended and then subsequently resume to
> > allow &lcore_config[i].thread_id be stored before eal_thread_loop
> > execution.
> >
> > Fixes: 53ffd9f080fc ("eal/windows: add minimum viable code")
> > Cc: anand.rawat@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> It takes some effort to correlate &lcore_config[i].thread_id
> with the code in the patch and knowledge of CreateThread()
> to understand the root cause.
> I suggest prepending an explanation to your commit message:
>
> eal_thread_loop() uses lcore_config[i].thread_id,
> which is stored upon the return from CreateThread().
> Per documentation, eal_thread_loop() can start
> before CreateThread() returns and the ID is stored.
There was now reply to this suggestion after 3 weeks,
so I've decided to include it.
Applied, thanks.
prev parent reply other threads:[~2022-03-30 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 7:35 [PATCH] eal/windows: fix data race when creating threads Tyler Retzlaff
2022-03-10 16:19 ` Dmitry Kozlyuk
2022-03-30 17:04 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6367643.tM3a2QDmDi@thomas \
--to=thomas@monjalon.net \
--cc=anand.rawat@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.