All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain <ju.o@free.fr>
To: Francois Dugast <francois.dugast.foss@gmail.com>
Cc: buildroot@buildroot.org,
	Alistair Francis <alistair@alistair23.me>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 1/2] configs/hifive_unleashed: extract common configuration
Date: Wed, 26 Mar 2025 21:32:47 +0100	[thread overview]
Message-ID: <6369e9cbe4e2db67e15bcdc76d66df4e@free.fr> (raw)
In-Reply-To: <20250323172806.558397-2-francois.dugast.foss@gmail.com>

Hi Francois,

Thank you for the patch!

On 23/03/2025 18:28, Francois Dugast wrote:
> Move the generic part of the configuration into a new "common"
> directory so that it is easier to add similar boards without
> duplicating the files.
> 
> Signed-off-by: Francois Dugast <francois.dugast.foss@gmail.com>

[...]

> diff --git a/board/sifive/hifive-unleashed/post-build.sh 
> b/board/sifive/common/post-build.sh
> similarity index 100%
> rename from board/sifive/hifive-unleashed/post-build.sh
> rename to board/sifive/common/post-build.sh

Running the command "utils/docker-run make check-package" generates
an error here:

     .checkpackageignore:75: ignored file 
board/sifive/hifive-unleashed/post-build.sh is missing
     board/sifive/common/post-build.sh:0: run 'shellcheck' and fix the 
warnings

This is because you move the file here, but the entry in
".checkpackageignore" is not updated accordingly. Since this is a
trivial shellcheck warning, maybe you could resolve this shellcheck
warning (by quoting the variables) and remove the entry in
.checkpackageignore, in a separate patch, before this one.

If you do so, then this patch could remain the same.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-03-26 20:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-23 17:28 [Buildroot] [PATCH 0/2] Add support for the HiFive Unmatched board Francois Dugast
2025-03-23 17:28 ` [Buildroot] [PATCH 1/2] configs/hifive_unleashed: extract common configuration Francois Dugast
2025-03-26 20:32   ` Julien Olivain [this message]
2025-03-23 17:28 ` [Buildroot] [PATCH 2/2] configs/hifive_unmatched: new board Francois Dugast
2025-03-26 20:57   ` Julien Olivain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6369e9cbe4e2db67e15bcdc76d66df4e@free.fr \
    --to=ju.o@free.fr \
    --cc=alistair@alistair23.me \
    --cc=buildroot@buildroot.org \
    --cc=francois.dugast.foss@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.