All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, xiao.w.wang@intel.com,
	jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com,
	qiming.yang@intel.com, haiyue.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 2/9] net: replace build option
Date: Wed, 17 Mar 2021 23:00:45 +0100	[thread overview]
Message-ID: <6388516.0yhbR63jCu@thomas> (raw)
In-Reply-To: <eeb6fe9d-7947-e25c-19fc-12b953952073@intel.com>

17/03/2021 22:47, Ferruh Yigit:
> On 3/17/2021 11:15 AM, Qi Zhang wrote:
> > Replace RTE_LIBRTE_ETHDEV_DEBUG with RTE_ETHDEV_DEBUG.
> > 
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Hi Qi, Thomas,
> 
> I see Thomas mentioned 'LIBRTE_' is redundant but not sure about renaming the 
> existing compile time flag without notice.
> 
> The flag is to be used for users, it is not internal, and it may be already used 
> in some scripts and automation etc, this rename can break them.
> 
> 'LIBRTE_' is already used commonly, I think all library flags has it, do we 
> really need to drop it from this current one? Even if we drop it, what about 
> keeping it as alias for backward compatibility?

Yes I did not ask for removing now :)
Let's keep old name as alias and start using the new name
(if you agree with the new name without LIBRTE_).



  reply	other threads:[~2021-03-17 22:00 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 12:16 [dpdk-dev] [PATCH 0/8] ether: refine debug compile option Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 1/8] " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 2/8] net/fm10k: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 3/8] net/e1000: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 4/8] net/i40e: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 5/8] net/iavf: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 6/8] net/ice: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 7/8] net/ixgbe: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 8/8] net/igc: " Qi Zhang
2021-03-10 12:35 ` [dpdk-dev] [PATCH 0/8] ether: " Ferruh Yigit
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 " Qi Zhang
2021-03-12 12:12   ` [dpdk-dev] [PATCH v2 1/8] " Qi Zhang
2021-03-16 13:05     ` Ferruh Yigit
2021-03-16 13:39       ` Thomas Monjalon
2021-03-16 14:12         ` Bruce Richardson
2021-03-16 23:29           ` Zhang, Qi Z
2021-03-16 16:37         ` Ferruh Yigit
2021-03-22 17:24           ` Ferruh Yigit
2021-03-23  8:43             ` Zhang, Qi Z
2021-03-12 12:12   ` [dpdk-dev] [PATCH v2 2/8] net/fm10k: " Qi Zhang
2021-03-12 12:12   ` [dpdk-dev] [PATCH v2 3/8] net/e1000: " Qi Zhang
2021-03-12 12:12   ` [dpdk-dev] [PATCH v2 4/8] net/i40e: " Qi Zhang
2021-03-12 12:12   ` [dpdk-dev] [PATCH v2 5/8] net/iavf: " Qi Zhang
2021-03-12 12:12   ` [dpdk-dev] [PATCH v2 6/8] net/ice: " Qi Zhang
2021-03-12 12:12   ` [dpdk-dev] [PATCH v2 7/8] net/ixgbe: " Qi Zhang
2021-03-12 12:12   ` [dpdk-dev] [PATCH v2 8/8] net/igc: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 0/9] ether: refine debug build option Qi Zhang
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 1/9] " Qi Zhang
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 2/9] net: replace " Qi Zhang
2021-03-17 21:47     ` Ferruh Yigit
2021-03-17 22:00       ` Thomas Monjalon [this message]
2021-03-18  0:58         ` Zhang, Qi Z
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 3/9] net/fm10k: refine debug " Qi Zhang
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 4/9] net/e1000: " Qi Zhang
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 5/9] net/i40e: " Qi Zhang
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 6/9] net/iavf: " Qi Zhang
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 7/9] net/ice: " Qi Zhang
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 8/9] net/ixgbe: " Qi Zhang
2021-03-17 11:15   ` [dpdk-dev] [PATCH v3 9/9] net/igc: " Qi Zhang
2021-03-18  1:42 ` [dpdk-dev] [PATCH v4 0/8] ether: " Qi Zhang
2021-03-18  1:42   ` [dpdk-dev] [PATCH v4 1/8] " Qi Zhang
2021-03-18  1:42   ` [dpdk-dev] [PATCH v4 2/8] net/fm10k: " Qi Zhang
2021-03-18  1:42   ` [dpdk-dev] [PATCH v4 3/8] net/e1000: " Qi Zhang
2021-03-18  1:42   ` [dpdk-dev] [PATCH v4 4/8] net/i40e: " Qi Zhang
2021-03-18  1:42   ` [dpdk-dev] [PATCH v4 5/8] net/iavf: " Qi Zhang
2021-03-18  1:42   ` [dpdk-dev] [PATCH v4 6/8] net/ice: " Qi Zhang
2021-03-18  1:42   ` [dpdk-dev] [PATCH v4 7/8] net/ixgbe: " Qi Zhang
2021-03-18  1:42   ` [dpdk-dev] [PATCH v4 8/8] net/igc: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 0/8] ether: " Qi Zhang
2021-03-23 11:07   ` [dpdk-dev] [PATCH v5 1/8] " Qi Zhang
2021-03-23 14:44     ` Ferruh Yigit
2021-03-23 21:14     ` Thomas Monjalon
2021-03-23 11:07   ` [dpdk-dev] [PATCH v5 2/8] net/fm10k: " Qi Zhang
2021-03-23 14:45     ` Ferruh Yigit
2021-03-23 11:07   ` [dpdk-dev] [PATCH v5 3/8] net/e1000: " Qi Zhang
2021-03-23 11:07   ` [dpdk-dev] [PATCH v5 4/8] net/i40e: " Qi Zhang
2021-03-23 11:07   ` [dpdk-dev] [PATCH v5 5/8] net/iavf: " Qi Zhang
2021-03-23 11:07   ` [dpdk-dev] [PATCH v5 6/8] net/ice: " Qi Zhang
2021-03-23 11:07   ` [dpdk-dev] [PATCH v5 7/8] net/ixgbe: " Qi Zhang
2021-03-23 11:07   ` [dpdk-dev] [PATCH v5 8/8] net/igc: " Qi Zhang
2021-03-24 19:27     ` Ferruh Yigit
2021-03-24 20:31       ` David Marchand
2021-03-25 15:43         ` Ferruh Yigit
2021-03-30 14:06           ` Ferruh Yigit
2021-03-23 11:08   ` [dpdk-dev] [PATCH v5 0/8] ether: " Zhang, Qi Z
2021-03-23 14:47   ` Ferruh Yigit
2021-03-31  9:52 ` [dpdk-dev] [PATCH v6 " Qi Zhang
2021-03-31  9:52   ` [dpdk-dev] [PATCH v6 1/8] " Qi Zhang
2021-04-01 14:30     ` Ferruh Yigit
2021-05-05 11:45       ` Ferruh Yigit
2021-05-05 12:21         ` Michał Krawczyk
2021-05-05 14:38           ` Ferruh Yigit
2021-05-06 11:09             ` [dpdk-dev] [EXT] " Rasesh Mody
2021-03-31  9:52   ` [dpdk-dev] [PATCH v6 2/8] net/fm10k: " Qi Zhang
2021-03-31  9:52   ` [dpdk-dev] [PATCH v6 3/8] net/e1000: " Qi Zhang
2021-03-31  9:52   ` [dpdk-dev] [PATCH v6 4/8] net/i40e: " Qi Zhang
2021-03-31  9:52   ` [dpdk-dev] [PATCH v6 5/8] net/iavf: " Qi Zhang
2021-03-31  9:52   ` [dpdk-dev] [PATCH v6 6/8] net/ice: " Qi Zhang
2021-03-31  9:52   ` [dpdk-dev] [PATCH v6 7/8] net/ixgbe: " Qi Zhang
2021-03-31  9:52   ` [dpdk-dev] [PATCH v6 8/8] net/igc: " Qi Zhang
2021-04-01 14:11   ` [dpdk-dev] [PATCH v6 0/8] ether: " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6388516.0yhbR63jCu@thomas \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=haiyue.wang@intel.com \
    --cc=jia.guo@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.