All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wachowski, Karol" <karol.wachowski@linux.intel.com>
To: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, jeff.hugo@oss.qualcomm.com,
	lizhi.hou@amd.com, andrzej.kacprowski@linux.intel.com
Subject: Re: [PATCH] accel/ivpu: Cache FW API version and simplify API check macros
Date: Wed, 14 Oct 2026 08:05:33 +0200	[thread overview]
Message-ID: <638bc116-bdcf-4872-97bb-59d50fe6457b@linux.intel.com> (raw)
In-Reply-To: <1939c1aa-4ca8-409e-86a6-63c8bb5a99c7@linux.intel.com>

On 12-Oct-26 12:38, Dawid Osuchowski wrote:
> On 2026-10-12 10:09 AM, Karol Wachowski wrote:
>> Copy the API version array from the firmware image header into
>> struct ivpu_fw_info while the header is being parsed, and use the
>> cached copy afterwards. This way the raw firmware image header is only
>> accessed during image parsing, which is a step towards releasing the
>> firmware image once it has been loaded.
>>
>> Since the API version is now available in vdev->fw before the
>> compatibility checks run, drop the redundant fw_hdr parameter from
>> IVPU_FW_CHECK_API_COMPAT(), IVPU_FW_CHECK_API_VER_LT() and the helpers
>> behind them, as well as from ivpu_fw_sched_mode_select().
>>
>> Also make DRM_IVPU_PARAM_FW_API_VERSION read the cached copy instead of
>> dereferencing the firmware image directly.
>>
>> No functional change.
>>
> 
> Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>

Thanks, applied to drm-misc-next.

> 
>> Co-developed-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
>> Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
>> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
>> ---
>>   drivers/accel/ivpu/ivpu_drv.c |  5 +----
>>   drivers/accel/ivpu/ivpu_fw.c  | 36 +++++++++++++++++------------------
>>   drivers/accel/ivpu/ivpu_fw.h  |  1 +
>>   3 files changed, 20 insertions(+), 22 deletions(-)
>>


      reply	other threads:[~2026-10-14  6:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12  8:09 [PATCH] accel/ivpu: Cache FW API version and simplify API check macros Karol Wachowski
2026-10-12 10:38 ` Dawid Osuchowski
2026-10-14  6:05   ` Wachowski, Karol [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=638bc116-bdcf-4872-97bb-59d50fe6457b@linux.intel.com \
    --to=karol.wachowski@linux.intel.com \
    --cc=andrzej.kacprowski@linux.intel.com \
    --cc=dawid.osuchowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=lizhi.hou@amd.com \
    --cc=oded.gabbay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.