Re: [PATCH net-next v4 4/4] net: renesas: rswitch: add modifiable ageing time

[Sergey Shtylyov <sergei.shtylyov@gmail.com>]

On 8/28/25 1:23 PM, Michael Dege wrote:

> This commit allows the setting of the MAC table aging in the R-Car S4

    Please just use the imperative mood: Allow the setting...

> Rswitch using the SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute.
> 
> Signed-off-by: Michael Dege <michael.dege@renesas.com>
> ---
>  drivers/net/ethernet/renesas/rswitch_l2.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/drivers/net/ethernet/renesas/rswitch_l2.c b/drivers/net/ethernet/renesas/rswitch_l2.c
> index 49a24464dbb0cf3f3219a0699fc4671ddd71ef03..c57396af70a4b291746d6451eae7cf60b3f89721 100644
> --- a/drivers/net/ethernet/renesas/rswitch_l2.c
> +++ b/drivers/net/ethernet/renesas/rswitch_l2.c
> @@ -193,6 +193,25 @@ static int rswitch_netdevice_event(struct notifier_block *nb,
>  	return NOTIFY_OK;
>  }
>  
> +static int rswitch_update_ageing_time(struct net_device *ndev, clock_t time)
> +{
> +	struct rswitch_device *rdev = netdev_priv(ndev);
> +	u32 reg_val;
> +
> +	if (!is_rdev(ndev))
> +		return -ENODEV;
> +
> +	if (!FIELD_FIT(FWMACAGC_MACAGT, time))
> +		return -EINVAL;
> +
> +	rdev = netdev_priv(ndev);

   Haven't you already initialized rdev to the same value above?

[...]

MBR, Sergey