From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, davem@davemloft.com, wli@holomorphy.com,
matthew@wil.cx, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg()
Date: Thu, 07 Dec 2006 20:06:39 +0000 [thread overview]
Message-ID: <639.1165521999@redhat.com> (raw)
In-Reply-To: <20061207085409.228016a2.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
> and we can assume (and ensure) that a failing test_and_set_bit() will not
> write to the affected word at all.
You may not assume that; and indeed that is not so in the generic
spinlock-based bitops or ARM pre-v6 or PA-RISC or sparc32 or ...
Remember: if you have to put a conditional jump in there, it's going to fail
one way or the other a certain percentage of the time, and that's going to
cause a pipeline stall, and these ops are used quite a lot.
OTOH, I don't know that the stall would be that bad since the spin_lock and
spin_unlock may cause a stall anyway.
David
next prev parent reply other threads:[~2006-12-07 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 15:31 [PATCH 1/3] WorkStruct: Fix up some PA-RISC work items David Howells
2006-12-07 15:31 ` [PATCH 2/3] WorkStruct: Add assign_bits() to give an atomic-bitops safe assignment David Howells
2006-12-07 15:31 ` [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg() David Howells
2006-12-07 16:54 ` Andrew Morton
2006-12-07 20:06 ` David Howells [this message]
2006-12-07 21:06 ` Andrew Morton
2006-12-07 21:06 ` James Bottomley
2006-12-07 21:16 ` David Howells
2006-12-07 22:11 ` David Miller
2006-12-07 23:42 ` Russell King
2006-12-07 23:58 ` David Howells
2006-12-08 11:14 ` Russell King
2006-12-08 13:57 ` David Howells
2006-12-08 3:42 ` [PATCH 1/3] WorkStruct: Fix up some PA-RISC work items Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639.1165521999@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.