Re: [PATCH v3 3/4] eal: remove experimental flag of hotplug functions

[Thomas Monjalon <thomas@monjalon.net>]

02/10/2018 12:28, Ferruh Yigit:
> On 9/28/2018 5:21 PM, Thomas Monjalon wrote:
> > These functions are quite old and are the only available replacement
> > for the deprecated attach/detach functions.
> > 
> > Note: some new functions may (again) replace these hotplug functions,
> > in future, with better parameters.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >  lib/librte_eal/common/eal_common_dev.c  |  7 ++++---
> >  lib/librte_eal/common/include/rte_dev.h | 11 ++---------
> >  lib/librte_eal/rte_eal_version.map      |  4 ++--
> 
> Can remove "-DALLOW_EXPERIMENTAL_API" (or "allow_experimental_apis = true" for
> meson) from drivers/raw/ifpga_rawdev when these APIs are not experimental anymore.
> For reference: https://patches.dpdk.org/patch/45836/

Yes we could remove this flag in this patch.
But the next series would add it again:
	https://patches.dpdk.org/patch/45601/

So I think it is not worth for now.

> It is easy to know when to add "-DALLOW_EXPERIMENTAL_API" but it is hard to know
> when to remove one, some helper should be good there.

Yes, we should try to clean up those flags regularly after each -rc1 release.
But we don't have any tooling for that.