From: Andrew Lunn <andrew@lunn.ch>
To: Ujwal Kundur <ujwal.kundur@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
allison.henderson@oracle.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rds: Fix endian annotations across various assignments
Date: Sun, 10 Aug 2025 22:19:54 +0200 [thread overview]
Message-ID: <63a22c3c-ee9b-44cd-9e5a-a68bb366eba5@lunn.ch> (raw)
In-Reply-To: <CALkFLLJkGqA7T5JhRQOs4spa+ihr-6RXA9xWwQRbRp6upLXBaw@mail.gmail.com>
> > This smells of an LLM generated patch. So i think you are somewhat
> > wasting your time explaining in detail why this is wrong.
> I have never used (and will not use) LLMs :(
Sorry, I need to refine my sense of smell.
> P.S: I'm still learning the ropes as a contributor so please pardon my
> ignorance.
You might find this interesting:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
You made a few process errors as well. Since you submitted this to
net, it needs a Fixes: tag.
Also:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
Particularly:
It must either fix a real bug that bothers people
Sparse warnings don't really both people. But is the sparse warning
indicating a read bug which does bother people? If so, net is O.K, but
please add to the commit message what the real bug is. If this is
simply cleanup, not a bug fix, please submit to net-next.
You can also learn a lot by subscribing to the netdev mailing list,
and reading other peoples patches, and review comments they get.
Andrew
next prev parent reply other threads:[~2025-08-10 20:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 17:11 [PATCH net] rds: Fix endian annotations across various assignments Ujwal Kundur
2025-08-10 17:32 ` Andrew Lunn
2025-08-10 17:47 ` Al Viro
2025-08-10 18:25 ` Al Viro
2025-08-10 18:27 ` Al Viro
2025-08-10 18:41 ` Andrew Lunn
2025-08-10 19:26 ` Al Viro
2025-08-10 19:31 ` Ujwal Kundur
2025-08-10 20:19 ` Andrew Lunn [this message]
2025-08-10 21:00 ` Al Viro
2025-08-10 21:13 ` Al Viro
2025-08-10 18:38 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a22c3c-ee9b-44cd-9e5a-a68bb366eba5@lunn.ch \
--to=andrew@lunn.ch \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=ujwal.kundur@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.