All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: (overlapping) lmb allocations during boot
Date: Sun, 31 Oct 2021 11:43:38 +0100	[thread overview]
Message-ID: <63a9d684653e3d19e621a8d978f44113@walle.cc> (raw)

Hi,

I sometimes see a corrupted initrd during kernel boot on my board
(kontron_sl28). Debugging showed that in this case the spin table
for the secondary CPUs overlaps with the lmb initrd allocations
(initrd_high is set).

I had a look at how the fdt and initrd are relocated (if enabled). In
summary, they use lmb_alloc() which will first add all available memory
and then carve out reserved regions. There are calls for arch
(arch_lmb_reserve()) and board (board_lmb_reserve()) callbacks. The
interesting thing is that, there is also code to carve out any
reserved regions which were added to the fdt earlier
(boot_fdt_add_mem_rsv_regions()). The problem here is, that the DT 
fixups,
which might add the reserved regions are called just before jumping to
linux. Thus both the allocation for the fdt (if fdt_high is set) and
the ramdisk (if initrd_high is set) will ignore any reserved memory
regions.

Unfortunately, I don't see any good way to fix this. You'd need all the
DT fixups before we can initialize the lmb. Also, I don't know if this
will affect any other areas; probably I'm the only one, who reserves an
area which is outside of the u-boot code and data segment.

A hackish way would be to carve out the spin_table code in
board_lmb_reserve(). But meh..

-michael

             reply	other threads:[~2021-10-31 10:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-31 10:43 Michael Walle [this message]
2021-10-31 11:44 ` (overlapping) lmb allocations during boot Mark Kettenis
2021-10-31 12:04   ` Michael Walle
2021-10-31 12:51     ` Mark Kettenis
2021-10-31 15:19       ` Michael Walle
2021-10-31 17:36         ` Mark Kettenis
2021-10-31 22:48           ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63a9d684653e3d19e621a8d978f44113@walle.cc \
    --to=michael@walle.cc \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.