All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 2 v3] manual: github commits should be specified in full
Date: Sat, 02 Nov 2013 15:57:27 +0100	[thread overview]
Message-ID: <63f3504eafe27efb9269.1383404247@argentina> (raw)
In-Reply-To: <patchbomb.1383404246@argentina>

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
v3: change tarball name in example (missed comment Samuel)
v2: remove parentheses around 'full' (comment Samuel)

 docs/manual/adding-packages-tips.txt |  7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/docs/manual/adding-packages-tips.txt b/docs/manual/adding-packages-tips.txt
--- a/docs/manual/adding-packages-tips.txt
+++ b/docs/manual/adding-packages-tips.txt
@@ -44,14 +44,13 @@ However, it is possible to download tarb
 on github.
 
 ------------------------
-FOO_VERSION = v1.0 # tag or (abbreviated) commit ID
+FOO_VERSION = v1.0 # tag or full commit ID
 FOO_SITE = http://github.com/<user>/<package>/tarball/$(FOO_VERSION)
 ------------------------
 
 .Notes
 - The FOO_VERSION can either be a tag or a commit ID.
 - The tarball name generated by github matches the default one from
-  Buildroot (e.g.: +foo-1234567.tar.gz+),
+  Buildroot (e.g.: +foo-f6fb6654af62045239caed5950bc6c7971965e60.tar.gz+),
   so it is not necessary to specify it in the +.mk+ file.
-- When using a commit ID as version, usually the first 7 characters of
-  the SHA1 are enough.
+- When using a commit ID as version, you should use the full 40 hex characters.

  reply	other threads:[~2013-11-02 14:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-02 14:57 [Buildroot] [PATCH 0 of 2 v3] Use full revision ID for git packages Thomas De Schampheleire
2013-11-02 14:57 ` Thomas De Schampheleire [this message]
2013-11-02 15:01   ` [Buildroot] [PATCH 1 of 2 v3] manual: github commits should be specified in full Samuel Martin
2013-11-02 14:57 ` [Buildroot] [PATCH 2 of 2 v3] git packages: use full revision hash Thomas De Schampheleire
2013-11-02 15:06   ` Yann E. MORIN
2013-11-02 15:24 ` [Buildroot] [PATCH 0 of 2 v3] Use full revision ID for git packages Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63f3504eafe27efb9269.1383404247@argentina \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.