From: Pavel Skripkin <paskripkin@gmail.com>
To: Ismayil Mirzali <ismayilmirzeli@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, simon.fodin@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: Fix styling issues
Date: Sat, 18 Dec 2021 23:55:11 +0300 [thread overview]
Message-ID: <63ff3ff8-e428-f0f6-eafc-3c517f34cb6c@gmail.com> (raw)
In-Reply-To: <20211218203647.24486-1-ismayilmirzeli@gmail.com>
On 12/18/21 23:36, Ismayil Mirzali wrote:
> Removed extra whitespaces and brackets for oneline if statements
>
> Signed-off-by: Ismayil Mirzali <ismayilmirzeli@gmail.com>
> ---
> .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 20 ++++++++-----------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 7fe3df863fe1..7807b2a6cdc5 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -32,7 +32,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter *padapter, u8 agg_num)
> pHalData->SdioTxOQTFreeSpace -= agg_num;
>
> /* if (n > 1) */
> - /* ++priv->pshare->nr_out_of_txoqt_space; */
> + /* ++priv->pshare->nr_out_of_txoqt_space; */
>
I believe, commented code should be just removed
> return true;
> }
[...]
> rtw_unregister_tx_alive(padapter);
> @@ -311,7 +310,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
> pxmitframe->pg_num = (txlen + 127) / 128;
> pxmitbuf->pg_num += (txlen + 127) / 128;
> /* if (k != 1) */
> - /* ((struct xmit_frame*)pxmitbuf->priv_data)->pg_num += pxmitframe->pg_num; */
> + /* ((struct xmit_frame*)pxmitbuf->priv_data)->pg_num += pxmitframe->pg_num; */
>
Same here
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-12-18 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 20:36 [PATCH] staging: rtl8723bs: Fix styling issues Ismayil Mirzali
2021-12-18 20:55 ` Pavel Skripkin [this message]
2022-01-05 9:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ff3ff8-e428-f0f6-eafc-3c517f34cb6c@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=ismayilmirzeli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=simon.fodin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.