From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:110e:b0:1be9:327d:8ee3 with SMTP id pu14csp1546302njb; Fri, 9 May 2025 23:13:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXboG7LBpHE/P1VdwnQw60BsAX75ogNFaP4YnoeHa30qtaE2xq8JO7K+OKXQeETZ9lSrRIOr40D3YMCRw==@linaro.org X-Google-Smtp-Source: AGHT+IEPkzDXaB3xd0qUZ7/3Yl8ik7IQa4UHQYnuLmFkfLfyGBvTRCFNqCUD+/2JTQ+LmeDFP4Un X-Received: by 2002:a05:6214:2523:b0:6e8:9797:f94e with SMTP id 6a1803df08f44-6f6e482d215mr96674606d6.35.1746857606986; Fri, 09 May 2025 23:13:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746857606; cv=none; d=google.com; s=arc-20240605; b=ECpYgal9/cJOaxe/rume4ume8fLaMwO+Gok07DYNSF8DtEzisq449L/ykDaRt8jipm /bQhVcyg377Bf/V4zvvDozXhZVifnlrTAlSn5PeXRsvqcEHGGDVQBqXbu5XAPhRfYvCs vDgPihRwteajIhDg1+YMPJpNhaF4MvWOh/b012WO8n7cYggmV3ryVBWJhCThffepSTVi IemP5USEMOjmL3I+UE32rFu6w1RyFQwpAG2iinARQGcn8eS8Hn6ozsnN5P1qiJWYknQM 5+Vq2WULxySEqjHXf4aucIO5n7FUo/Ary8t8e5771EJavuhN6BcZjG9vffh24jTU0D9x HPfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id; bh=MoSd+xGZQMu9Iaijmq/P4PY5t6t2i2QbPHu3L9ThkO8=; fh=gCXMQKs6lZ8CIfxrgvNmsucbxJPLBUoEizQFcmzUdmQ=; b=c086Cbm+q92kP2qb9Plh8tDQ/tnvyl57vn9c1ISZixGqpgWubx6Qrd4j0jrTWJEHOj rIz+k2lU6wAxuUro7Ae4NKmnqqahrW7ob9MeEoDeQMnxY8GrVR86DwwpTWaIHLq8EH95 ErjuaLu+tePOfSXlm54LY3bSWbzRjncdvacYDIrdxTm/R3hQXtgmplmlNpYvWhtFBvKN P5GaSQgpyZq2TvvxO7tr63OIQMxeQi3whB3qN+0RMJFQHDXNzHYX2QoVks8pNFK70dBh l+e+t4g+JcSYmrNs9b5KubnEuPdbGqJVg/ak9ezh7z15QKRmvgYSXInCfHfvGRGaczqA iv+g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6f6e39e7423si39223566d6.92.2025.05.09.23.13.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 May 2025 23:13:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uDdSU-0007Ut-TE; Sat, 10 May 2025 02:13:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDdSR-0007Th-24; Sat, 10 May 2025 02:13:11 -0400 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDdSO-0007Jy-Nn; Sat, 10 May 2025 02:13:10 -0400 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4ZvbC06pNHz4xRB; Sat, 10 May 2025 16:13:00 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4ZvbBw5BLSz4xQX; Sat, 10 May 2025 16:12:56 +1000 (AEST) Message-ID: <6407690d-0e50-42b1-9f9c-e98eb450d784@kaod.org> Date: Sat, 10 May 2025 08:12:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/22] hw/misc/aspeed_hace: Support accumulative mode for direct access mode To: Jamin Lin , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" Cc: Troy Lee References: <20250321092623.2097234-1-jamin_lin@aspeedtech.com> <20250321092623.2097234-7-jamin_lin@aspeedtech.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@kaod.org; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/ jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+ S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6 hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/ t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475 KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8 o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0 IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=HX7T=X2=kaod.org=clg@ozlabs.org; helo=mail.ozlabs.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: A3kzrZ7bvrzs On 5/9/25 08:55, Jamin Lin wrote: > Hi Cédric > >> Subject: Re: [PATCH v1 06/22] hw/misc/aspeed_hace: Support accumulative >> mode for direct access mode >> >> On 3/21/25 10:26, Jamin Lin wrote: >>> Enable accumulative mode for direct access mode operations. In direct >>> access mode, only a single source buffer is used, so the "iovec" count is set to >> 1. >>> If "acc_mode" is enabled: >>> 1. Accumulate "total_req_len" with the current request length ("plen"). >>> 2. Check for padding and determine whether this is the final request. >>> >>> Signed-off-by: Jamin Lin >>> --- >>> hw/misc/aspeed_hace.c | 15 ++++++++++++++- >>> 1 file changed, 14 insertions(+), 1 deletion(-) >>> >>> diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index >>> 8cf3f194a5..d06158dffd 100644 >>> --- a/hw/misc/aspeed_hace.c >>> +++ b/hw/misc/aspeed_hace.c >>> @@ -223,8 +223,21 @@ static void do_hash_operation(AspeedHACEState *s, >> int algo, bool sg_mode, >>> return; >>> } >>> iov[0].iov_base = haddr; >>> - iov[0].iov_len = plen; >>> i = 1; >>> + if (acc_mode) { >> >> hmm, more complexity is being added to do_hash_operation(). I would >> introduce a sub routine do_hash_operation_acc() to handle accumulative >> mode. >> > Thanks for the review and suggestion. > I refactor "do_hash_operation" and changes looks like as following > > New Helper functions: > > hash_get_source_addr > hash_prepare_direct_iov > hash_prepare_sg_iov > hash_get_digest_addr > hash_write_digest_and_unmap_iov > hash_execute_non_acc_mode > hash_execute_acc_mode > > ``` > static void do_hash_operation(AspeedHACEState *s, int algo, bool sg_mode, > bool acc_mode) > { > struct iovec iov[ASPEED_HACE_MAX_SG]; > bool acc_final_request = false; > int iov_idx = -1; > > /* Prepares the iov for hashing operations based on the selected mode */ > if (sg_mode) { > iov_idx = hash_prepare_sg_iov(s, iov, acc_mode, &acc_final_request); > } else { > iov_idx = hash_prepare_direct_iov(s, iov); > } > > if (iov_idx <= 0) { > qemu_log_mask(LOG_GUEST_ERROR, > "%s: Failed to prepare iov\n", __func__); > return; > } > > /* Executes the hash operation */ > if (acc_mode) { > hash_execute_acc_mode(s, algo, iov, iov_idx, acc_final_request); > } else { > hash_execute_non_acc_mode(s, algo, iov, iov_idx); > } > } This looks better. Thanks ! C.