From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: fix applications failure on configure Date: Tue, 01 May 2018 16:12:14 +0200 Message-ID: <6407794.aElEmAcKUa@xps> References: <20180501133343.125260-1-ferruh.yigit@intel.com> <14979049.G4nOY0bchV@xps> <3b002b01-7baa-cd51-cfbe-a70e8b5a0ae1@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: xuemingl@mellanox.com, dev@dpdk.org To: Ferruh Yigit Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 1616D28F3 for ; Tue, 1 May 2018 16:12:17 +0200 (CEST) In-Reply-To: <3b002b01-7baa-cd51-cfbe-a70e8b5a0ae1@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/05/2018 16:08, Ferruh Yigit: > On 5/1/2018 3:01 PM, Thomas Monjalon wrote: > > 01/05/2018 15:33, Ferruh Yigit: > >> Many sample applications fail because of > >> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure() > > > > We need to define the API behaviour in doxygen. > > > >> The sample applications need to be fixed/updated before returning error > >> on rte_eth_dev_configure() > >> > >> This patch keeps the error log but removes returning error. > > > > If the doc is updated in 18.05, we can have a deprecation notice > > to insert the error return in 18.08. > > +1 to add a deprecation notice for this release and do the error return on 18.08. > > Is the doc update you mentioned doxygen update? Yes, doxygen update. > Who can do doc update and deprecation notice patches for this release? Either you Ferruh, or Xueming and me together. What do you prefer? > >> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check") > >> Cc: xuemingl@mellanox.com > >> > >> Signed-off-by: Ferruh Yigit