diff for duplicates of <6407817.nLXe9rGL3b@nvdebian> diff --git a/a/1.txt b/N1/1.txt index d223fa2..ffc7462 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,10 +1,10 @@ On Monday, 15 March 2021 6:51:13 PM AEDT Christoph Hellwig wrote: > > - /*XXX: atomic? */ -> > - return (fa->access = 0 || fa->access = 3) - -> > - (fb->access = 0 || fb->access = 3); +> > - return (fa->access == 0 || fa->access == 3) - +> > - (fb->access == 0 || fb->access == 3); > > + /* Atomic access (2) has highest priority */ -> > + return (-1*(fa->access = 2) + (fa->access = 0 || fa->access = 3)) - -> > + (-1*(fb->access = 2) + (fb->access = 0 || fb->access = 3)); +> > + return (-1*(fa->access == 2) + (fa->access == 0 || fa->access == 3)) - +> > + (-1*(fb->access == 2) + (fb->access == 0 || fb->access == 3)); > > This looks really unreabable. If the magic values 0, 2 and 3 had names > it might become a little more understadable, then factor the duplicated diff --git a/a/content_digest b/N1/content_digest index 338e6a1..7049ee2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,31 +3,31 @@ "ref\020210315075113.GD4136862@infradead.org\0" "From\0Alistair Popple <apopple@nvidia.com>\0" "Subject\0Re: [PATCH v6 8/8] nouveau/svm: Implement atomic SVM access\0" - "Date\0Mon, 22 Mar 2021 09:27:33 +0000\0" + "Date\0Mon, 22 Mar 2021 20:27:33 +1100\0" "To\0Christoph Hellwig <hch@infradead.org>\0" - "Cc\0linux-mm@kvack.org" - nouveau@lists.freedesktop.org - bskeggs@redhat.com - akpm@linux-foundation.org - linux-doc@vger.kernel.org - linux-kernel@vger.kernel.org - kvm-ppc@vger.kernel.org - dri-devel@lists.freedesktop.org - jhubbard@nvidia.com - rcampbell@nvidia.com - jglisse@redhat.com - jgg@nvidia.com - daniel@ffwll.ch - " willy@infradead.org\0" + "Cc\0<linux-mm@kvack.org>" + <nouveau@lists.freedesktop.org> + <bskeggs@redhat.com> + <akpm@linux-foundation.org> + <linux-doc@vger.kernel.org> + <linux-kernel@vger.kernel.org> + <kvm-ppc@vger.kernel.org> + <dri-devel@lists.freedesktop.org> + <jhubbard@nvidia.com> + <rcampbell@nvidia.com> + <jglisse@redhat.com> + <jgg@nvidia.com> + <daniel@ffwll.ch> + " <willy@infradead.org>\0" "\00:1\0" "b\0" "On Monday, 15 March 2021 6:51:13 PM AEDT Christoph Hellwig wrote:\n" "> > -\t/*XXX: atomic? */\n" - "> > -\treturn (fa->access = 0 || fa->access = 3) -\n" - "> > -\t (fb->access = 0 || fb->access = 3);\n" + "> > -\treturn (fa->access == 0 || fa->access == 3) -\n" + "> > -\t (fb->access == 0 || fb->access == 3);\n" "> > +\t/* Atomic access (2) has highest priority */\n" - "> > +\treturn (-1*(fa->access = 2) + (fa->access = 0 || fa->access = 3)) -\n" - "> > +\t (-1*(fb->access = 2) + (fb->access = 0 || fb->access = 3));\n" + "> > +\treturn (-1*(fa->access == 2) + (fa->access == 0 || fa->access == 3)) -\n" + "> > +\t (-1*(fb->access == 2) + (fb->access == 0 || fb->access == 3));\n" "> \n" "> This looks really unreabable. If the magic values 0, 2 and 3 had names\n" "> it might become a little more understadable, then factor the duplicated\n" @@ -57,4 +57,4 @@ "I had copied that from nouveau_range_fault() but this suggestion is better. \n" Will update, thanks for looking. -9f115ccf6cf6e215d0af8df943e636121266185ac79d9b4be4afc2f06e41d61f +2cc8bb32cac2932cb78afd05d98ed741ccc832daa0fb449b3ccd0ae2222e861b
diff --git a/a/1.txt b/N2/1.txt index d223fa2..1c41ce3 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,10 +1,10 @@ On Monday, 15 March 2021 6:51:13 PM AEDT Christoph Hellwig wrote: > > - /*XXX: atomic? */ -> > - return (fa->access = 0 || fa->access = 3) - -> > - (fb->access = 0 || fb->access = 3); +> > - return (fa->access == 0 || fa->access == 3) - +> > - (fb->access == 0 || fb->access == 3); > > + /* Atomic access (2) has highest priority */ -> > + return (-1*(fa->access = 2) + (fa->access = 0 || fa->access = 3)) - -> > + (-1*(fb->access = 2) + (fb->access = 0 || fb->access = 3)); +> > + return (-1*(fa->access == 2) + (fa->access == 0 || fa->access == 3)) - +> > + (-1*(fb->access == 2) + (fb->access == 0 || fb->access == 3)); > > This looks really unreabable. If the magic values 0, 2 and 3 had names > it might become a little more understadable, then factor the duplicated @@ -33,3 +33,10 @@ Fair enough, will add some definitions for the magic values. I had copied that from nouveau_range_fault() but this suggestion is better. Will update, thanks for looking. + + + +_______________________________________________ +Nouveau mailing list +Nouveau@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/nouveau diff --git a/a/content_digest b/N2/content_digest index 338e6a1..142e60a 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,32 +2,30 @@ "ref\020210312083851.15981-9-apopple@nvidia.com\0" "ref\020210315075113.GD4136862@infradead.org\0" "From\0Alistair Popple <apopple@nvidia.com>\0" - "Subject\0Re: [PATCH v6 8/8] nouveau/svm: Implement atomic SVM access\0" - "Date\0Mon, 22 Mar 2021 09:27:33 +0000\0" + "Subject\0Re: [Nouveau] [PATCH v6 8/8] nouveau/svm: Implement atomic SVM access\0" + "Date\0Mon, 22 Mar 2021 20:27:33 +1100\0" "To\0Christoph Hellwig <hch@infradead.org>\0" - "Cc\0linux-mm@kvack.org" - nouveau@lists.freedesktop.org - bskeggs@redhat.com - akpm@linux-foundation.org + "Cc\0rcampbell@nvidia.com" + willy@infradead.org + daniel@ffwll.ch linux-doc@vger.kernel.org + nouveau@lists.freedesktop.org + dri-devel@lists.freedesktop.org linux-kernel@vger.kernel.org kvm-ppc@vger.kernel.org - dri-devel@lists.freedesktop.org - jhubbard@nvidia.com - rcampbell@nvidia.com - jglisse@redhat.com + linux-mm@kvack.org + bskeggs@redhat.com jgg@nvidia.com - daniel@ffwll.ch - " willy@infradead.org\0" + " akpm@linux-foundation.org\0" "\00:1\0" "b\0" "On Monday, 15 March 2021 6:51:13 PM AEDT Christoph Hellwig wrote:\n" "> > -\t/*XXX: atomic? */\n" - "> > -\treturn (fa->access = 0 || fa->access = 3) -\n" - "> > -\t (fb->access = 0 || fb->access = 3);\n" + "> > -\treturn (fa->access == 0 || fa->access == 3) -\n" + "> > -\t (fb->access == 0 || fb->access == 3);\n" "> > +\t/* Atomic access (2) has highest priority */\n" - "> > +\treturn (-1*(fa->access = 2) + (fa->access = 0 || fa->access = 3)) -\n" - "> > +\t (-1*(fb->access = 2) + (fb->access = 0 || fb->access = 3));\n" + "> > +\treturn (-1*(fa->access == 2) + (fa->access == 0 || fa->access == 3)) -\n" + "> > +\t (-1*(fb->access == 2) + (fb->access == 0 || fb->access == 3));\n" "> \n" "> This looks really unreabable. If the magic values 0, 2 and 3 had names\n" "> it might become a little more understadable, then factor the duplicated\n" @@ -55,6 +53,13 @@ "> \t}\n" "\n" "I had copied that from nouveau_range_fault() but this suggestion is better. \n" - Will update, thanks for looking. + "Will update, thanks for looking.\n" + "\n" + "\n" + "\n" + "_______________________________________________\n" + "Nouveau mailing list\n" + "Nouveau@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/nouveau -9f115ccf6cf6e215d0af8df943e636121266185ac79d9b4be4afc2f06e41d61f +165404ba9765282fe5c03e291317f8fcb7cad9ff3d53462159badf21574e298f
diff --git a/a/1.txt b/N3/1.txt index d223fa2..834c161 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -1,10 +1,10 @@ On Monday, 15 March 2021 6:51:13 PM AEDT Christoph Hellwig wrote: > > - /*XXX: atomic? */ -> > - return (fa->access = 0 || fa->access = 3) - -> > - (fb->access = 0 || fb->access = 3); +> > - return (fa->access == 0 || fa->access == 3) - +> > - (fb->access == 0 || fb->access == 3); > > + /* Atomic access (2) has highest priority */ -> > + return (-1*(fa->access = 2) + (fa->access = 0 || fa->access = 3)) - -> > + (-1*(fb->access = 2) + (fb->access = 0 || fb->access = 3)); +> > + return (-1*(fa->access == 2) + (fa->access == 0 || fa->access == 3)) - +> > + (-1*(fb->access == 2) + (fb->access == 0 || fb->access == 3)); > > This looks really unreabable. If the magic values 0, 2 and 3 had names > it might become a little more understadable, then factor the duplicated @@ -33,3 +33,10 @@ Fair enough, will add some definitions for the magic values. I had copied that from nouveau_range_fault() but this suggestion is better. Will update, thanks for looking. + + + +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N3/content_digest index 338e6a1..3824ae4 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,31 +3,30 @@ "ref\020210315075113.GD4136862@infradead.org\0" "From\0Alistair Popple <apopple@nvidia.com>\0" "Subject\0Re: [PATCH v6 8/8] nouveau/svm: Implement atomic SVM access\0" - "Date\0Mon, 22 Mar 2021 09:27:33 +0000\0" + "Date\0Mon, 22 Mar 2021 20:27:33 +1100\0" "To\0Christoph Hellwig <hch@infradead.org>\0" - "Cc\0linux-mm@kvack.org" - nouveau@lists.freedesktop.org - bskeggs@redhat.com - akpm@linux-foundation.org + "Cc\0rcampbell@nvidia.com" + willy@infradead.org linux-doc@vger.kernel.org + nouveau@lists.freedesktop.org + dri-devel@lists.freedesktop.org linux-kernel@vger.kernel.org kvm-ppc@vger.kernel.org - dri-devel@lists.freedesktop.org - jhubbard@nvidia.com - rcampbell@nvidia.com + linux-mm@kvack.org jglisse@redhat.com + bskeggs@redhat.com jgg@nvidia.com - daniel@ffwll.ch - " willy@infradead.org\0" + jhubbard@nvidia.com + " akpm@linux-foundation.org\0" "\00:1\0" "b\0" "On Monday, 15 March 2021 6:51:13 PM AEDT Christoph Hellwig wrote:\n" "> > -\t/*XXX: atomic? */\n" - "> > -\treturn (fa->access = 0 || fa->access = 3) -\n" - "> > -\t (fb->access = 0 || fb->access = 3);\n" + "> > -\treturn (fa->access == 0 || fa->access == 3) -\n" + "> > -\t (fb->access == 0 || fb->access == 3);\n" "> > +\t/* Atomic access (2) has highest priority */\n" - "> > +\treturn (-1*(fa->access = 2) + (fa->access = 0 || fa->access = 3)) -\n" - "> > +\t (-1*(fb->access = 2) + (fb->access = 0 || fb->access = 3));\n" + "> > +\treturn (-1*(fa->access == 2) + (fa->access == 0 || fa->access == 3)) -\n" + "> > +\t (-1*(fb->access == 2) + (fb->access == 0 || fb->access == 3));\n" "> \n" "> This looks really unreabable. If the magic values 0, 2 and 3 had names\n" "> it might become a little more understadable, then factor the duplicated\n" @@ -55,6 +54,13 @@ "> \t}\n" "\n" "I had copied that from nouveau_range_fault() but this suggestion is better. \n" - Will update, thanks for looking. + "Will update, thanks for looking.\n" + "\n" + "\n" + "\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -9f115ccf6cf6e215d0af8df943e636121266185ac79d9b4be4afc2f06e41d61f +65aaf36d9cde325709f577393e2d8f935076338194e5c5de5c13b720edd736e8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.