From: Evgeny Iakovlev <eiakovlev@linux.microsoft.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [PATCH v2 1/2] target/arm: implement DBGCLAIM registers
Date: Thu, 19 Jan 2023 23:03:40 +0100 [thread overview]
Message-ID: <640fb5b5-6524-9cce-22c6-fe94df80e91d@linux.microsoft.com> (raw)
In-Reply-To: <16c2871a-9e2a-5113-a121-5373d6e4bb71@linaro.org>
On 1/17/2023 16:48, Richard Henderson wrote:
> On 1/17/23 05:04, Evgeny Iakovlev wrote:
>> + { .name = "DBGCLAIMCLR_EL1", .state = ARM_CP_STATE_BOTH,
>> + .cp = 14, .opc0 = 2, .opc1 = 0, .crn = 7, .crm = 9, .opc2 = 6,
>> + .access = PL1_RW, .accessfn = access_tda,
>> + .writefn = dbgclaimclr_write, .raw_writefn =
>> dbgclaimclr_raw_write,
>> + .fieldoffset = offsetof(CPUARMState, cp15.dbgclaim) },
>
> You didn't need a new function, just .raw_writefn = raw_write
> (which then uses .fieldoffset to dtrt).
Ah, i see, okay.
>
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~
next prev parent reply other threads:[~2023-01-19 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 15:04 [PATCH v2 0/2] various aarch64 fixes for running Hyper-V on TCG Evgeny Iakovlev
2023-01-17 15:04 ` [PATCH v2 1/2] target/arm: implement DBGCLAIM registers Evgeny Iakovlev
2023-01-17 15:48 ` Richard Henderson
2023-01-19 22:03 ` Evgeny Iakovlev [this message]
2023-01-17 15:04 ` [PATCH v2 2/2] target/arm: provide stubs for more external debug registers Evgeny Iakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=640fb5b5-6524-9cce-22c6-fe94df80e91d@linux.microsoft.com \
--to=eiakovlev@linux.microsoft.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.