All of lore.kernel.org
 help / color / mirror / Atom feed
From: subashab@codeaurora.org
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: David Miller <davem@davemloft.net>,
	eric.dumazet@gmail.com, netdev@vger.kernel.org,
	mptcp@lists.01.org, netdev-owner@vger.kernel.org
Subject: Re: [PATCH net-next v3 07/11] tcp: Prevent coalesce/collapse when skb has MPTCP extensions
Date: Wed, 18 Dec 2019 14:36:09 -0700	[thread overview]
Message-ID: <6411d0366a6ec6a30f9dbf4117ea6d1f@codeaurora.org> (raw)
In-Reply-To: <alpine.OSX.2.21.1912181251550.32925@mjmartin-mac01.local>

> Ok, understood. Not every packet has this MPTCP extension data so
> coalescing was not always turned off, but given the importance of
> avoiding
> 
> this memory waste I'll confirm GRO behavior and work on maintaining
> coalesce/collapse with identical MPTCP extension data.
> 

Hi Mat

Are identical MPTCP extensions a common case?
AFAIK the data sequence number and the subflow sequence number change
per packet even in a single stream scenario.

  reply	other threads:[~2019-12-18 21:36 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 20:37 [MPTCP] [PATCH net-next v3 00/11] Multipath TCP: Prerequisites Mat Martineau
2019-12-17 20:37 ` Mat Martineau
2019-12-17 20:38 ` [MPTCP] [PATCH net-next v3 07/11] tcp: Prevent coalesce/collapse when skb has MPTCP extensions Mat Martineau
2019-12-17 20:38   ` Mat Martineau
2019-12-18 19:50   ` [MPTCP] " Eric Dumazet
2019-12-18 19:50     ` Eric Dumazet
2019-12-18 20:45     ` [MPTCP] " David Miller
2019-12-18 20:45       ` David Miller
2019-12-18 21:02       ` [MPTCP] " Mat Martineau
2019-12-18 21:02         ` Mat Martineau
2019-12-18 21:36         ` subashab [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-12-17 20:37 [MPTCP] [PATCH net-next v3 01/11] net: Make sock protocol value checks more specific Mat Martineau
2019-12-17 20:37 ` Mat Martineau
2019-12-17 20:37 [MPTCP] [PATCH net-next v3 02/11] sock: Make sk_protocol a 16-bit value Mat Martineau
2019-12-17 20:37 ` Mat Martineau
2019-12-17 20:37 [MPTCP] [PATCH net-next v3 03/11] tcp: Define IPPROTO_MPTCP Mat Martineau
2019-12-17 20:37 ` Mat Martineau
2019-12-17 20:38 [MPTCP] [PATCH net-next v3 04/11] tcp: Add MPTCP option number Mat Martineau
2019-12-17 20:38 ` Mat Martineau
2019-12-17 20:38 [MPTCP] [PATCH net-next v3 05/11] tcp, ulp: Add clone operation to tcp_ulp_ops Mat Martineau
2019-12-17 20:38 ` Mat Martineau
2019-12-17 20:38 [MPTCP] [PATCH net-next v3 06/11] mptcp: Add MPTCP to skb extensions Mat Martineau
2019-12-17 20:38 ` Mat Martineau
2019-12-17 20:38 [MPTCP] [PATCH net-next v3 08/11] tcp: Export TCP functions and ops struct Mat Martineau
2019-12-17 20:38 ` Mat Martineau
2019-12-17 20:38 [MPTCP] [PATCH net-next v3 09/11] tcp: Check for filled TCP option space before SACK Mat Martineau
2019-12-17 20:38 ` Mat Martineau
2019-12-17 20:38 [MPTCP] [PATCH net-next v3 10/11] tcp: clean ext on tx recycle Mat Martineau
2019-12-17 20:38 ` Mat Martineau
2019-12-17 20:38 [MPTCP] [PATCH net-next v3 11/11] skb: add helpers to allocate ext independently from sk_buff Mat Martineau
2019-12-17 20:38 ` Mat Martineau
2019-12-18 21:52 [MPTCP] Re: [PATCH net-next v3 07/11] tcp: Prevent coalesce/collapse when skb has MPTCP extensions Paolo Abeni
2019-12-18 21:52 ` Paolo Abeni
2019-12-18 22:15 [MPTCP] " Paolo Abeni
2019-12-18 22:15 ` Paolo Abeni
2019-12-18 23:17 David Miller
2019-12-18 23:17 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6411d0366a6ec6a30f9dbf4117ea6d1f@codeaurora.org \
    --to=subashab@codeaurora.org \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.01.org \
    --cc=netdev-owner@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.